From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6601C61DA4 for ; Sat, 28 Jan 2023 07:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233793AbjA1HfS (ORCPT ); Sat, 28 Jan 2023 02:35:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233662AbjA1HfJ (ORCPT ); Sat, 28 Jan 2023 02:35:09 -0500 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03A803D911 for ; Fri, 27 Jan 2023 23:34:57 -0800 (PST) Received: by mail-pg1-x532.google.com with SMTP id v3so4563784pgh.4 for ; Fri, 27 Jan 2023 23:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VSzzcrZHpCAhZ5ULfCoy554S0eFulAfOQZjabEFT0U8=; b=T6LKh5CR8Si1HhKOUOGGGtZ6+5L8QCDzffO83OhZP2wPlLcupyHUy8bxsfcm8v8cZ/ j/3yaxzN8/IO3o6B/J2ZsXS3POXQlpJG5U9RkT8mKeAbGUGrJsmRBdHQ2xULA4UQhGqf zKLVdpZ1DrH+Ji4aokYjjs7mbouXc5esEsTOJ/ntzTKiT6IkydC8+bkHwec1Og+MUxr0 hXNtqQGQVu8qI2xASbYOzyQVR63cGIoNL3Me9EcDqvlg2CkGQqU8vPcIbc6cvzwKo+70 ZUFzjUxjTnxSefwef5FGjcIYJ5dpXAlOlag4Rt23C89TQdrXibm+UEG3fZfhVxtUazd9 9bkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VSzzcrZHpCAhZ5ULfCoy554S0eFulAfOQZjabEFT0U8=; b=2PJ7qG2gc989jpEhUWk9kfPQpBtNzCTBOLeVMeSnZogO2vmQAGrZEFTJwH0+iti2Iu 1k+LGWe+57pn1KSZocgEXTfzMUkWnncorFvpXE4d3wvZPvGwrFwT2w/ZKTpMSRfbj6bH z3QkrjYVW/heMw1ipCF9ldYWvwi199zwBlg9dfHXYk6V85aihr22WJr6Kcy1rNPrvHco J/YoCuDDdIrm0S004Y5Vxr/L9WmGROkSl1XYRNxagb0DMmTfGB1XnTA0Wk3uhuLMsas1 t4gXqq4sHJBozKOY+c/Xn89niJZG7bL5fR6Hm69XKY64JpmO2tD9gsZsMDI+8rmMboh0 gyVg== X-Gm-Message-State: AFqh2koRLq8zYPCgZmhIxb/sqlxPE0A9oBA95UCvvZ37Qyawnoppw6nU VzxASEbE6ZjOHR2ktmJXj1O8VfBwGi7CP9Z9zxMGEw== X-Google-Smtp-Source: AMrXdXswL1uNSyC4P6OZZsmWvEys2JlxAMsY9Dtx/ZhkSOaPgA1JW1DbGLOznM5iRN4ulYnMstMca6Cy78SGFhjnIGo= X-Received: by 2002:aa7:820f:0:b0:58d:a713:d1dd with SMTP id k15-20020aa7820f000000b0058da713d1ddmr5316394pfi.59.1674891296202; Fri, 27 Jan 2023 23:34:56 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-7-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Fri, 27 Jan 2023 23:34:19 -0800 Message-ID: Subject: Re: [PATCH v2 06/11] driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle To: Andy Shevchenko Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jan 27, 2023 at 1:33 AM Andy Shevchenko wrote: > > On Thu, Jan 26, 2023 at 04:11:33PM -0800, Saravana Kannan wrote: > > To improve detection and handling of dependency cycles, we need to be > > able to mark fwnode links as being part of cycles. fwnode links marked > > as being part of a cycle should not block their consumers from probing. > > ... > > > + list_for_each_entry(link, &fwnode->suppliers, c_hook) { > > + if (link->flags & FWLINK_FLAG_CYCLE) > > + continue; > > + return link->supplier; > > Hmm... Thanks! > > if (!(link->flags & FWLINK_FLAG_CYCLE)) > return link->supplier; > > ? > > > + } > > + > > + return NULL; > > ... > > > - if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) && > > - !fw_devlink_is_permissive()) { > > - sup_fw = list_first_entry(&dev->fwnode->suppliers, > > - struct fwnode_link, > > - c_hook)->supplier; > > + sup_fw = fwnode_links_check_suppliers(dev->fwnode); > > dev_fwnode() ? > > ... > > > - val = !list_empty(&dev->fwnode->suppliers); > > + mutex_lock(&fwnode_link_lock); > > + val = !!fwnode_links_check_suppliers(dev->fwnode); > > Ditto? Similar response as Patch 1 and Patch 4. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A26EC38142 for ; Sat, 28 Jan 2023 07:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=utWwElEtNM+H4xYHFHJmzrtC5tHYCHYnsrUHdYvT/s4=; b=oJm8q9rV7uwW2S kCUFPNlxyxZPvJXQjMTlGlSc5S/5SZFnStWT9yLQ8yuQshbW4aoglHKEo8f8w7zJLtQzYvsDg0JbV xWEfCn6Gz6Q+Fal9fdflmhxzdsRcEKFnWcpzVAG4ADA78lOc5X89nPTlXMUMRc43t13v4xxbvNJXG jNaOXv+UTPYUv1KIcw3QIsB8RMtyepXqxk2+bO/Tt8y2X1kwizHkvbuf4luNn9l1pduia7m05fPfi p7bmQQwon1bY6rLyuef79Hp5EzYUJa2FIJqYGO7k+gwx/RbfhcauG7BcZjhd0qT1USyTw1HwEj/XU AjExeO4sw7TBHezctmeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLfjr-00HMwF-Tx; Sat, 28 Jan 2023 07:35:04 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLfjm-00HMtZ-2s for linux-arm-kernel@lists.infradead.org; Sat, 28 Jan 2023 07:34:59 +0000 Received: by mail-pg1-x52a.google.com with SMTP id 141so4592583pgc.0 for ; Fri, 27 Jan 2023 23:34:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VSzzcrZHpCAhZ5ULfCoy554S0eFulAfOQZjabEFT0U8=; b=T6LKh5CR8Si1HhKOUOGGGtZ6+5L8QCDzffO83OhZP2wPlLcupyHUy8bxsfcm8v8cZ/ j/3yaxzN8/IO3o6B/J2ZsXS3POXQlpJG5U9RkT8mKeAbGUGrJsmRBdHQ2xULA4UQhGqf zKLVdpZ1DrH+Ji4aokYjjs7mbouXc5esEsTOJ/ntzTKiT6IkydC8+bkHwec1Og+MUxr0 hXNtqQGQVu8qI2xASbYOzyQVR63cGIoNL3Me9EcDqvlg2CkGQqU8vPcIbc6cvzwKo+70 ZUFzjUxjTnxSefwef5FGjcIYJ5dpXAlOlag4Rt23C89TQdrXibm+UEG3fZfhVxtUazd9 9bkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VSzzcrZHpCAhZ5ULfCoy554S0eFulAfOQZjabEFT0U8=; b=y8yYn+785HCvvbUv0c1RTFbohDJpNqFKHbQQ0yJykla4gNQeVHaLGxmvLUBAw3LD7a wt8o6iKH5BV9FDKBaOaiuqU8FZR+MWG/pylKSadhuSnTtrN3DScSmBotJqmjxl89bW7O z7vxp9a1iYEvPVPqK3v2ljgtHRG712BpszSdzK4lmGMzlNmuBZdf74YkJyPv4wy4Ca9l puCCnAUhdFeuBcZ6okSXi2Ljnexavw5spRv9+QLGdJiEgVD76pQEGSSx4obsv5ExpFW0 hvqTurc09PWZMLhuDwyYLuY4kfEYiSYcUuBIjaxwxrpQkpdZBDbm41wPP4BU74zIbhbu j02Q== X-Gm-Message-State: AFqh2kp7JbdLTfo2KAkjEtoqERoMeCU9rTfiOaFzNxm+WgZeHZunoug6 fJ+yyQ46gl6bjDI232aO/iJLNNwXENeKM7MHWe5tWw== X-Google-Smtp-Source: AMrXdXswL1uNSyC4P6OZZsmWvEys2JlxAMsY9Dtx/ZhkSOaPgA1JW1DbGLOznM5iRN4ulYnMstMca6Cy78SGFhjnIGo= X-Received: by 2002:aa7:820f:0:b0:58d:a713:d1dd with SMTP id k15-20020aa7820f000000b0058da713d1ddmr5316394pfi.59.1674891296202; Fri, 27 Jan 2023 23:34:56 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-7-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Fri, 27 Jan 2023 23:34:19 -0800 Message-ID: Subject: Re: [PATCH v2 06/11] driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle To: Andy Shevchenko Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_233458_155169_CE2CF7AE X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 1:33 AM Andy Shevchenko wrote: > > On Thu, Jan 26, 2023 at 04:11:33PM -0800, Saravana Kannan wrote: > > To improve detection and handling of dependency cycles, we need to be > > able to mark fwnode links as being part of cycles. fwnode links marked > > as being part of a cycle should not block their consumers from probing. > > ... > > > + list_for_each_entry(link, &fwnode->suppliers, c_hook) { > > + if (link->flags & FWLINK_FLAG_CYCLE) > > + continue; > > + return link->supplier; > > Hmm... Thanks! > > if (!(link->flags & FWLINK_FLAG_CYCLE)) > return link->supplier; > > ? > > > + } > > + > > + return NULL; > > ... > > > - if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) && > > - !fw_devlink_is_permissive()) { > > - sup_fw = list_first_entry(&dev->fwnode->suppliers, > > - struct fwnode_link, > > - c_hook)->supplier; > > + sup_fw = fwnode_links_check_suppliers(dev->fwnode); > > dev_fwnode() ? > > ... > > > - val = !list_empty(&dev->fwnode->suppliers); > > + mutex_lock(&fwnode_link_lock); > > + val = !!fwnode_links_check_suppliers(dev->fwnode); > > Ditto? Similar response as Patch 1 and Patch 4. -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel