From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185EDC4320A for ; Thu, 26 Aug 2021 04:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED5DD60EFE for ; Thu, 26 Aug 2021 04:46:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238049AbhHZErG (ORCPT ); Thu, 26 Aug 2021 00:47:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbhHZErE (ORCPT ); Thu, 26 Aug 2021 00:47:04 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6647CC061757 for ; Wed, 25 Aug 2021 21:46:17 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id p83so1380046yba.7 for ; Wed, 25 Aug 2021 21:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LgdL5as35+i2mHlUCdQc4m6L0YmfdSZa77eRS39qBnA=; b=WrQhDyryIaGyHF+wUrhDTQGAekquZHmBoUQGHFuwMpk4D62D+QwNVo0yeK1CmQfw+T TFVY6mEdnd09CI1xNYFtKe4Nc2qOhywN1cf0C+UvT66lew1NtVERVR4j/xDAtkOTiRWW 0wVARsJZjBwPQQIyl/VvMS2LqAkzn/9JUhO+PmFpXNTSx5g/cnGNC7oIrT53cWnbim+b Wav1jCUrhaaRtKAkt9FdbR7HY/YIu3uhR45Mrd/6b1yeBiJeNiKCHEgymyn29zuZXg/x JtxrY2v02fJAxkJVVpnbd1I9wovoDx5cPYEnydpIth9SgPH4f2rFutVD4IoA2Hf0LAsl 7PVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LgdL5as35+i2mHlUCdQc4m6L0YmfdSZa77eRS39qBnA=; b=hTFTBsoxpz8w1nSjmvLuRiIxoEzD2F/7T1c8nnD5JtkIpP3jdUlwSrm3lM+hYM/m9K ui6NYqdmM1FDzPAuEh2uDPfoSPQ9WyNam+kWQVORTzl/JOY0FkCaHdxabna/nn0cpD9d U5xZxIkGyZhjHnH1rK5RZEpNPyAIH6Ixev2mI4MFFs3Cro4E076j9iEILgSwMZlwAjP8 ZYtirSiJLvpJCxeTJiEhq5CF9nT/zPk0wMQlOwatDm1fYTvNUM++RPJ4j+gxFrhet+oV vCY5pEm8BX4VK0oubkL6FsPvVQW/piUBnd/Nm8vgqFLIGTBIgZ2Vq06kvbotYIAD1eou /Okg== X-Gm-Message-State: AOAM533ne+HcieXkFVfHj79Os9X8pE9JrONQW3UUQ0KswUFgEcTfMzxg 5A6h3/jDaEhGl8YelHiVdyCnPXxkR3aCQt/O+Qo9xQ== X-Google-Smtp-Source: ABdhPJzsaBSC4K7dz+AKCr2HuRqOibJQ2FbCOIa7HlSYjw1OSkdTpyGN+6glSGWQLia7J3JzHEja4XJNj+dLfR1S84s= X-Received: by 2002:a25:804:: with SMTP id 4mr2697573ybi.346.1629953176343; Wed, 25 Aug 2021 21:46:16 -0700 (PDT) MIME-Version: 1.0 References: <20210816074619.177383-1-wangkefeng.wang@huawei.com> <20210816074619.177383-4-wangkefeng.wang@huawei.com> In-Reply-To: From: Saravana Kannan Date: Wed, 25 Aug 2021 21:45:40 -0700 Message-ID: Subject: Re: [PATCH 3/3] amba: Properly handle device probe without IRQ domain To: Kefeng Wang Cc: Rob Herring , "linux-kernel@vger.kernel.org" , Frank Rowand , devicetree@vger.kernel.org, Russell King , Linus Walleij , linux-arm-kernel , Ruizhe Lin Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 25, 2021 at 7:45 PM Kefeng Wang wrote: > > > On 2021/8/25 16:04, Saravana Kannan wrote: > > On Tue, Aug 24, 2021 at 9:05 PM Kefeng Wang wrote: > >> > >> On 2021/8/25 4:08, Saravana Kannan wrote: > >>> On Tue, Aug 24, 2021 at 1:05 PM Rob Herring wrote: > >>>> +Saravana > >>>> > >>>> Saravana mentioned to me there may be some issues with this one... > >>>> > >>>> > >>>> On Mon, Aug 16, 2021 at 2:43 AM Kefeng Wang wrote: > >>>>> of_amba_device_create() uses irq_of_parse_and_map() to translate > >>>>> a DT interrupt specification into a Linux virtual interrupt number. > >>>>> > >>>>> But it doesn't properly handle the case where the interrupt controller > >>>>> is not yet available, eg, when pl011 interrupt is connected to MBIGEN > >>>>> interrupt controller, because the mbigen initialization is too late, > >>>>> which will lead to no IRQ due to no IRQ domain found, log is shown below, > >>>>> "irq: no irq domain found for uart0 !" > >>>>> > >>>>> use of_irq_get() to return -EPROBE_DEFER as above, and in the function > >>>>> amba_device_try_add()/amba_device_add(), it will properly handle in such > >>>>> case, also return 0 in other fail cases to be consistent as before. > >>>>> > >>>>> Cc: Russell King > >>>>> Cc: Rob Herring > >>>>> Cc: Frank Rowand > >>>>> Reported-by: Ruizhe Lin > >>>>> Signed-off-by: Kefeng Wang > >>>>> --- > >>>>> drivers/amba/bus.c | 27 +++++++++++++++++++++++++++ > >>>>> drivers/of/platform.c | 6 +----- > >>>>> 2 files changed, 28 insertions(+), 5 deletions(-) > >>>>> > >>>>> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c > >>>>> index 36f2f42c8014..720aa6cdd402 100644 > >>>>> --- a/drivers/amba/bus.c > >>>>> +++ b/drivers/amba/bus.c > >>>>> @@ -19,6 +19,7 @@ > >>>>> #include > >>>>> #include > >>>>> #include > >>>>> +#include > >>>>> > >>>>> #include > >>>>> > >>>>> @@ -371,12 +372,38 @@ static void amba_device_release(struct device *dev) > >>>>> kfree(d); > >>>>> } > >>>>> > >>>>> +static int of_amba_device_decode_irq(struct amba_device *dev) > >>>>> +{ > >>>>> + struct device_node *node = dev->dev.of_node; > >>>>> + int i, irq = 0; > >>>>> + > >>>>> + if (IS_ENABLED(CONFIG_OF_IRQ) && node) { > >>>>> + /* Decode the IRQs and address ranges */ > >>>>> + for (i = 0; i < AMBA_NR_IRQS; i++) { > >>>>> + irq = of_irq_get(node, i); > >>>>> + if (irq < 0) { > >>>>> + if (irq == -EPROBE_DEFER) > >>>>> + return irq; > >>>>> + irq = 0; > >>>>> + } > >>>>> + > >>>>> + dev->irq[i] = irq; > >>>>> + } > >>>>> + } > >>>>> + > >>>>> + return 0; > >>>>> +} > >>>>> + > >>>>> static int amba_device_try_add(struct amba_device *dev, struct resource *parent) > >>>>> { > >>>>> u32 size; > >>>>> void __iomem *tmp; > >>>>> int i, ret; > >>>>> > >>>>> + ret = of_amba_device_decode_irq(dev); > >>>>> + if (ret) > >>>>> + goto err_out; > >>>>> + > >>> Similar to other resources the AMBA bus "gets" for the device, I think > >>> this should be moved into amba_probe() and not here. There's no reason > >>> to delay the addition of the device (and loading its module) because > >>> the IRQ isn't ready yet. > >> The following code in the amba_device_try_add() will be called, it uses irq[0] > >> and irq[1], so I put of_amba_device_decode_irq() into amba_device_try_add(). > >> > >> 470 if (dev->irq[0]) > >> 471 ret = device_create_file(&dev->dev, &dev_attr_irq0); > >> 472 if (ret == 0 && dev->irq[1]) > >> 473 ret = device_create_file(&dev->dev, &dev_attr_irq1); > >> 474 if (ret == 0) > >> 475 return ret; > >> > >> of_amba_device_decode_irq() in amba_device_try_add() won't lead to issue, > >> only delay the device add, right? > > But delaying the device add is the issue. For example, adding a device > > could trigger the loading of the corresponding module using uevents. > > But now this change would delay that step. That can have other > > unintended consequences -- slowing down boot, what if the driver was > > working fine without the IRQ, etc. > > > >> If make it into amba_probe(), the above code should be moved too, could we > >> make a new patch to move both of them, or don't move them? > > I'd say move them both. If Russell hasn't already picked this up, then > > I'd say redo your Patch 3/3. > I will resend with put it into amba_probe. > > > > Btw, I've been working on [1] cleaning up the one-off deferred probe > > solution that we have for amba devices. That causes a bunch of other > > headaches. Your patch 3/3 takes us further in the wrong direction by > > adding more reasons for delaying the addition of the device. > > Got it, and I could resend all combine your patch(due to context conflict > > when changing same function) if you no object. If you want to resolve the conflict with my patch and resend it while keeping me as the author, I would definitely appreciate it. -Saravana > > > > > > -Saravana > > > > [1] - https://lore.kernel.org/lkml/CAGETcx8b228nDUho3cX9AAQ-pXOfZTMv8cj2vhdx9yc_pk8q+A@mail.gmail.com/ > > . > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A54C0C432BE for ; Thu, 26 Aug 2021 04:48:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BDD161040 for ; Thu, 26 Aug 2021 04:48:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BDD161040 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4YqF57TIjlxxtWC/Ggof0PaoEAo7NFtplEqqqvuRBow=; b=P61fX94H8TMBnm bjImk39EbeGlHxroar89eJQBH3A2BMHHRuGG5grH/NQ56X9YkboceowgOPYdvT+rWEmgwY6A+MXyL +XDNVD3gQsBpLA77xf5+BsGmi9SIag2z0aS7xBXmR5i/6fosb/HCrqUaLd0ghsLZlx3/in4rPGVbn wGwF+n7GNu8UksAtULSQcKC7STONS2rk2EfdbvQw1zVqwF5uvemFUpczIg3d1UErPhnYt5eomN/N0 drAP7V4ksxnD+C8jdnMyyOXzqnpFGw7SxidasQke8Ocuy4lYl72+3lJWEcmjz3P3Vtu3hdv3mTjWk Hyl1SgiQkHOQlQHri7Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJ7HV-0098uN-2o; Thu, 26 Aug 2021 04:46:25 +0000 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJ7HQ-0098ty-Vo for linux-arm-kernel@lists.infradead.org; Thu, 26 Aug 2021 04:46:22 +0000 Received: by mail-yb1-xb2a.google.com with SMTP id r4so3409725ybp.4 for ; Wed, 25 Aug 2021 21:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LgdL5as35+i2mHlUCdQc4m6L0YmfdSZa77eRS39qBnA=; b=WrQhDyryIaGyHF+wUrhDTQGAekquZHmBoUQGHFuwMpk4D62D+QwNVo0yeK1CmQfw+T TFVY6mEdnd09CI1xNYFtKe4Nc2qOhywN1cf0C+UvT66lew1NtVERVR4j/xDAtkOTiRWW 0wVARsJZjBwPQQIyl/VvMS2LqAkzn/9JUhO+PmFpXNTSx5g/cnGNC7oIrT53cWnbim+b Wav1jCUrhaaRtKAkt9FdbR7HY/YIu3uhR45Mrd/6b1yeBiJeNiKCHEgymyn29zuZXg/x JtxrY2v02fJAxkJVVpnbd1I9wovoDx5cPYEnydpIth9SgPH4f2rFutVD4IoA2Hf0LAsl 7PVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LgdL5as35+i2mHlUCdQc4m6L0YmfdSZa77eRS39qBnA=; b=Y9iZUj0e3cYzbdi2FlZlueHWXXgiJ0/211XFmvdStlvZ1EP9JamlxeEYrM2Xd483OG a+lANNqHMM36O+sW6oaypfrEESv3GNM/j1nFIUu3Bppxc/gP2scS0sHpydQkCmHs5vVF U/yYU9xmKlEOZjt+hIO8GPhyPl8HRJMXhe+FVjdtwrGycmVGdX7cSk3XTqLob3rYIuuK ya/GvGr8XfofX4O9cxxctrlPuJqx922lMQ1QaZOw/SqrL4blFImNPi0NWvwwpNsVoVNv CuR0/WOKGgeeOjob2o9/41ynF+hNhCyT0raGMjgawK8HMaJyaE20QAzceQSglzCaz2YY TAYg== X-Gm-Message-State: AOAM533z0SYCGDgzBfA4lmF349Z251JH1vcQG1XTlnk6mQi5L/U6svh5 qme8618TjU+cYxeTHNySV8mv/M+Szy58C99kBdHrLQ== X-Google-Smtp-Source: ABdhPJzsaBSC4K7dz+AKCr2HuRqOibJQ2FbCOIa7HlSYjw1OSkdTpyGN+6glSGWQLia7J3JzHEja4XJNj+dLfR1S84s= X-Received: by 2002:a25:804:: with SMTP id 4mr2697573ybi.346.1629953176343; Wed, 25 Aug 2021 21:46:16 -0700 (PDT) MIME-Version: 1.0 References: <20210816074619.177383-1-wangkefeng.wang@huawei.com> <20210816074619.177383-4-wangkefeng.wang@huawei.com> In-Reply-To: From: Saravana Kannan Date: Wed, 25 Aug 2021 21:45:40 -0700 Message-ID: Subject: Re: [PATCH 3/3] amba: Properly handle device probe without IRQ domain To: Kefeng Wang Cc: Rob Herring , "linux-kernel@vger.kernel.org" , Frank Rowand , devicetree@vger.kernel.org, Russell King , Linus Walleij , linux-arm-kernel , Ruizhe Lin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_214621_095407_85AE1688 X-CRM114-Status: GOOD ( 47.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 25, 2021 at 7:45 PM Kefeng Wang wrote: > > > On 2021/8/25 16:04, Saravana Kannan wrote: > > On Tue, Aug 24, 2021 at 9:05 PM Kefeng Wang wrote: > >> > >> On 2021/8/25 4:08, Saravana Kannan wrote: > >>> On Tue, Aug 24, 2021 at 1:05 PM Rob Herring wrote: > >>>> +Saravana > >>>> > >>>> Saravana mentioned to me there may be some issues with this one... > >>>> > >>>> > >>>> On Mon, Aug 16, 2021 at 2:43 AM Kefeng Wang wrote: > >>>>> of_amba_device_create() uses irq_of_parse_and_map() to translate > >>>>> a DT interrupt specification into a Linux virtual interrupt number. > >>>>> > >>>>> But it doesn't properly handle the case where the interrupt controller > >>>>> is not yet available, eg, when pl011 interrupt is connected to MBIGEN > >>>>> interrupt controller, because the mbigen initialization is too late, > >>>>> which will lead to no IRQ due to no IRQ domain found, log is shown below, > >>>>> "irq: no irq domain found for uart0 !" > >>>>> > >>>>> use of_irq_get() to return -EPROBE_DEFER as above, and in the function > >>>>> amba_device_try_add()/amba_device_add(), it will properly handle in such > >>>>> case, also return 0 in other fail cases to be consistent as before. > >>>>> > >>>>> Cc: Russell King > >>>>> Cc: Rob Herring > >>>>> Cc: Frank Rowand > >>>>> Reported-by: Ruizhe Lin > >>>>> Signed-off-by: Kefeng Wang > >>>>> --- > >>>>> drivers/amba/bus.c | 27 +++++++++++++++++++++++++++ > >>>>> drivers/of/platform.c | 6 +----- > >>>>> 2 files changed, 28 insertions(+), 5 deletions(-) > >>>>> > >>>>> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c > >>>>> index 36f2f42c8014..720aa6cdd402 100644 > >>>>> --- a/drivers/amba/bus.c > >>>>> +++ b/drivers/amba/bus.c > >>>>> @@ -19,6 +19,7 @@ > >>>>> #include > >>>>> #include > >>>>> #include > >>>>> +#include > >>>>> > >>>>> #include > >>>>> > >>>>> @@ -371,12 +372,38 @@ static void amba_device_release(struct device *dev) > >>>>> kfree(d); > >>>>> } > >>>>> > >>>>> +static int of_amba_device_decode_irq(struct amba_device *dev) > >>>>> +{ > >>>>> + struct device_node *node = dev->dev.of_node; > >>>>> + int i, irq = 0; > >>>>> + > >>>>> + if (IS_ENABLED(CONFIG_OF_IRQ) && node) { > >>>>> + /* Decode the IRQs and address ranges */ > >>>>> + for (i = 0; i < AMBA_NR_IRQS; i++) { > >>>>> + irq = of_irq_get(node, i); > >>>>> + if (irq < 0) { > >>>>> + if (irq == -EPROBE_DEFER) > >>>>> + return irq; > >>>>> + irq = 0; > >>>>> + } > >>>>> + > >>>>> + dev->irq[i] = irq; > >>>>> + } > >>>>> + } > >>>>> + > >>>>> + return 0; > >>>>> +} > >>>>> + > >>>>> static int amba_device_try_add(struct amba_device *dev, struct resource *parent) > >>>>> { > >>>>> u32 size; > >>>>> void __iomem *tmp; > >>>>> int i, ret; > >>>>> > >>>>> + ret = of_amba_device_decode_irq(dev); > >>>>> + if (ret) > >>>>> + goto err_out; > >>>>> + > >>> Similar to other resources the AMBA bus "gets" for the device, I think > >>> this should be moved into amba_probe() and not here. There's no reason > >>> to delay the addition of the device (and loading its module) because > >>> the IRQ isn't ready yet. > >> The following code in the amba_device_try_add() will be called, it uses irq[0] > >> and irq[1], so I put of_amba_device_decode_irq() into amba_device_try_add(). > >> > >> 470 if (dev->irq[0]) > >> 471 ret = device_create_file(&dev->dev, &dev_attr_irq0); > >> 472 if (ret == 0 && dev->irq[1]) > >> 473 ret = device_create_file(&dev->dev, &dev_attr_irq1); > >> 474 if (ret == 0) > >> 475 return ret; > >> > >> of_amba_device_decode_irq() in amba_device_try_add() won't lead to issue, > >> only delay the device add, right? > > But delaying the device add is the issue. For example, adding a device > > could trigger the loading of the corresponding module using uevents. > > But now this change would delay that step. That can have other > > unintended consequences -- slowing down boot, what if the driver was > > working fine without the IRQ, etc. > > > >> If make it into amba_probe(), the above code should be moved too, could we > >> make a new patch to move both of them, or don't move them? > > I'd say move them both. If Russell hasn't already picked this up, then > > I'd say redo your Patch 3/3. > I will resend with put it into amba_probe. > > > > Btw, I've been working on [1] cleaning up the one-off deferred probe > > solution that we have for amba devices. That causes a bunch of other > > headaches. Your patch 3/3 takes us further in the wrong direction by > > adding more reasons for delaying the addition of the device. > > Got it, and I could resend all combine your patch(due to context conflict > > when changing same function) if you no object. If you want to resolve the conflict with my patch and resend it while keeping me as the author, I would definitely appreciate it. -Saravana > > > > > > -Saravana > > > > [1] - https://lore.kernel.org/lkml/CAGETcx8b228nDUho3cX9AAQ-pXOfZTMv8cj2vhdx9yc_pk8q+A@mail.gmail.com/ > > . > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel