From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9191EC19F2C for ; Tue, 16 Aug 2022 06:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbiHPGFH (ORCPT ); Tue, 16 Aug 2022 02:05:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbiHPGE0 (ORCPT ); Tue, 16 Aug 2022 02:04:26 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34DC479EDB for ; Mon, 15 Aug 2022 16:37:00 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-33387bf0c4aso5655277b3.11 for ; Mon, 15 Aug 2022 16:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=fVxetOgUQ7E/da9h0YyyPZnmDSU85aoRWSOGJovfDo4=; b=KTUwHeoXz1fmYUOVhvzKJVtvXyuG8JHUHX6QB6FOxUcDm+t/hWHwoYNXr85HrUdaEK tILQMJn5QrnwvIaiiGvh/gmofiK9boSEgGXMH8Td1nph3IGh7K9bPlvKvjyubLDSc0aS fgP5ZpT/qNqLdbxAcPOnXoC06oDNK7j8waNQN+CBuASLQjDxP44f8T2h1FoyDYuG2qG0 BpVB8cB/sRH0nhHBKOSHQriJwZq8WNgL2+bZYuBEh1Bbls5R4A/XDMEyrwthkWrfMF+H T+itPy2imckkoWZbnfArIsJ7JKc+W9DP9rqWida20tZuDHZyrdibJlDrRnzcRORJzbga q56w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=fVxetOgUQ7E/da9h0YyyPZnmDSU85aoRWSOGJovfDo4=; b=boiPk7zxaV3Rar3lMfrFWTWn9kp1nyXRnk2Xgq4UDUK44PA2BBwGqN4C3CUjrhoQLW qYXGfgfjnOx47hCO5ShwUMQ4X6WTMl2YO80nzuifKhz4IaWKmPZTCEV2/W6dWpdKZgcd FhWugqtIF1Le+9oiI3FRUK0V250h+DZxygsnIh+v+Tp43uzikfz6JgM5MMsPXRSISqzp +p7iNeVM5DH27pfFLoYB0d/vhHRmzChATsgB+gPt7AGMoO6iZxNaesVc8fvUMbUZyBlV cnXgx4JYpEB6ooREJOEmGOh/09XU0iPs69rWv6OYdV5kSTakKfel4IeRyvZL0rurwYCq MdtQ== X-Gm-Message-State: ACgBeo0ifvQ2jPFng3ZRU/KetbB+zPFeQp40vlZLhl4SsQm/u7NdaXeT UDssINMKoVYeYBj8BoogLFQczX+eYX/3UKWd9PZp9w== X-Google-Smtp-Source: AA6agR5Np2WgcNsV8TjcwUEqg6oN6k4lKO8Wo6VF8E9ds7ny2Mlu9nLypvijdRBumVPbsaC27C1JZ/SudORTFk2byw8= X-Received: by 2002:a81:d8a:0:b0:333:38da:2a44 with SMTP id 132-20020a810d8a000000b0033338da2a44mr1203503ywn.518.1660606619221; Mon, 15 Aug 2022 16:36:59 -0700 (PDT) MIME-Version: 1.0 References: <20220727185012.3255200-1-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Mon, 15 Aug 2022 16:36:23 -0700 Message-ID: Subject: Re: [PATCH v1 0/3] Bring back driver_deferred_probe_check_state() for now To: Luca Weiss Cc: Tony Lindgren , Greg Kroah-Hartman , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , naresh.kamboju@linaro.org, kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 15, 2022 at 9:57 AM Luca Weiss wrote: > > On Mon Aug 15, 2022 at 1:01 PM CEST, Tony Lindgren wrote: > > * Saravana Kannan [700101 02:00]: > > > More fixes/changes are needed before driver_deferred_probe_check_state() > > > can be deleted. So, bring it back for now. > > > > > > Greg, > > > > > > Can we get this into 5.19? If not, it might not be worth picking up this > > > series. I could just do the other/more fixes in time for 5.20. > > > > Yes please pick this as fixes for v6.0-rc series, it fixes booting for > > me. I've replied with fixes tags for the two patches that were causing > > regressions for me. > > > > Hi, > > for me Patch 1+3 fix display probe on Qualcomm SM6350 (although display > for this SoC isn't upstream yet, there are lots of other SoCs with very > similar setup). > > Probe for DPU silently fails, with CONFIG_DEBUG_DRIVER=y we get this: > > msm-mdss ae00000.mdss: __genpd_dev_pm_attach() failed to find PM domain: -2 > > While I'm not familiar with the specifics of fw_devlink, the dtsi has > power-domains = <&dispcc MDSS_GDSC> for this node but it doesn't pick > that up for some reason. > > We can also see that a bit later dispcc finally probes. Luca, Can you test with this series instead and see if it fixes this issue? https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/ You might also need to add this delta on top of the series if the series itself isn't sufficient. diff --git a/drivers/base/core.c b/drivers/base/core.c index 2f012e826986..866755d8ad95 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2068,7 +2068,11 @@ static int fw_devlink_create_devlink(struct device *con, device_links_write_unlock(); } - sup_dev = get_dev_from_fwnode(sup_handle); + if (sup_handle->flags & FWNODE_FLAG_NOT_DEVICE) + sup_dev = fwnode_get_next_parent_dev(sup_handle); + else + sup_dev = get_dev_from_fwnode(sup_handle); + if (sup_dev) { /* * If it's one of those drivers that don't actually bind to -Saravana