From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CC78C433EF for ; Tue, 28 Jun 2022 16:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RvVZRHGDJqqc43PnMxHtQTRTjRdTIEkTf6hnZZMwzUQ=; b=H7hwCmm3wpY7/n 6iVyGySBTfQWq80gSuYOFE7/F9wybR26odWBoxVqRJ+KvymD8b5JanVuvDVh6DqQnAYzFHIKrDqVr aGNk0jd4o8j15VTF7/OK5zcsqwB4gkmdcV/XCXqJPS+5dtbMvtnALd5E5gTJwQ4m6pKw1QSTrGhuU /BuTXOWFwB0/Elny7RGJo0toPq7WbD57Pdptjj6nO6/D41GLZOOdz77VGOJXhVN69Bo5SsSCkfItA T5EKkn0olKHAx9oedz9jsPO/AP2cwrmKLIBrTL88hlyFyfQtysJC/z7ZvTcko7GvXrj2yV/N4NYqO Df6TwVj6Ya7umPByhR0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Dtl-0079iX-OO; Tue, 28 Jun 2022 16:17:09 +0000 Received: from mail-yb1-xb2b.google.com ([2607:f8b0:4864:20::b2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Dti-0079fS-Ny for linux-snps-arc@lists.infradead.org; Tue, 28 Jun 2022 16:17:08 +0000 Received: by mail-yb1-xb2b.google.com with SMTP id g4so11506987ybg.9 for ; Tue, 28 Jun 2022 09:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=svPPiUXmjLu4A2+b3rJgoCqrzxWVmAH7KXTvVP4AwaLTDrIN9AN3BtNG2XiV2ycJ8x 6Y9oMX5BQlCl6K+KL9J1KxqNRcb1MdTb/c18nJgwvmc5rVyOe8EKUyj+KrCbNC70iJoL OlJOsi9x5Scvw9W8cP8d/OYBAk6luTiA/PE8w/jzj7tOJ+ICpHFzyCnfh2xqrRn3YVLo nvgpT4pJzONw4hikJOgq/y8DRHjrG2lOfrc2hEWRc02ovhuxlfgkK9/gOnTwVGME5DOU 4AXMX65QfUYiz76GEkrT/465op3M51kj45IkhJmeQobRe1+J32FVHZumFFaJBd9Gan88 /wYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=HtOhGZ1bRZO1qNPqpD0nR8sMudzOwO+QcPbOARJUmmrL+Is1+zvk5XP89HxrjTTaY7 kJva2J8WPwAEu6nwipooicNXdKjvtRW1X2fG9PW1cTGs/3M0hB2uXgKib14YvCRBsF7h IaK3GjLnZE3C7dOjJcqDVLAfku5QbdkhD3UShtkK6Ul7G+l8Sva8mRIlej4H7OvsL9rl qAnYRMqtapllMuRP6uF0M0+cf8NOzPlgMZezpG3CXrJdy5qkSB+R+xEwLqOIg/wiQn4h gyJi0Cv0mdwmXrzYiIqsvnLK9gU//bbHZXkeBnbENdIr7f/+FKZ9p8KVakGHHft7Sg0h 72kQ== X-Gm-Message-State: AJIora8EXjmMIzBeDzWN/ZXCmgMsXS2w5GFquXpkt1yXHOFTawKCpIKe /sFZXHqk75lG3yXDzDzXOfV+PkEc9y0+yoIftiWo/g== X-Google-Smtp-Source: AGRyM1vHa4WRnJlk4sln0xuJGdVhcpu8QS15R2N9PrbVvkglI7Nzwr0PBFdp1lTun6HJ/nUSS1O/TmeoEjFZPidRK0U= X-Received: by 2002:a25:5bc3:0:b0:669:b722:beb8 with SMTP id p186-20020a255bc3000000b00669b722beb8mr20258885ybb.447.1656433020483; Tue, 28 Jun 2022 09:17:00 -0700 (PDT) MIME-Version: 1.0 References: <20220628020110.1601693-1-saravanak@google.com> <20220628020110.1601693-3-saravanak@google.com> <20220628140025.qpom64ptru4ub6fu@distanz.ch> In-Reply-To: <20220628140025.qpom64ptru4ub6fu@distanz.ch> From: Saravana Kannan Date: Tue, 28 Jun 2022 09:16:24 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] serial: Set probe_no_timeout for all DT based drivers To: Tobias Klauser Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Laurentiu Tudor , Jiri Slaby , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Nicolas Saenz Julienne , Al Cooper , Andy Shevchenko , Paul Cercueil , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Russell King , Vineet Gupta , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Alexander Shiyan , Baruch Siach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Taichi Sugaya , Takao Orito , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Andy Gross , Bjorn Andersson , Pali Rohar , Andreas Farber , Manivannan Sadhasivam , Krzysztof Kozlowski , Alim Akhtar , Laxman Dewangan , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , "David S. Miller" , Hammer Hsieh , Peter Korsgaard , Timur Tabi , Michal Simek , Rob Herring , sascha hauer , peng fan , kevin hilman , ulf hansson , len brown , pavel machek , joerg roedel , will deacon , andrew lunn , heiner kallweit , eric dumazet , jakub kicinski , paolo abeni , linus walleij , hideaki yoshifuji , david ahern , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-actions@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, sparclinux@vger.kernel.org, Ahmad Fatoum X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_091706_891544_0907DBB7 X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Tue, Jun 28, 2022 at 7:00 AM Tobias Klauser wrote: > > On 2022-06-28 at 04:01:03 +0200, Saravana Kannan wrote: > > diff --git a/drivers/tty/serial/8250/8250_acorn.c b/drivers/tty/serial/8250/8250_acorn.c > > index 758c4aa203ab..5a6f2f67de4f 100644 > > --- a/drivers/tty/serial/8250/8250_acorn.c > > +++ b/drivers/tty/serial/8250/8250_acorn.c > > @@ -114,7 +114,6 @@ static const struct ecard_id serial_cids[] = { > > static struct ecard_driver serial_card_driver = { > > .probe = serial_card_probe, > > .remove = serial_card_remove, > > - .id_table = serial_cids, > > Is this change intentional? All other drivers are only changed to set > .probe_no_time and I don't see anything mentioned in the commit message > re. this driver's change. No, that's a mistake. Thanks for catching it! I'll check this patch again. -Saravana _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4300CC433EF for ; Tue, 28 Jun 2022 16:17:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B809B4060C; Tue, 28 Jun 2022 16:17:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B809B4060C Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=svPPiUXm X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6aeaWeo76EUT; Tue, 28 Jun 2022 16:17:06 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id A1635402F2; Tue, 28 Jun 2022 16:17:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A1635402F2 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6C3B1C0039; Tue, 28 Jun 2022 16:17:05 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id C347DC002D for ; Tue, 28 Jun 2022 16:17:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8E286408E6 for ; Tue, 28 Jun 2022 16:17:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8E286408E6 Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=svPPiUXm X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a5hKndTtpLqY for ; Tue, 28 Jun 2022 16:17:02 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org F4054408E3 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by smtp4.osuosl.org (Postfix) with ESMTPS id F4054408E3 for ; Tue, 28 Jun 2022 16:17:01 +0000 (UTC) Received: by mail-yb1-xb29.google.com with SMTP id v185so13532155ybe.8 for ; Tue, 28 Jun 2022 09:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=svPPiUXmjLu4A2+b3rJgoCqrzxWVmAH7KXTvVP4AwaLTDrIN9AN3BtNG2XiV2ycJ8x 6Y9oMX5BQlCl6K+KL9J1KxqNRcb1MdTb/c18nJgwvmc5rVyOe8EKUyj+KrCbNC70iJoL OlJOsi9x5Scvw9W8cP8d/OYBAk6luTiA/PE8w/jzj7tOJ+ICpHFzyCnfh2xqrRn3YVLo nvgpT4pJzONw4hikJOgq/y8DRHjrG2lOfrc2hEWRc02ovhuxlfgkK9/gOnTwVGME5DOU 4AXMX65QfUYiz76GEkrT/465op3M51kj45IkhJmeQobRe1+J32FVHZumFFaJBd9Gan88 /wYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=4L5W2yHquBwliLckng9+YGCA65iyRO71SMwlzQtNRFXOrmwXerBR8yN6dpqGQBqgnN f/3UHVwEmgHbgN7jSCEcF6BQY/x1de8pMFooIhgHTPMdUD34L/Vna/jcvnCTzuk1MDVE yAbpBOQ9FCWnFySlaLE/jTUXuqCPAO/+pQKWZXEUFIvlXiwAvYs+WDiMfpuunpJDzt+l F+fU6AZx5MMnr9wkMrFIGewmtaDGXW5KpsSz+hq4AXjv1rz4pEK8DAe954qHahWeSwO4 IN6JYv8mJMvUkFlfVnX79nXOgr/p7g6csSHwucuhoLIZ6v94PgnR3I6zxqK6eALW+8lM ZVuQ== X-Gm-Message-State: AJIora8sA1y4IcIVR7t41incuXdC9zQgfofgdgK4XGO2gFUogFSEOQGU fOk/rAtGQtYAF4omzJ8toGDYaOtIDbDJgPdgIg1/6Q== X-Google-Smtp-Source: AGRyM1vHa4WRnJlk4sln0xuJGdVhcpu8QS15R2N9PrbVvkglI7Nzwr0PBFdp1lTun6HJ/nUSS1O/TmeoEjFZPidRK0U= X-Received: by 2002:a25:5bc3:0:b0:669:b722:beb8 with SMTP id p186-20020a255bc3000000b00669b722beb8mr20258885ybb.447.1656433020483; Tue, 28 Jun 2022 09:17:00 -0700 (PDT) MIME-Version: 1.0 References: <20220628020110.1601693-1-saravanak@google.com> <20220628020110.1601693-3-saravanak@google.com> <20220628140025.qpom64ptru4ub6fu@distanz.ch> In-Reply-To: <20220628140025.qpom64ptru4ub6fu@distanz.ch> Date: Tue, 28 Jun 2022 09:16:24 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] serial: Set probe_no_timeout for all DT based drivers To: Tobias Klauser Cc: andrew lunn , peng fan , "Rafael J. Wysocki" , Benjamin Herrenschmidt , linus walleij , Paul Mackerras , Alim Akhtar , Peter Korsgaard , linux-stm32@st-md-mailman.stormreply.com, Karol Gugala , Jerome Brunet , linux-samsung-soc@vger.kernel.org, Michael Ellerman , Michal Simek , Hammer Hsieh , NXP Linux Team , Vineet Gupta , len brown , Nicolas Saenz Julienne , linux-pm@vger.kernel.org, Sascha Hauer , linux-unisoc@lists.infradead.org, Scott Branden , Andrew Jeffery , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Richard Genoud , Masami Hiramatsu , Pengutronix Kernel Team , Claudiu Beznea , Alexandre Belloni , pavel machek , Kunihiko Hayashi , eric dumazet , Thierry Reding , sascha hauer , Chunyan Zhang , Jonathan Hunter , Gabriel Somlo , linux-mips@vger.kernel.org, kernel-team@android.com, Martin Blumenstingl , linux-arm-msm@vger.kernel.org, linux-actions@lists.infradead.org, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Andreas Farber , Maxime Coquelin , Kevin Hilman , Pali Rohar , heiner kallweit , ulf hansson , Neil Armstrong , Lorenzo Pieralisi , Al Cooper , linux-tegra@vger.kernel.org, Jiri Slaby , linux-aspeed@lists.ozlabs.org, Rob Herring , Florian Fainelli , Mateusz Holenko , Alexander Shiyan , kevin hilman , Broadcom internal kernel review list , Joel Stanley , Orson Zhai , paolo abeni , Patrice Chotard , Ray Jui , Vladimir Zapolskiy , linux-snps-arc@lists.infradead.org, Timur Tabi , hideaki yoshifuji , iommu@lists.linux-foundation.org, Laxman Dewangan , Sudeep Holla , Baolin Wang , Shawn Guo , "David S. Miller" , Baruch Siach , Liviu Dudau , Alexandre Torgue , Paul Cercueil , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Ahmad Fatoum , Russell King , Andy Gross , linux-serial@vger.kernel.org, jakub kicinski , will deacon , Manivannan Sadhasivam , linux-mediatek@lists.infradead.org, Fabio Estevam , Paul Walmsley , Matthias Brugger , Andy Shevchenko , Taichi Sugaya , netdev@vger.kernel.org, david ahern , Nicolas Ferre , Krzysztof Kozlowski , Palmer Dabbelt , Takao Orito , linuxppc-dev@lists.ozlabs.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Saravana Kannan via iommu Reply-To: Saravana Kannan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Jun 28, 2022 at 7:00 AM Tobias Klauser wrote: > > On 2022-06-28 at 04:01:03 +0200, Saravana Kannan wrote: > > diff --git a/drivers/tty/serial/8250/8250_acorn.c b/drivers/tty/serial/8250/8250_acorn.c > > index 758c4aa203ab..5a6f2f67de4f 100644 > > --- a/drivers/tty/serial/8250/8250_acorn.c > > +++ b/drivers/tty/serial/8250/8250_acorn.c > > @@ -114,7 +114,6 @@ static const struct ecard_id serial_cids[] = { > > static struct ecard_driver serial_card_driver = { > > .probe = serial_card_probe, > > .remove = serial_card_remove, > > - .id_table = serial_cids, > > Is this change intentional? All other drivers are only changed to set > .probe_no_time and I don't see anything mentioned in the commit message > re. this driver's change. No, that's a mistake. Thanks for catching it! I'll check this patch again. -Saravana _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E02C43334 for ; Tue, 28 Jun 2022 16:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236667AbiF1QZU (ORCPT ); Tue, 28 Jun 2022 12:25:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232360AbiF1QYq (ORCPT ); Tue, 28 Jun 2022 12:24:46 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A643A39147 for ; Tue, 28 Jun 2022 09:17:01 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id p7so21632700ybm.7 for ; Tue, 28 Jun 2022 09:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=svPPiUXmjLu4A2+b3rJgoCqrzxWVmAH7KXTvVP4AwaLTDrIN9AN3BtNG2XiV2ycJ8x 6Y9oMX5BQlCl6K+KL9J1KxqNRcb1MdTb/c18nJgwvmc5rVyOe8EKUyj+KrCbNC70iJoL OlJOsi9x5Scvw9W8cP8d/OYBAk6luTiA/PE8w/jzj7tOJ+ICpHFzyCnfh2xqrRn3YVLo nvgpT4pJzONw4hikJOgq/y8DRHjrG2lOfrc2hEWRc02ovhuxlfgkK9/gOnTwVGME5DOU 4AXMX65QfUYiz76GEkrT/465op3M51kj45IkhJmeQobRe1+J32FVHZumFFaJBd9Gan88 /wYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=NKxHsDml3cExXyA3RDfsoVXJNw3lwoqYkzPjtGoE1zIoI14kC9i3Drt0OLg4U801tR gOTr/PV1lf5PK8bWxdUtmXil2jpeXu2c36lxmYRnE1YRjxfRw6IcAfncLYEKlBv4omiP fvCWYoDpFWCm+2MX6FrzyNYgwydYIXYtCDAdD6deq4FANxyA17b7fRzab/pgsh9itNOl rYxJpheEqviGt1eNpRVjlHQmDchqbNCF9yQj1KCbmK/U1OlKqsoMBMfHzCz51TL5wfIT +ry/uY6yBXs9Uta12cPRZf3uZ+EP3BfML77k54AFnxkZ/pfx3n2miMinT5BwuuVmaeKn rOAg== X-Gm-Message-State: AJIora+U3d2rE4IDYTrsnEmyC1IM92nGqzHx97j2KhtcUJ8xRY50PXUI BSOrw7g/q3KAmW1Uv9FVheJmMqvSdY0IMNC4Uqn0lw== X-Google-Smtp-Source: AGRyM1vHa4WRnJlk4sln0xuJGdVhcpu8QS15R2N9PrbVvkglI7Nzwr0PBFdp1lTun6HJ/nUSS1O/TmeoEjFZPidRK0U= X-Received: by 2002:a25:5bc3:0:b0:669:b722:beb8 with SMTP id p186-20020a255bc3000000b00669b722beb8mr20258885ybb.447.1656433020483; Tue, 28 Jun 2022 09:17:00 -0700 (PDT) MIME-Version: 1.0 References: <20220628020110.1601693-1-saravanak@google.com> <20220628020110.1601693-3-saravanak@google.com> <20220628140025.qpom64ptru4ub6fu@distanz.ch> In-Reply-To: <20220628140025.qpom64ptru4ub6fu@distanz.ch> From: Saravana Kannan Date: Tue, 28 Jun 2022 09:16:24 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] serial: Set probe_no_timeout for all DT based drivers To: Tobias Klauser Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Laurentiu Tudor , Jiri Slaby , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Nicolas Saenz Julienne , Al Cooper , Andy Shevchenko , Paul Cercueil , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Russell King , Vineet Gupta , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Alexander Shiyan , Baruch Siach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Taichi Sugaya , Takao Orito , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Andy Gross , Bjorn Andersson , Pali Rohar , Andreas Farber , Manivannan Sadhasivam , Krzysztof Kozlowski , Alim Akhtar , Laxman Dewangan , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , "David S. Miller" , Hammer Hsieh , Peter Korsgaard , Timur Tabi , Michal Simek , Rob Herring , sascha hauer , peng fan , kevin hilman , ulf hansson , len brown , pavel machek , joerg roedel , will deacon , andrew lunn , heiner kallweit , eric dumazet , jakub kicinski , paolo abeni , linus walleij , hideaki yoshifuji , david ahern , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-actions@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, sparclinux@vger.kernel.org, Ahmad Fatoum Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, Jun 28, 2022 at 7:00 AM Tobias Klauser wrote: > > On 2022-06-28 at 04:01:03 +0200, Saravana Kannan wrote: > > diff --git a/drivers/tty/serial/8250/8250_acorn.c b/drivers/tty/serial/8250/8250_acorn.c > > index 758c4aa203ab..5a6f2f67de4f 100644 > > --- a/drivers/tty/serial/8250/8250_acorn.c > > +++ b/drivers/tty/serial/8250/8250_acorn.c > > @@ -114,7 +114,6 @@ static const struct ecard_id serial_cids[] = { > > static struct ecard_driver serial_card_driver = { > > .probe = serial_card_probe, > > .remove = serial_card_remove, > > - .id_table = serial_cids, > > Is this change intentional? All other drivers are only changed to set > .probe_no_time and I don't see anything mentioned in the commit message > re. this driver's change. No, that's a mistake. Thanks for catching it! I'll check this patch again. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58AC9C43334 for ; Tue, 28 Jun 2022 18:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n39mohxaICoS3NBDxDPojQ+nX+vKLhfRNy5VDIrjdwU=; b=vRDtoYmbqMc0xr 8GUuE/oWgwoi8WkqMAp/LJEWBqN57T58WBP4yOt7nEDoFn2DclrDLeOkyU+VCMzo6+MMRjmqRnhRx 2EjHLRVdipPqaFImAztvUUSDjsww057iW8Yj810UQDciHNCFn/1WKQCHTzuPl2hyvqD95Rtos7zPx e5MhaL7n9puEmshbbXgTxbih/aDUC3xlxb0tCEoSBlqDIEuUUCYd5ONT4PdTK+x+/bHjmlPEjwZ1F aSqiaUxXHdyukxW/ua6Fa7CABjuGUIO4j5+FqTsX9GBNV1aILBrrSqO0W2mFOuYEeYPpAizuWckfv 1zF9CyhO66F5cck+Gx8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Fd2-007Yhc-Ao; Tue, 28 Jun 2022 18:08:00 +0000 Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Dth-0079fT-3I for linux-riscv@lists.infradead.org; Tue, 28 Jun 2022 16:17:07 +0000 Received: by mail-yb1-xb2e.google.com with SMTP id o19so16512066ybg.2 for ; Tue, 28 Jun 2022 09:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=svPPiUXmjLu4A2+b3rJgoCqrzxWVmAH7KXTvVP4AwaLTDrIN9AN3BtNG2XiV2ycJ8x 6Y9oMX5BQlCl6K+KL9J1KxqNRcb1MdTb/c18nJgwvmc5rVyOe8EKUyj+KrCbNC70iJoL OlJOsi9x5Scvw9W8cP8d/OYBAk6luTiA/PE8w/jzj7tOJ+ICpHFzyCnfh2xqrRn3YVLo nvgpT4pJzONw4hikJOgq/y8DRHjrG2lOfrc2hEWRc02ovhuxlfgkK9/gOnTwVGME5DOU 4AXMX65QfUYiz76GEkrT/465op3M51kj45IkhJmeQobRe1+J32FVHZumFFaJBd9Gan88 /wYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=AZdkvmSJDX00of6lMIM698rMavH5OutrU9kNp4B+NBtYdfjcS50LPj43D5tcNiMfEJ bobvkQByYEK9RPYB6GXB6xHKeypKXLZ2FEXtdBjlNXJp1J4UcWr9b9GStHp0UJhTc4Nk G9XUlL4Wj+0WiriFUZ1zZeW5rs+R24Z5MnlzW4xSig9HOQWMV6jQq10g3QLjRqHoW9ju vPilizZ8sY8jhsmIgzLsXLZ77CHntCOZ4XUqGU9+Nxe27+o8ZcJE9rJhHoNOX2TyUw4r WI7YhCUfBeEbkPz7bZ5vLpKL4TldVfLLIVhAfXfM5hcY7kU7eUidP/Ow/pfjLH5yEb+w hw3Q== X-Gm-Message-State: AJIora+wrllrKYJRIxvh/JBCjEHMqMJSGSaQelpEaFM5doZHRqCwDgws ENUBIr2BrnHuVy+Jg9/luCFGwmGXszYWZIOVmgv/CA== X-Google-Smtp-Source: AGRyM1vHa4WRnJlk4sln0xuJGdVhcpu8QS15R2N9PrbVvkglI7Nzwr0PBFdp1lTun6HJ/nUSS1O/TmeoEjFZPidRK0U= X-Received: by 2002:a25:5bc3:0:b0:669:b722:beb8 with SMTP id p186-20020a255bc3000000b00669b722beb8mr20258885ybb.447.1656433020483; Tue, 28 Jun 2022 09:17:00 -0700 (PDT) MIME-Version: 1.0 References: <20220628020110.1601693-1-saravanak@google.com> <20220628020110.1601693-3-saravanak@google.com> <20220628140025.qpom64ptru4ub6fu@distanz.ch> In-Reply-To: <20220628140025.qpom64ptru4ub6fu@distanz.ch> From: Saravana Kannan Date: Tue, 28 Jun 2022 09:16:24 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] serial: Set probe_no_timeout for all DT based drivers To: Tobias Klauser Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Laurentiu Tudor , Jiri Slaby , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Nicolas Saenz Julienne , Al Cooper , Andy Shevchenko , Paul Cercueil , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Russell King , Vineet Gupta , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Alexander Shiyan , Baruch Siach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Taichi Sugaya , Takao Orito , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Andy Gross , Bjorn Andersson , Pali Rohar , Andreas Farber , Manivannan Sadhasivam , Krzysztof Kozlowski , Alim Akhtar , Laxman Dewangan , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , "David S. Miller" , Hammer Hsieh , Peter Korsgaard , Timur Tabi , Michal Simek , Rob Herring , sascha hauer , peng fan , kevin hilman , ulf hansson , len brown , pavel machek , joerg roedel , will deacon , andrew lunn , heiner kallweit , eric dumazet , jakub kicinski , paolo abeni , linus walleij , hideaki yoshifuji , david ahern , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-actions@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, sparclinux@vger.kernel.org, Ahmad Fatoum X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_091705_177339_135F61EB X-CRM114-Status: GOOD ( 17.05 ) X-Mailman-Approved-At: Tue, 28 Jun 2022 11:07:53 -0700 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Jun 28, 2022 at 7:00 AM Tobias Klauser wrote: > > On 2022-06-28 at 04:01:03 +0200, Saravana Kannan wrote: > > diff --git a/drivers/tty/serial/8250/8250_acorn.c b/drivers/tty/serial/8250/8250_acorn.c > > index 758c4aa203ab..5a6f2f67de4f 100644 > > --- a/drivers/tty/serial/8250/8250_acorn.c > > +++ b/drivers/tty/serial/8250/8250_acorn.c > > @@ -114,7 +114,6 @@ static const struct ecard_id serial_cids[] = { > > static struct ecard_driver serial_card_driver = { > > .probe = serial_card_probe, > > .remove = serial_card_remove, > > - .id_table = serial_cids, > > Is this change intentional? All other drivers are only changed to set > .probe_no_time and I don't see anything mentioned in the commit message > re. this driver's change. No, that's a mistake. Thanks for catching it! I'll check this patch again. -Saravana _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9939DC43334 for ; Wed, 29 Jun 2022 03:13:09 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LXmkD132Fz3dww for ; Wed, 29 Jun 2022 13:13:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=svPPiUXm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::b33; helo=mail-yb1-xb33.google.com; envelope-from=saravanak@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=svPPiUXm; dkim-atps=neutral Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LXV9D3P3Bz3c1b for ; Wed, 29 Jun 2022 02:17:04 +1000 (AEST) Received: by mail-yb1-xb33.google.com with SMTP id r3so23073429ybr.6 for ; Tue, 28 Jun 2022 09:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=svPPiUXmjLu4A2+b3rJgoCqrzxWVmAH7KXTvVP4AwaLTDrIN9AN3BtNG2XiV2ycJ8x 6Y9oMX5BQlCl6K+KL9J1KxqNRcb1MdTb/c18nJgwvmc5rVyOe8EKUyj+KrCbNC70iJoL OlJOsi9x5Scvw9W8cP8d/OYBAk6luTiA/PE8w/jzj7tOJ+ICpHFzyCnfh2xqrRn3YVLo nvgpT4pJzONw4hikJOgq/y8DRHjrG2lOfrc2hEWRc02ovhuxlfgkK9/gOnTwVGME5DOU 4AXMX65QfUYiz76GEkrT/465op3M51kj45IkhJmeQobRe1+J32FVHZumFFaJBd9Gan88 /wYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=rTBIM22QtYjQ3lnykni4PPrcJRRsShvsGP8Xxn+h/BxmvBkKSrKrWs46klFipbTBbD KmoEj6QVwN/hhoYfUnabTH5dwZysSf8s1by6QrlyRI0zysCdZGg/jkzwA/SHqHDqgWJW y4fG2Eaf6fC/7eQu7v6Nt00rIfRt/dbFgSRjazobY4yxBwcEWvP4e0nTcgSpTGl+2YN0 r6xiGrUlSZGSpED6Hvoardb3Rgl8uBcpqaO6oqsAK1lfXsa3XX6xRkvGoFs+usNw9UvA ZAUap+1A5zAc6YVMTShdWKK3iaAXvI5dV1t0kTpyKZ7L7yQSnGzp4dif8/S8zEmjBWPM 7POQ== X-Gm-Message-State: AJIora/qyBcChCcb2W+6mLapT47RiZiSa3n4WzJsVaILh/7cRe9vYL+I kCJiQnEXXc8Q60HxjKSEzhxU1Mkt7UWxSyE0EGqZyA== X-Google-Smtp-Source: AGRyM1vHa4WRnJlk4sln0xuJGdVhcpu8QS15R2N9PrbVvkglI7Nzwr0PBFdp1lTun6HJ/nUSS1O/TmeoEjFZPidRK0U= X-Received: by 2002:a25:5bc3:0:b0:669:b722:beb8 with SMTP id p186-20020a255bc3000000b00669b722beb8mr20258885ybb.447.1656433020483; Tue, 28 Jun 2022 09:17:00 -0700 (PDT) MIME-Version: 1.0 References: <20220628020110.1601693-1-saravanak@google.com> <20220628020110.1601693-3-saravanak@google.com> <20220628140025.qpom64ptru4ub6fu@distanz.ch> In-Reply-To: <20220628140025.qpom64ptru4ub6fu@distanz.ch> From: Saravana Kannan Date: Tue, 28 Jun 2022 09:16:24 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] serial: Set probe_no_timeout for all DT based drivers To: Tobias Klauser Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Wed, 29 Jun 2022 13:09:16 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew lunn , peng fan , "Rafael J. Wysocki" , linus walleij , Paul Mackerras , Alim Akhtar , Peter Korsgaard , linux-stm32@st-md-mailman.stormreply.com, Karol Gugala , Jerome Brunet , linux-samsung-soc@vger.kernel.org, Michal Simek , Hammer Hsieh , NXP Linux Team , Vineet Gupta , len brown , Nicolas Saenz Julienne , linux-pm@vger.kernel.org, Sascha Hauer , linux-unisoc@lists.infradead.org, Scott Branden , Andrew Jeffery , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Richard Genoud , Masami Hiramatsu , Pengutronix Kernel Team , Claudiu Beznea , Alexandre Belloni , pavel machek , Kunihiko Hayashi , eric dumazet , Thierry Reding , sascha hauer , Chunyan Zhang , Jonathan Hunter , Gabriel Somlo , linux-mips@vger.kernel.org, kernel-team@android.com, Martin Blumenstingl , linux-arm-msm@vger.kernel.org, linux-actions@lists.infradead.org, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Andreas Farber , Maxime Coquelin , Kevin Hilman , Pali Rohar , heiner kallweit , ulf hansson , Neil Armstrong , Lorenzo Pieralisi , A l Cooper , linux-tegra@vger.kernel.org, Jiri Slaby , linux-aspeed@lists.ozlabs.org, Rob Herring , Florian Fainelli , Mateusz Holenko , Alexander Shiyan , kevin hilman , Broadcom internal kernel review list , Joel Stanley , Orson Zhai , paolo abeni , Patrice Chotard , Ray Jui , Vladimir Zapolskiy , linux-snps-arc@lists.infradead.org, Timur Tabi , hideaki yoshifuji , iommu@lists.linux-foundation.org, Laxman Dewangan , Sudeep Holla , Baolin Wang , Shawn Guo , "David S. Miller" , Baruch Siach , Liviu Dudau , Alexandre Torgue , Bjorn Andersson , Paul Cercueil , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Ahmad Fatoum , joerg roedel , Russell King , Andy Gross , linux-serial@vger.kernel.org, jakub kicinski , will deacon , Manivannan Sadhasivam , linux-mediatek@lists.infradead.org, Fabio Estevam , Paul Walmsley , Matthias Brugger , Andy Shevchenko , Laurentiu Tudor , Taichi Sugaya , netdev@vger.kernel.org, david ahern , Nicolas Ferre , Krzysztof Kozlowski , Palmer Dabbelt , Takao Orito , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jun 28, 2022 at 7:00 AM Tobias Klauser wrote: > > On 2022-06-28 at 04:01:03 +0200, Saravana Kannan wrote: > > diff --git a/drivers/tty/serial/8250/8250_acorn.c b/drivers/tty/serial/8250/8250_acorn.c > > index 758c4aa203ab..5a6f2f67de4f 100644 > > --- a/drivers/tty/serial/8250/8250_acorn.c > > +++ b/drivers/tty/serial/8250/8250_acorn.c > > @@ -114,7 +114,6 @@ static const struct ecard_id serial_cids[] = { > > static struct ecard_driver serial_card_driver = { > > .probe = serial_card_probe, > > .remove = serial_card_remove, > > - .id_table = serial_cids, > > Is this change intentional? All other drivers are only changed to set > .probe_no_time and I don't see anything mentioned in the commit message > re. this driver's change. No, that's a mistake. Thanks for catching it! I'll check this patch again. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB94BC25B0F for ; Fri, 12 Aug 2022 09:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2HhxQewLKViKaBheW+6oTqb5du1Uid7P9tmjq+RM3bE=; b=gzy9FBqOjoncQM pFDCGrRzyONf6l4+MIP1TimRWnWxA1kcZwGTyO/Re1fujHp1iPjKuGy24fMa9cHYw5EZ1CGDXnHqB 3iYUb1+WEpt7CG1/TOHe9/NQt5bkz2J66kFyIHhFrgLlJDbWFUHTYgN7Uo11nU6Fpteg9sc/5cUMU dTIAOXbbbeLV22qJvLhaSY1rxNZOt0wBJi1gZirWdHtPpY86EUUdYQuajOXb0h7HIZWtdiemrlNVG ROE8tWveIXx0FzktVpntj1gxEHg7RYv/0mcY46tqA4sJ3cT/83yYdWNyslhP3H1i+GTWx3l5N+Jw6 mpYiNEZCO2KBp1/dgPkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMQd7-003SOT-O6; Fri, 12 Aug 2022 09:06:57 +0000 Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Dth-0079fM-2X for linux-amlogic@lists.infradead.org; Tue, 28 Jun 2022 16:17:06 +0000 Received: by mail-yb1-xb2c.google.com with SMTP id v185so13532156ybe.8 for ; Tue, 28 Jun 2022 09:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=svPPiUXmjLu4A2+b3rJgoCqrzxWVmAH7KXTvVP4AwaLTDrIN9AN3BtNG2XiV2ycJ8x 6Y9oMX5BQlCl6K+KL9J1KxqNRcb1MdTb/c18nJgwvmc5rVyOe8EKUyj+KrCbNC70iJoL OlJOsi9x5Scvw9W8cP8d/OYBAk6luTiA/PE8w/jzj7tOJ+ICpHFzyCnfh2xqrRn3YVLo nvgpT4pJzONw4hikJOgq/y8DRHjrG2lOfrc2hEWRc02ovhuxlfgkK9/gOnTwVGME5DOU 4AXMX65QfUYiz76GEkrT/465op3M51kj45IkhJmeQobRe1+J32FVHZumFFaJBd9Gan88 /wYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+P6wSeN2x0ZvD2/JjzHKyqS9/n/5A6tY5jiA6Lhnb8=; b=A7Jxwq+iYy8vp878JJFKH8vTbQrDnoqOT18m+U/+je3cJACXaEBpURjJiHb89Ky7ze /23YuGWaylJlW/NA3xZJyRH6Jxzwk47SRhsur5MMVqvHzGWAFC1HasaLQFPCZkVd/eYh jBq8HoepAxJrgXjyzQ0/aTcrP2BtKCe3ImtWZTfKSSoN80R4qxnJtG5RR5heosYUqShD t3Ulu2/IwUkkycqPJh7F+yIb1nxcwDDcC5h4CPzuE2bVNZ4R/0WqYurhNcrQp3HVynjx 4PkikgFSzBZmdvzzUCvdGTifdp0QuYuDoWHgM4wds415ufyWJ8Gyr4jbMNsiTNaVqwtO cTAw== X-Gm-Message-State: AJIora9Wo8pcpBy4vs47L2JSBDNVHr+Lj5/rvsX23dyw176Y1yzmyjbR scsxXFgwIbU+lcP+W1Hluh4Z8985fwhkrQn4fvEnFw== X-Google-Smtp-Source: AGRyM1vHa4WRnJlk4sln0xuJGdVhcpu8QS15R2N9PrbVvkglI7Nzwr0PBFdp1lTun6HJ/nUSS1O/TmeoEjFZPidRK0U= X-Received: by 2002:a25:5bc3:0:b0:669:b722:beb8 with SMTP id p186-20020a255bc3000000b00669b722beb8mr20258885ybb.447.1656433020483; Tue, 28 Jun 2022 09:17:00 -0700 (PDT) MIME-Version: 1.0 References: <20220628020110.1601693-1-saravanak@google.com> <20220628020110.1601693-3-saravanak@google.com> <20220628140025.qpom64ptru4ub6fu@distanz.ch> In-Reply-To: <20220628140025.qpom64ptru4ub6fu@distanz.ch> From: Saravana Kannan Date: Tue, 28 Jun 2022 09:16:24 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] serial: Set probe_no_timeout for all DT based drivers To: Tobias Klauser Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Laurentiu Tudor , Jiri Slaby , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Nicolas Saenz Julienne , Al Cooper , Andy Shevchenko , Paul Cercueil , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Russell King , Vineet Gupta , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Alexander Shiyan , Baruch Siach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Taichi Sugaya , Takao Orito , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Andy Gross , Bjorn Andersson , Pali Rohar , Andreas Farber , Manivannan Sadhasivam , Krzysztof Kozlowski , Alim Akhtar , Laxman Dewangan , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , "David S. Miller" , Hammer Hsieh , Peter Korsgaard , Timur Tabi , Michal Simek , Rob Herring , sascha hauer , peng fan , kevin hilman , ulf hansson , len brown , pavel machek , joerg roedel , will deacon , andrew lunn , heiner kallweit , eric dumazet , jakub kicinski , paolo abeni , linus walleij , hideaki yoshifuji , david ahern , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-actions@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, sparclinux@vger.kernel.org, Ahmad Fatoum X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_091705_164504_ED9424A2 X-CRM114-Status: GOOD ( 17.05 ) X-Mailman-Approved-At: Fri, 12 Aug 2022 02:06:54 -0700 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Jun 28, 2022 at 7:00 AM Tobias Klauser wrote: > > On 2022-06-28 at 04:01:03 +0200, Saravana Kannan wrote: > > diff --git a/drivers/tty/serial/8250/8250_acorn.c b/drivers/tty/serial/8250/8250_acorn.c > > index 758c4aa203ab..5a6f2f67de4f 100644 > > --- a/drivers/tty/serial/8250/8250_acorn.c > > +++ b/drivers/tty/serial/8250/8250_acorn.c > > @@ -114,7 +114,6 @@ static const struct ecard_id serial_cids[] = { > > static struct ecard_driver serial_card_driver = { > > .probe = serial_card_probe, > > .remove = serial_card_remove, > > - .id_table = serial_cids, > > Is this change intentional? All other drivers are only changed to set > .probe_no_time and I don't see anything mentioned in the commit message > re. this driver's change. No, that's a mistake. Thanks for catching it! I'll check this patch again. -Saravana _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic