From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFCDC636CC for ; Sat, 4 Feb 2023 22:31:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229448AbjBDWbG (ORCPT ); Sat, 4 Feb 2023 17:31:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbjBDWbC (ORCPT ); Sat, 4 Feb 2023 17:31:02 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F7212387A for ; Sat, 4 Feb 2023 14:30:56 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id w20so6059312pfn.4 for ; Sat, 04 Feb 2023 14:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2c3ryMxpOrIrZDVaOC8ynRmFu3tYBCZQcCXL31Q6F3k=; b=E4A5hYEQRp90Hq5gcHozZx89CANxAwz5pa5hV0u6D7/CSE7D9FjEvqXYB61jPCQN6R uanAQTYAH37I86uAD9fDVd49n5AU/IEwpa65uBkowop5pcrCfFX/HEqL6I3zA9pf0F/P 032WaKdRiA1F3CA+VV0gqYE/t8IDtiSmSqfwZvkJnIKPsa3Rxgert/AdhpNpC3cDkPXN ZbnNVdwFWbp0s9NZKPQf67Rm7IXXFcig56fq7QTqXVPsjWTVSNoZ/+s1RlvgWSk4eex2 1Ql/Hhl5ACwU2n9vWNsCmfribawOpaIaR63+0/CkkzNuCejBofd+kArEuZQQTqc6wP/+ PQpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2c3ryMxpOrIrZDVaOC8ynRmFu3tYBCZQcCXL31Q6F3k=; b=vF00UnVKefUyCsTCWR/2mZVFMJSW0rvSGUS2wUO7jZHPsxf/pWqMDVpLDl0/z9ZQmG BydENb6RzKUIOr2KD48ouMONP3S5xMSEsOwnoIYcX6DkQAQ/p8Nr7xD32SroNib4q4y1 LzbMtkCXMs7khcM9stXAYc27vx1Cqm8HkgdGKkIas0I9eLHlAc2ftT5+N0Ykc/WputNE O4cU2EPueDgcXuri/butKu8aeX09DYkrzyf3h4qgVSw8wjusCWhGy8wCxQviuL9NTpsc +LPYf1KTRncLVBYi6xDaCaq21qKAL7nfQ8j3qsvN2Nn+qLKF7JMm+RDA3mVEnsLINql+ nNFw== X-Gm-Message-State: AO0yUKW+pgv0EBZQvuLHchYHO9Y2Z/UQr43CApK4o9wtPtqzIVjwd6jz G9hRN9kNwoyN3TZoYSlQnnHVVo0QDNzu8usQgNDOew== X-Google-Smtp-Source: AK7set+ZC7Ks2eIaN+4nhpE4jlE1jqO/ZiAjj58j/wvorPO2PW5t0ia/NMESz7xFZXQD1dSaARAuey5tmskPGv2QHv4= X-Received: by 2002:a62:1a57:0:b0:593:bac2:b49 with SMTP id a84-20020a621a57000000b00593bac20b49mr3621986pfa.44.1675549855647; Sat, 04 Feb 2023 14:30:55 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Sat, 4 Feb 2023 14:30:19 -0800 Message-ID: Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jan 31, 2023 at 12:14 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Mon, Jan 30, 2023 at 9:00 PM Saravana Kannan wrote: > > On Mon, Jan 30, 2023 at 12:43 AM Geert Uytterhoeven > > wrote: > > > On Sat, Jan 28, 2023 at 8:19 AM Saravana Kannan wrote: > > > > On Fri, Jan 27, 2023 at 12:11 AM Geert Uytterhoeven > > > > wrote: > > > > > On Fri, Jan 27, 2023 at 1:11 AM Saravana Kannan wrote: > > > > > > The OF_POPULATED flag was set to let fw_devlink know that the device > > > > > > tree node will not have a struct device created for it. This information > > > > > > is used by fw_devlink to avoid deferring the probe of consumers of this > > > > > > device tree node. > > > > > > > > > > > > Let's use fwnode_dev_initialized() instead because it achieves the same > > > > > > effect without using OF specific flags. This allows more generic code to > > > > > > be written in driver core. > > > > > > > > > > > > Signed-off-by: Saravana Kannan > > > > > > > > > > Thanks for your patch! > > > > > > > > > > > --- a/drivers/soc/renesas/rcar-sysc.c > > > > > > +++ b/drivers/soc/renesas/rcar-sysc.c > > > > > > @@ -437,7 +437,7 @@ static int __init rcar_sysc_pd_init(void) > > > > > > > > > > > > error = of_genpd_add_provider_onecell(np, &domains->onecell_data); > > > > > > if (!error) > > > > > > - of_node_set_flag(np, OF_POPULATED); > > > > > > + fwnode_dev_initialized(&np->fwnode, true); > > > > > > > > > > As drivers/soc/renesas/rmobile-sysc.c is already using this method, > > > > > it should work fine. > > > > > > > > > > Reviewed-by: Geert Uytterhoeven > > > > > i.e. will queue in renesas-devel for v6.4. > > > > I hope you meant queue it up for 6.3 and not 6.4? > > V6.4. > The deadline for submitting pull requests for the soc tree is rc6. > Sorry, your series was posted too late to make that. > > > > > Thanks! Does that mean I should drop this from this series? If two > > > > maintainers pick the same patch up, will it cause problems? I'm > > > > eventually expecting this series to be picked up by Greg into > > > > driver-core-next. > > > > > > Indeed. Patches for drivers/soc/renesas/ are supposed to go upstream > > > through the renesas-devel and soc trees. This patch has no dependencies > > > on anything else in the series (or vice versa), so there is no reason > > > to deviate from that, and possibly cause conflicts later. > > > > This series is supposed to fix a bunch of issues and I vaguely think > > the series depends on this patch to work correctly on some Renesas > > systems. You are my main renesas person, so it's probably some issue > > you hit. Is you pick it up outside of this series I need to keep > > asking folks to pick up two different patch threads. I don't have a > > strong opinion, just a FYI. If you can take this patch soon, I don't > > have any concerns. > > Oh right, you do remove OF_POPULATED handling in > "[PATCH v2 09/11] of: property: Simplify of_link_to_phandle()". > It might be wise to postpone that removal, as after your series, > there are stillseveral users left, some of them might be impacted. > > I do plan to test your full series on all my boards, but probably that > won't happen this week. > > > > BTW, I will convert to of_node_to_fwnode() while applying. > > > > Sounds good. > > If you still want this to land in v6,3 (with the of_node_to_fwnode() > conversion): > Acked-by: Geert Uytterhoeven > Yeah, let me try to land this in 6.3 with the series. -Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A00EC636CC for ; Sat, 4 Feb 2023 22:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F49Fdu0rj9BP9ZOF1oEpYnJNNiW5Ma/czhX0cDbllV4=; b=CZ49J/aMa3jDyW Vxs3Ucu5FOYRPhAV2zjvSVdeW1BYJ2bVC5TRt+dB5Es65KgiYbIvF7TjKVEijk21urLZ7HPEf+iW/ lCmX2XVP6h9RDsGB6xCvA6kDkj/h4ED19s6qEeI/oE6ykRP+75VwRhoqDT/hU7mmIOji59ZRXcYfS 2ztzhV/J2+X41I18UHtptMFncjmKeHigdXKbU2aEuDhMdwvQ+2xpoKfCUCHlBjok7ygspEzG5tB89 EhLRpxJf8jbcD3qUFJvyQ/epYJB1oWEaNizoM7G0yfAehmBoou8H7ODbnPBg4bvIioRAL1CVJItFN qmooAKoGUeYKe3uCUU1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOR3o-005dRL-6p; Sat, 04 Feb 2023 22:31:04 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOR3k-005dQs-EV for linux-arm-kernel@lists.infradead.org; Sat, 04 Feb 2023 22:31:02 +0000 Received: by mail-pf1-x434.google.com with SMTP id o68so4774935pfg.9 for ; Sat, 04 Feb 2023 14:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2c3ryMxpOrIrZDVaOC8ynRmFu3tYBCZQcCXL31Q6F3k=; b=E4A5hYEQRp90Hq5gcHozZx89CANxAwz5pa5hV0u6D7/CSE7D9FjEvqXYB61jPCQN6R uanAQTYAH37I86uAD9fDVd49n5AU/IEwpa65uBkowop5pcrCfFX/HEqL6I3zA9pf0F/P 032WaKdRiA1F3CA+VV0gqYE/t8IDtiSmSqfwZvkJnIKPsa3Rxgert/AdhpNpC3cDkPXN ZbnNVdwFWbp0s9NZKPQf67Rm7IXXFcig56fq7QTqXVPsjWTVSNoZ/+s1RlvgWSk4eex2 1Ql/Hhl5ACwU2n9vWNsCmfribawOpaIaR63+0/CkkzNuCejBofd+kArEuZQQTqc6wP/+ PQpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2c3ryMxpOrIrZDVaOC8ynRmFu3tYBCZQcCXL31Q6F3k=; b=IVH5LGlqH+WvAGK031PED3lAQhGG89Ja6zXjzgKfZ5tJBZv0AKPhMErwhnBLYTxUEX uK2GWOntEzk7FhYHmh5xFfA72ajxl40wko7DsFH3TDFfidFaQDESrFmFbSSipzCHQO0Y FOn7EeYVi6XwT5eW2yX16xXpEcT5+wJCnZjjVb8MgE73IZLThphwAp7y54LgmbKGEOaG CewfccQXMlDhyQPFpGkG2UgTsJ9sD9eQS7fEktdIaj+HJxvnD40uNJOgrV4iBkARirr9 R3JjpexTW3h17E7WYr5QFVPia4ru1FO8RuNbx5MMyWCR/zLyZlaSu7ebYvqtRHXa6jfU cvOQ== X-Gm-Message-State: AO0yUKX6eByoA2Bqt9GfS9Z68R2MFYAt03FISpy0WMzhxdGJjVKj5/+H W3RyRMagN6tm2S/3Sk91vhL8WiRMenfq7G777FZThw== X-Google-Smtp-Source: AK7set+ZC7Ks2eIaN+4nhpE4jlE1jqO/ZiAjj58j/wvorPO2PW5t0ia/NMESz7xFZXQD1dSaARAuey5tmskPGv2QHv4= X-Received: by 2002:a62:1a57:0:b0:593:bac2:b49 with SMTP id a84-20020a621a57000000b00593bac20b49mr3621986pfa.44.1675549855647; Sat, 04 Feb 2023 14:30:55 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Sat, 4 Feb 2023 14:30:19 -0800 Message-ID: Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230204_143100_551849_902997B1 X-CRM114-Status: GOOD ( 46.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 31, 2023 at 12:14 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Mon, Jan 30, 2023 at 9:00 PM Saravana Kannan wrote: > > On Mon, Jan 30, 2023 at 12:43 AM Geert Uytterhoeven > > wrote: > > > On Sat, Jan 28, 2023 at 8:19 AM Saravana Kannan wrote: > > > > On Fri, Jan 27, 2023 at 12:11 AM Geert Uytterhoeven > > > > wrote: > > > > > On Fri, Jan 27, 2023 at 1:11 AM Saravana Kannan wrote: > > > > > > The OF_POPULATED flag was set to let fw_devlink know that the device > > > > > > tree node will not have a struct device created for it. This information > > > > > > is used by fw_devlink to avoid deferring the probe of consumers of this > > > > > > device tree node. > > > > > > > > > > > > Let's use fwnode_dev_initialized() instead because it achieves the same > > > > > > effect without using OF specific flags. This allows more generic code to > > > > > > be written in driver core. > > > > > > > > > > > > Signed-off-by: Saravana Kannan > > > > > > > > > > Thanks for your patch! > > > > > > > > > > > --- a/drivers/soc/renesas/rcar-sysc.c > > > > > > +++ b/drivers/soc/renesas/rcar-sysc.c > > > > > > @@ -437,7 +437,7 @@ static int __init rcar_sysc_pd_init(void) > > > > > > > > > > > > error = of_genpd_add_provider_onecell(np, &domains->onecell_data); > > > > > > if (!error) > > > > > > - of_node_set_flag(np, OF_POPULATED); > > > > > > + fwnode_dev_initialized(&np->fwnode, true); > > > > > > > > > > As drivers/soc/renesas/rmobile-sysc.c is already using this method, > > > > > it should work fine. > > > > > > > > > > Reviewed-by: Geert Uytterhoeven > > > > > i.e. will queue in renesas-devel for v6.4. > > > > I hope you meant queue it up for 6.3 and not 6.4? > > V6.4. > The deadline for submitting pull requests for the soc tree is rc6. > Sorry, your series was posted too late to make that. > > > > > Thanks! Does that mean I should drop this from this series? If two > > > > maintainers pick the same patch up, will it cause problems? I'm > > > > eventually expecting this series to be picked up by Greg into > > > > driver-core-next. > > > > > > Indeed. Patches for drivers/soc/renesas/ are supposed to go upstream > > > through the renesas-devel and soc trees. This patch has no dependencies > > > on anything else in the series (or vice versa), so there is no reason > > > to deviate from that, and possibly cause conflicts later. > > > > This series is supposed to fix a bunch of issues and I vaguely think > > the series depends on this patch to work correctly on some Renesas > > systems. You are my main renesas person, so it's probably some issue > > you hit. Is you pick it up outside of this series I need to keep > > asking folks to pick up two different patch threads. I don't have a > > strong opinion, just a FYI. If you can take this patch soon, I don't > > have any concerns. > > Oh right, you do remove OF_POPULATED handling in > "[PATCH v2 09/11] of: property: Simplify of_link_to_phandle()". > It might be wise to postpone that removal, as after your series, > there are stillseveral users left, some of them might be impacted. > > I do plan to test your full series on all my boards, but probably that > won't happen this week. > > > > BTW, I will convert to of_node_to_fwnode() while applying. > > > > Sounds good. > > If you still want this to land in v6,3 (with the of_node_to_fwnode() > conversion): > Acked-by: Geert Uytterhoeven > Yeah, let me try to land this in 6.3 with the series. -Saravana _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel