From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756757Ab2GKUHu (ORCPT ); Wed, 11 Jul 2012 16:07:50 -0400 Received: from na3sys009aog117.obsmtp.com ([74.125.149.242]:39691 "EHLO na3sys009aog117.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753318Ab2GKUHt (ORCPT ); Wed, 11 Jul 2012 16:07:49 -0400 MIME-Version: 1.0 In-Reply-To: <20120711125206.GB6615@kroah.com> References: <1341647872-15267-1-git-send-email-eduardo.valentin@ti.com> <1341647872-15267-2-git-send-email-eduardo.valentin@ti.com> <20120709193130.GA12982@kroah.com> <20120711125206.GB6615@kroah.com> Date: Wed, 11 Jul 2012 23:07:47 +0300 Message-ID: Subject: Re: [PATCHv2 1/4] staging: OMAP4+: thermal: introduce bandgap temperature sensor From: "Valentin, Eduardo" To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, b-cousson@ti.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, kbaidarov@dev.rtsoft.ru, grant.likely@secretlab.ca Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg, On Wed, Jul 11, 2012 at 3:52 PM, Greg Kroah-Hartman wrote: > On Wed, Jul 11, 2012 at 01:07:17PM +0300, Valentin, Eduardo wrote: >> Hello Greg, >> >> On Mon, Jul 9, 2012 at 11:33 PM, Valentin, Eduardo >> wrote: >> > Hello Greg, >> > >> > On Mon, Jul 9, 2012 at 10:31 PM, Greg Kroah-Hartman >> > g wrote: >> >> On Sat, Jul 07, 2012 at 10:57:49AM +0300, Eduardo Valentin wrote: >> >>> In the System Control Module, OMAP supplies a voltage reference >> >>> and a temperature sensor feature that are gathered in the band >> >>> gap voltage and temperature sensor (VBGAPTS) module. The band >> >>> gap provides current and voltage reference for its internal >> >>> circuits and other analog IP blocks. The analog-to-digital >> >>> converter (ADC) produces an output value that is proportional >> >>> to the silicon temperature. >> >>> >> >>> This patch provides a platform driver which expose this feature. >> >>> It is moduled as a MFD child of the System Control Module core >> >>> MFD driver. >> >>> >> >>> This driver provides only APIs to access the device properties, >> >>> like temperature, thresholds and update rate. >> >>> >> >>> Signed-off-by: Eduardo Valentin >> >>> Signed-off-by: Keerthy >> >> >> >> As much as I enjoy interesting names, odds are, "Keerthy" is not the >> >> real name of this person, right? In fact, based on the copyright >> >> comments in the code, I can almost guarantee it... >> >> >> >> I need a full-name please, no aliases or fake names allowed in kernel >> >> signed-off-by lines. >> >> >> >> Please resend these with that fixed up. >> > >> > Actually, his name is in fact Keerthy J. I can resend with the >> > additional "J" the way it is in the copyrights. >> >> While looking into his commits, I believe the SOB in this patch is one >> of the ways he uses to sign: >> commit f99c1d4f94f91fd3a20bd2eaa3be9c5e7d2668eb >> Author: Keerthy >> Date: Tue Mar 1 19:12:26 2011 +0530 >> >> mfd: Add twl4030 madc driver >> >> Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring >> ADC. This driver monitors the real time conversion of analog signals like >> battery temperature, battery cuurent etc. >> >> Signed-off-by: Keerthy >> Signed-off-by: Samuel Ortiz >> >> So, I'd prefer to keep the way it is. > > But it doesn't match the copyright notice, which I am guessing TI got > "right" from a legal perspective, and as such, we need to also. > Now I see your point, it makes sense. Resending V3 of this patch in reply on this thread. It will contain his SOB the way it is in the copyright notice. > thanks, > > greg k-h -- Eduardo Valentin