From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbcADVkl (ORCPT ); Mon, 4 Jan 2016 16:40:41 -0500 Received: from mail-vk0-f65.google.com ([209.85.213.65]:33581 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbcADVkj (ORCPT ); Mon, 4 Jan 2016 16:40:39 -0500 MIME-Version: 1.0 In-Reply-To: References: <11dd04072f65c0b168a9d842549c3705a34076b3.1451937845.git.geyslan@gmail.com> Date: Mon, 4 Jan 2016 18:40:38 -0300 Message-ID: Subject: Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast From: "Geyslan G. Bem" To: Alan Stern Cc: LKML , Greg Kroah-Hartman , linux-usb@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-01-04 17:58 GMT-03:00 Alan Stern : > On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > >> This patch fixes coding style issues reported by checkpatch concerning >> to unnecessary space after a cast. > > This is a case where checkpatch is wrong, IMO. Casts should always be > followed by a space. I will not accept this patch. Ok. I understand. > > This must be something recently added to checkpatch. It never used to > complain about casts, whether they were followed by a space or not. I'm using the checkpatch --strict option. > > Alan Stern > >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/host/ehci-dbg.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c >> index 1645120..edae79e 100644 >> --- a/drivers/usb/host/ehci-dbg.c >> +++ b/drivers/usb/host/ehci-dbg.c >> @@ -123,7 +123,7 @@ dbg_qh(const char *label, struct ehci_hcd *ehci, struct ehci_qh *qh) >> >> ehci_dbg(ehci, "%s qh %p n%08x info %x %x qtd %x\n", label, >> qh, hw->hw_next, hw->hw_info1, hw->hw_info2, hw->hw_current); >> - dbg_qtd("overlay", ehci, (struct ehci_qtd *) &hw->hw_qtd_next); >> + dbg_qtd("overlay", ehci, (struct ehci_qtd *)&hw->hw_qtd_next); >> } >> >> static void __maybe_unused >> @@ -491,7 +491,7 @@ static void qh_lines( >> (scratch >> 16) & 0x7fff, >> scratch, >> td->urb, >> - (u32) td->qtd_dma, >> + (u32)td->qtd_dma, >> hc32_to_cpup(ehci, &td->hw_buf[0])); >> if (size < temp) >> temp = size; >> > -- Regards, Geyslan G. Bem hackingbits.com