From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823AbcADX2X (ORCPT ); Mon, 4 Jan 2016 18:28:23 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34592 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbcADX2T (ORCPT ); Mon, 4 Jan 2016 18:28:19 -0500 MIME-Version: 1.0 In-Reply-To: References: <5fd0da9565d9883d5ef9a14aacd343d7cca23698.1451937845.git.geyslan@gmail.com> Date: Mon, 4 Jan 2016 20:28:17 -0300 Message-ID: Subject: Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions From: "Geyslan G. Bem" To: Alan Stern Cc: LKML , Greg Kroah-Hartman , linux-usb@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-01-04 18:00 GMT-03:00 Alan Stern : > On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > >> Functions must have the opening brace at the beginning of the next line >> and body conforming indentation. > > This isn't necessary if the function is an empty static inline void > routine. Ok. It's more related to style. Let's forget it. > > Alan Stern > >> This patch also reduces qh_lines() header definition to two lines. >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/host/ehci-dbg.c | 44 +++++++++++++++++++++++++++++--------------- >> 1 file changed, 29 insertions(+), 15 deletions(-) >> >> diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c >> index edae79e..a365d9d 100644 >> --- a/drivers/usb/host/ehci-dbg.c >> +++ b/drivers/usb/host/ehci-dbg.c >> @@ -54,7 +54,9 @@ static void dbg_hcs_params(struct ehci_hcd *ehci, char *label) >> } >> #else >> >> -static inline void dbg_hcs_params(struct ehci_hcd *ehci, char *label) {} >> +static inline void dbg_hcs_params(struct ehci_hcd *ehci, char *label) >> +{ >> +} >> >> #endif >> >> @@ -94,7 +96,9 @@ static void dbg_hcc_params(struct ehci_hcd *ehci, char *label) >> } >> #else >> >> -static inline void dbg_hcc_params(struct ehci_hcd *ehci, char *label) {} >> +static inline void dbg_hcc_params(struct ehci_hcd *ehci, char *label) >> +{ >> +} >> >> #endif >> >> @@ -284,23 +288,32 @@ dbg_port_buf(char *buf, unsigned len, const char *label, int port, u32 status) >> #else >> static inline void __maybe_unused >> dbg_qh(char *label, struct ehci_hcd *ehci, struct ehci_qh *qh) >> -{} >> +{ >> +} >> >> static inline int __maybe_unused >> dbg_status_buf(char *buf, unsigned len, const char *label, u32 status) >> -{ return 0; } >> +{ >> + return 0; >> +} >> >> static inline int __maybe_unused >> dbg_command_buf(char *buf, unsigned len, const char *label, u32 command) >> -{ return 0; } >> +{ >> + return 0; >> +} >> >> static inline int __maybe_unused >> dbg_intr_buf(char *buf, unsigned len, const char *label, u32 enable) >> -{ return 0; } >> +{ >> + return 0; >> +} >> >> static inline int __maybe_unused >> dbg_port_buf(char *buf, unsigned len, const char *label, int port, u32 status) >> -{ return 0; } >> +{ >> + return 0; >> +} >> >> #endif /* CONFIG_DYNAMIC_DEBUG */ >> >> @@ -327,8 +340,13 @@ dbg_port_buf(char *buf, unsigned len, const char *label, int port, u32 status) >> >> #ifdef STUB_DEBUG_FILES >> >> -static inline void create_debug_files(struct ehci_hcd *bus) { } >> -static inline void remove_debug_files(struct ehci_hcd *bus) { } >> +static inline void create_debug_files(struct ehci_hcd *bus) >> +{ >> +} >> + >> +static inline void remove_debug_files(struct ehci_hcd *bus) >> +{ >> +} >> >> #else >> >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci, __hc32 token) >> return '/'; >> } >> >> -static void qh_lines( >> - struct ehci_hcd *ehci, >> - struct ehci_qh *qh, >> - char **nextp, >> - unsigned *sizep >> -) >> +static void qh_lines(struct ehci_hcd *ehci, struct ehci_qh *qh, >> + char **nextp, unsigned *sizep) >> { >> u32 scratch; >> u32 hw_curr; >> > And about that style? Should be done? -- Regards, Geyslan G. Bem hackingbits.com