Help with DISTRO settings

Help with DISTRO settings

[Edward Wingate]

This is in my layer's conf/distro/mydistro.conf file:

    require conf/distro/poky.conf
    DISTRO = "mydistro"
    DISTRO_NAME = "MyDistro"

These variables took effect before, but now bitbake is reverting back
to DISTRO="poky" and DISTRO_NAME = "Poky (Yocto Project Reference
Distro)" (used for /etc/issue) for some reason.

How can I determine what is reverting it?  I don't know what I might
have changed to make it do this. Thank you.

Re: Help with DISTRO settings

[Khem Raj]

On Sat, Jul 23, 2016 at 10:49 PM, Edward Wingate <edwingate8@gmail.com> wrote:
> This is in my layer's conf/distro/mydistro.conf file:
>
>     require conf/distro/poky.conf
>     DISTRO = "mydistro"
>     DISTRO_NAME = "MyDistro"

Move these DISTRO settings above require conf/distro/poky.conf

>
> These variables took effect before, but now bitbake is reverting back
> to DISTRO="poky" and DISTRO_NAME = "Poky (Yocto Project Reference
> Distro)" (used for /etc/issue) for some reason.
>
> How can I determine what is reverting it?  I don't know what I might
> have changed to make it do this. Thank you.
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Re: Help with DISTRO settings

[Edward Wingate]

On Sat, Jul 23, 2016 at 11:05 PM, Khem Raj <raj.khem@gmail.com> wrote:
> Move these DISTRO settings above require conf/distro/poky.conf

That didn't change anything.  And it had been working like that for a
long time now.  Just a few days ago, it stopped taking effect and
reverting back to poky.  I have not been able to figure out what
caused it to stop working.

Thanks for your reply nonetheless.

Re: Help with DISTRO settings

[Edward Wingate]

Ah, I found it.  I had inadvertently deleted one line
(DISTRO="mydistro") from my layer's conf/layer.conf.

Am I doing this right though?  Do I need DISTRO="mydistro" in both
conf/layer.conf and conf/distro/mydistro.conf?  Removing it from
either doesn't work, but it seems redundant to put it in mydistro.conf
as well.


On Sun, Jul 24, 2016 at 12:04 AM, Edward Wingate <edwingate8@gmail.com> wrote:
> On Sat, Jul 23, 2016 at 11:05 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> Move these DISTRO settings above require conf/distro/poky.conf
>
> That didn't change anything.  And it had been working like that for a
> long time now.  Just a few days ago, it stopped taking effect and
> reverting back to poky.  I have not been able to figure out what
> caused it to stop working.
>
> Thanks for your reply nonetheless.

Re: Help with DISTRO settings

[Khem Raj]

On Sun, Jul 24, 2016 at 12:34 AM, Edward Wingate <edwingate8@gmail.com> wrote:
> Ah, I found it.  I had inadvertently deleted one line
> (DISTRO="mydistro") from my layer's conf/layer.conf.
>
> Am I doing this right though?  Do I need DISTRO="mydistro" in both
> conf/layer.conf and conf/distro/mydistro.conf?

Just conf/distro/mydistro.conf is needed.

 Removing it from
> either doesn't work, but it seems redundant to put it in mydistro.conf
> as well.

did you make any other changes ?

>
>
> On Sun, Jul 24, 2016 at 12:04 AM, Edward Wingate <edwingate8@gmail.com> wrote:
>> On Sat, Jul 23, 2016 at 11:05 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>> Move these DISTRO settings above require conf/distro/poky.conf
>>
>> That didn't change anything.  And it had been working like that for a
>> long time now.  Just a few days ago, it stopped taking effect and
>> reverting back to poky.  I have not been able to figure out what
>> caused it to stop working.
>>
>> Thanks for your reply nonetheless.

Re: Help with DISTRO settings

[Edward Wingate]

On Sun, Jul 24, 2016 at 7:38 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Sun, Jul 24, 2016 at 12:34 AM, Edward Wingate <edwingate8@gmail.com> wrote:
>> Ah, I found it.  I had inadvertently deleted one line
>> (DISTRO="mydistro") from my layer's conf/layer.conf.
>>
>> Am I doing this right though?  Do I need DISTRO="mydistro" in both
>> conf/layer.conf and conf/distro/mydistro.conf?
>
> Just conf/distro/mydistro.conf is needed.

Well, it didn't work if it is only in conf/distro/mydistro.conf.  I
had to have it in conf/layer.conf as well.

>>  Removing it from
>> either doesn't work, but it seems redundant to put it in mydistro.conf
>> as well.
>
> did you make any other changes ?

Not that I know of.  It stopped working when it was mistakenly removed
from conf/layer.conf.  Started working again when I put it back in.
And just to test it, I removed it from conf/distro/mydistro.conf and
that also didn't work.  I have to have it in both places.

Re: Help with DISTRO settings

[Nicolas Dechesne]

On Mon, Jul 25, 2016 at 9:13 AM, Edward Wingate <edwingate8@gmail.com> wrote:
>> Just conf/distro/mydistro.conf is needed.
>
> Well, it didn't work if it is only in conf/distro/mydistro.conf.  I
> had to have it in conf/layer.conf as well.

hmm. you shouldn't set DISTRO in conf/layer.conf, that doesn't sound
right. DISTRO needs to be set in local.conf (or any of the other build
specific conf files). DISTRO is then used by bitbake.conf file which
does :

include conf/distro/${DISTRO}.conf

this is how your DISTRO config file gets used in the build configuration.

Re: Help with DISTRO settings

[Edward Wingate]

On Mon, Jul 25, 2016 at 1:27 AM, Nicolas Dechesne
<nicolas.dechesne@linaro.org> wrote:
> hmm. you shouldn't set DISTRO in conf/layer.conf, that doesn't sound
> right. DISTRO needs to be set in local.conf (or any of the other build
> specific conf files).

I agree, I don't know why I had it in conf/layer.conf.  Just
beginner's mistake.

I moved DISTRO to local.conf (changed the existing DISTRO ?= "poky" to
DISTRO ?= "mydistro") and it still works.  But if I remove DISTRO from
conf/distro/mydistro.conf, DISTRO will revert to "poky", even though
it is set to my "mydistro" in local.conf.  So it seems I have to have
it in both places.

Re: Help with DISTRO settings

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]


> On Jul 25, 2016, at 8:31 PM, Edward Wingate <edwingate8@gmail.com> wrote:
> 
> On Mon, Jul 25, 2016 at 1:27 AM, Nicolas Dechesne
> <nicolas.dechesne@linaro.org> wrote:
>> hmm. you shouldn't set DISTRO in conf/layer.conf, that doesn't sound
>> right. DISTRO needs to be set in local.conf (or any of the other build
>> specific conf files).
> 
> I agree, I don't know why I had it in conf/layer.conf.  Just
> beginner's mistake.
> 
> I moved DISTRO to local.conf (changed the existing DISTRO ?= "poky" to
> DISTRO ?= "mydistro") and it still works.  But if I remove DISTRO from
> conf/distro/mydistro.conf, DISTRO will revert to "poky", even though
> it is set to my "mydistro" in local.conf.  So it seems I have to have
> it in both places.

in your mydistro.conf you should first set the settings that you want to customize
then include conf/distro/poky.conf not other way around. May be we should change poky.conf
to use ??= so the substitution happens at the end of parsing. but thats for another time.

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: Help with DISTRO settings

[Paul Eggleton]

On Mon, 25 Jul 2016 20:34:32 Khem Raj wrote:
> > On Jul 25, 2016, at 8:31 PM, Edward Wingate <edwingate8@gmail.com> wrote:
> > 
> > On Mon, Jul 25, 2016 at 1:27 AM, Nicolas Dechesne
> > 
> > <nicolas.dechesne@linaro.org> wrote:
> >> hmm. you shouldn't set DISTRO in conf/layer.conf, that doesn't sound
> >> right. DISTRO needs to be set in local.conf (or any of the other build
> >> specific conf files).
> > 
> > I agree, I don't know why I had it in conf/layer.conf.  Just
> > beginner's mistake.
> > 
> > I moved DISTRO to local.conf (changed the existing DISTRO ?= "poky" to
> > DISTRO ?= "mydistro") and it still works.  But if I remove DISTRO from
> > conf/distro/mydistro.conf, DISTRO will revert to "poky", even though
> > it is set to my "mydistro" in local.conf.  So it seems I have to have
> > it in both places.
> 
> in your mydistro.conf you should first set the settings that you want to
> customize then include conf/distro/poky.conf not other way around. May be
> we should change poky.conf to use ??= so the substitution happens at the
> end of parsing. but thats for another time.

I'm clearly missing something - why must it be done that way around? If you 
were to set the values you want *after* the include/require then that should 
work just fine, and would be the way I would recommend doing it - it's also 
the way poky-lsb distro does it.

One thing to note is that poky.conf itself sets DISTRO, mostly for historical 
reasons I believe. Thus if you do include/require poky.conf then you may wish 
to set DISTRO back to whatever it should be and you'd have to do that after 
the include/require, not before it.

Another thing to consider is that any _poky overrides will only be applied if 
DISTRO = "poky", thus include/require of poky.conf won't incorporate those 
into your custom distro. You can set DISTROOVERRIDES to include "poky" to 
counter this. In practice though there aren't too many of these - in fact I 
can only see one in the psplash recipe.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: Help with DISTRO settings

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]


> On Jul 25, 2016, at 10:00 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> 
> On Mon, 25 Jul 2016 20:34:32 Khem Raj wrote:
>>> On Jul 25, 2016, at 8:31 PM, Edward Wingate <edwingate8@gmail.com> wrote:
>>> 
>>> On Mon, Jul 25, 2016 at 1:27 AM, Nicolas Dechesne
>>> 
>>> <nicolas.dechesne@linaro.org> wrote:
>>>> hmm. you shouldn't set DISTRO in conf/layer.conf, that doesn't sound
>>>> right. DISTRO needs to be set in local.conf (or any of the other build
>>>> specific conf files).
>>> 
>>> I agree, I don't know why I had it in conf/layer.conf.  Just
>>> beginner's mistake.
>>> 
>>> I moved DISTRO to local.conf (changed the existing DISTRO ?= "poky" to
>>> DISTRO ?= "mydistro") and it still works.  But if I remove DISTRO from
>>> conf/distro/mydistro.conf, DISTRO will revert to "poky", even though
>>> it is set to my "mydistro" in local.conf.  So it seems I have to have
>>> it in both places.
>> 
>> in your mydistro.conf you should first set the settings that you want to
>> customize then include conf/distro/poky.conf not other way around. May be
>> we should change poky.conf to use ??= so the substitution happens at the
>> end of parsing. but thats for another time.
> 
> I'm clearly missing something - why must it be done that way around? If you
> were to set the values you want *after* the include/require then that should
> work just fine, and would be the way I would recommend doing it - it's also
> the way poky-lsb distro does it.
> 
> One thing to note is that poky.conf itself sets DISTRO, mostly for historical
> reasons I believe. Thus if you do include/require poky.conf then you may wish
> to set DISTRO back to whatever it should be and you'd have to do that after
> the include/require, not before it.

Those are valid assertions. However user is changing DISTRO ?= “poky”
which will take effect if DISTRO is unset before above is parsed.

> 
> Another thing to consider is that any _poky overrides will only be applied if
> DISTRO = "poky", thus include/require of poky.conf won't incorporate those
> into your custom distro. You can set DISTROOVERRIDES to include "poky" to
> counter this. In practice though there aren't too many of these - in fact I
> can only see one in the psplash recipe.
> 
> Cheers,
> Paul
> 
> --
> 
> Paul Eggleton
> Intel Open Source Technology Centre


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]