From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037D8C433FE for ; Sun, 19 Sep 2021 17:32:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF33C6101C for ; Sun, 19 Sep 2021 17:32:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231192AbhISReU (ORCPT ); Sun, 19 Sep 2021 13:34:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230523AbhISReP (ORCPT ); Sun, 19 Sep 2021 13:34:15 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 874C5C061574; Sun, 19 Sep 2021 10:32:50 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id d11so12162383ilc.8; Sun, 19 Sep 2021 10:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7Gbr6qUKWHVKiXPdk5V4pk0xSy2NBQ/5pmcHqgFNJHo=; b=AXOm5AdXPt/dNYXBz0ZQmUVAkNTQysRL+nzDPvs+OfsKKjeW8e7zcwbLtMKOJgBqwk Sd/HH4Lj60j5HOcrUXyycsW53ObpyAMuKQtekdws7y1dshwkTOZhaYtdBeeEKjQzx0fX BaZlbeBn/8FMR0kPDjr8LukGKNuy1vaVsypjh7VaVhWUGj4rhpKiu3TOvfLfigQQAKJu aXL1sl41FtbDTO7QCjyzbSK7VR8PRz3esnq7ovQFfEqdXl2gW16MCvRdgvu1pSOQeIvM Kc/9nzw5jraMY6ERb/dRgJLsdd6qHrU0E2zp6EFZrQkuhPEITgpWcNxAvKqowHvQCurH 88Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7Gbr6qUKWHVKiXPdk5V4pk0xSy2NBQ/5pmcHqgFNJHo=; b=R1ijs+G3+BFZ51Lz84F+WRK4DrnutqJsdiwRA3y+QFd3Ewluc2CN+XRG4gzXYYKsuo DdvRy/6x3HqdO/kkf9sIIAJTrEhs25IPwo636RI/Sa1U4cGx1FUIjTEiD/qgHOO4UEKF wHXjxKSOW8rbPkzFnvWk1f6QtwLdJ7s7nq3B04222ujYRS3d2rrkCREJ8sjLmS32WQwx kaiRlMyO+X3gk+OF5DLGhCCrYW5zqslUipqlQsRVuYuACTQjVcAV+ZjmgzmjwcphTDKN 9o4BxahjAdXOIAzX3Srs92KZYpsOAO7/c7sR8yUaMLqNxRc6P5PJ6uaJteN+S2qXW8y3 yZfg== X-Gm-Message-State: AOAM533BPSEwbeoB/RAWGUfNTbgt6V8Rl2mwuvPnuv/5P59gts0sp411 yQB9c2Yv37oCWtn6BRBTYC5WxK03KqAix4wecOc= X-Google-Smtp-Source: ABdhPJxP1B+9Kdk+qN58zeHUOx+M9WqXgfLUyibiCfebby9oMAIQOYaggirngAIT5qDJstvUfMfpsim8DJBqG28QhtM= X-Received: by 2002:a05:6e02:1bed:: with SMTP id y13mr5594036ilv.249.1632072769987; Sun, 19 Sep 2021 10:32:49 -0700 (PDT) MIME-Version: 1.0 References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> From: Alim Akhtar Date: Sun, 19 Sep 2021 23:02:14 +0530 Message-ID: Subject: Re: [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module! To: Krzysztof Kozlowski Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, open list , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof On Sun, Sep 19, 2021 at 6:28 PM Krzysztof Kozlowski wrote: > > Hi, > > Changes since v1 > ================ > 1. Drop patch 1/2 - exporting soc_device_to_device > 2. Add new patches: 1/3 and 3/3. > > Question > ======== > > A question - what is the convention for naming modules: underscores '_' or > hyphens '-'? > > The C-unit file already uses a hyphen "exynos-chipid.c", so I could > create a module named: > 1. exynos_chipid > 2. soc-exynos-chipid > 3. exynos-chip-id > > The Linux device name is "exynos-chipid". > > Best regards, > Krzysztof > > > Krzysztof Kozlowski (3): > soc: samsung: exynos-chipid: avoid soc_device_to_device() > soc: samsung: exynos-chipid: convert to a module > soc: samsung: exynos-chipid: do not enforce built-in > > arch/arm/mach-exynos/Kconfig | 1 - > drivers/soc/samsung/Kconfig | 4 +++- > drivers/soc/samsung/Makefile | 3 ++- > drivers/soc/samsung/exynos-chipid.c | 14 +++++++++++--- > drivers/soc/samsung/exynos5422-asv.c | 1 + > 5 files changed, 17 insertions(+), 6 deletions(-) > Thanks for the patches. For this series Reviewed-by: Alim Akhtar Also tested on exynos7 based platform, so Tested-by: Alim Akhtar > -- > 2.30.2 > -- Regards, Alim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164FAC433F5 for ; Sun, 19 Sep 2021 17:34:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9D4B6101C for ; Sun, 19 Sep 2021 17:34:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C9D4B6101C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eWKc226x2tSS88pdWAsaOnVV8cIJYMN+z4TjimgAerE=; b=aHFqIAQZ3pjrIx gXpIem2Q56uJFjVXSVTsZLL8CeO9BsCodhQcfESbwyfGdGm3Io4Uarrp4f3W4uRwhSAnMDbhWVA4E OhygrzG/YCLu8EkPs9SrBYWA44eBBZTJcYj0SLXgXnEm9D4CrQB7jPbM3wUUkp6FWZAJFbqFYF1DN cwDDZbuP7PMYnh5omgWCO3mlktejzngnwD4q2isOtFG+mPAw/jaPRmCjpJMkXLPUVsqvKhe/+Dczz M3ts3QYI5jCOK12Rt5/w2Dq6fn/rB/qAkoIXtL6jiPugN5f2k1kfXf6v3Ah02ts0YBpvuutDehW39 n1GLNOmaqJ7wZ/v7Z9Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS0gQ-00HZxV-NJ; Sun, 19 Sep 2021 17:32:54 +0000 Received: from mail-il1-x135.google.com ([2607:f8b0:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS0gN-00HZwk-Jn for linux-arm-kernel@lists.infradead.org; Sun, 19 Sep 2021 17:32:52 +0000 Received: by mail-il1-x135.google.com with SMTP id x2so16031345ila.11 for ; Sun, 19 Sep 2021 10:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7Gbr6qUKWHVKiXPdk5V4pk0xSy2NBQ/5pmcHqgFNJHo=; b=AXOm5AdXPt/dNYXBz0ZQmUVAkNTQysRL+nzDPvs+OfsKKjeW8e7zcwbLtMKOJgBqwk Sd/HH4Lj60j5HOcrUXyycsW53ObpyAMuKQtekdws7y1dshwkTOZhaYtdBeeEKjQzx0fX BaZlbeBn/8FMR0kPDjr8LukGKNuy1vaVsypjh7VaVhWUGj4rhpKiu3TOvfLfigQQAKJu aXL1sl41FtbDTO7QCjyzbSK7VR8PRz3esnq7ovQFfEqdXl2gW16MCvRdgvu1pSOQeIvM Kc/9nzw5jraMY6ERb/dRgJLsdd6qHrU0E2zp6EFZrQkuhPEITgpWcNxAvKqowHvQCurH 88Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7Gbr6qUKWHVKiXPdk5V4pk0xSy2NBQ/5pmcHqgFNJHo=; b=H6CmhjnJzgLtLXtvR0QXvzAyuFEeIaHvl8AprTPIU20r2I7ovhRPqpuoabsbn3U5ns e5b+/W63qToINgiO8xiI6/hKJrXbTdo4CUTFyaqTT4Q6dXGUrEyblu9QvI9u2zYu1Jqn md3ViCCs/4xM6aQ60jsANZcEsBoqjLoQx3h6jIfu2O+aKZKfZY8xKl5PA324s1oF+lqb zXRT1Zz8AXaAM/pOspxvODnc3HpNsPqtdZvW7yi/+oazS3Hco3CDdcxoFzNVdFWiitoT 4QcDLWLAosR2V//h2wkXKmb82De8PejFPvdSrFEbK2t5MfS8xjLsG/OLNtzfR4r9WeaC TvSw== X-Gm-Message-State: AOAM53384xsENYr8K0q83Azv63oEYB8yzYDObss+Y76ZSoDN2TQ/B8+E H+fpL3R51M2CXFnW5hw5LSrw9yk54f2k+09LncM= X-Google-Smtp-Source: ABdhPJxP1B+9Kdk+qN58zeHUOx+M9WqXgfLUyibiCfebby9oMAIQOYaggirngAIT5qDJstvUfMfpsim8DJBqG28QhtM= X-Received: by 2002:a05:6e02:1bed:: with SMTP id y13mr5594036ilv.249.1632072769987; Sun, 19 Sep 2021 10:32:49 -0700 (PDT) MIME-Version: 1.0 References: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210919093114.35987-1-krzysztof.kozlowski@canonical.com> From: Alim Akhtar Date: Sun, 19 Sep 2021 23:02:14 +0530 Message-ID: Subject: Re: [PATCH v2 0/3] soc: samsung: exynos-chipid: be a module! To: Krzysztof Kozlowski Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, open list , Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_103251_711334_1B9293CA X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Krzysztof On Sun, Sep 19, 2021 at 6:28 PM Krzysztof Kozlowski wrote: > > Hi, > > Changes since v1 > ================ > 1. Drop patch 1/2 - exporting soc_device_to_device > 2. Add new patches: 1/3 and 3/3. > > Question > ======== > > A question - what is the convention for naming modules: underscores '_' or > hyphens '-'? > > The C-unit file already uses a hyphen "exynos-chipid.c", so I could > create a module named: > 1. exynos_chipid > 2. soc-exynos-chipid > 3. exynos-chip-id > > The Linux device name is "exynos-chipid". > > Best regards, > Krzysztof > > > Krzysztof Kozlowski (3): > soc: samsung: exynos-chipid: avoid soc_device_to_device() > soc: samsung: exynos-chipid: convert to a module > soc: samsung: exynos-chipid: do not enforce built-in > > arch/arm/mach-exynos/Kconfig | 1 - > drivers/soc/samsung/Kconfig | 4 +++- > drivers/soc/samsung/Makefile | 3 ++- > drivers/soc/samsung/exynos-chipid.c | 14 +++++++++++--- > drivers/soc/samsung/exynos5422-asv.c | 1 + > 5 files changed, 17 insertions(+), 6 deletions(-) > Thanks for the patches. For this series Reviewed-by: Alim Akhtar Also tested on exynos7 based platform, so Tested-by: Alim Akhtar > -- > 2.30.2 > -- Regards, Alim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel