From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63AA9C433F5 for ; Thu, 6 Jan 2022 18:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242967AbiAFSm7 (ORCPT ); Thu, 6 Jan 2022 13:42:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242965AbiAFSm7 (ORCPT ); Thu, 6 Jan 2022 13:42:59 -0500 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE7A3C061245; Thu, 6 Jan 2022 10:42:58 -0800 (PST) Received: by mail-io1-xd30.google.com with SMTP id 19so4231376ioz.4; Thu, 06 Jan 2022 10:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3BKBH7bXrSa7D2NBRCF3DtqxqnTEQJ2QlSdlcjBQtLw=; b=IaIzfOAl83AKok3656+22nOkSeCWmg/58JB1QkmQly1kVVCt6224b2hTbv6Xq6u5D7 BnvuIKLeZmFRsPx17I5vU2GxscZimDwMpjlrmCCAR5lOrp1Izbb01IFuOhWhXGA8aCnR EWZFobsvA1cBQB3ddFx6ja5M1JDApPhxPvBoFDsmwqRpol0iM38HN4q++EmLmnDsANfs GyaClzSPmIQf7REvFw0QrqkSzA83iQ39+KaMiZAxSS/SPeVYY5darGRa58XRyqXw7Miu 1h3jP8mN9ZSS2QhHU7sJz1b+rUlSaXTOLBGim8Y9alPZNNWIMKqCud60SUsAHc3Lpu51 dCMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3BKBH7bXrSa7D2NBRCF3DtqxqnTEQJ2QlSdlcjBQtLw=; b=0w4YDY1zzbgVhYYj195aGjihbAwg32FCGSeT/kef2jRU9nUcYXUiZNzYgnPMuCtQeE 3aSS683WtwaamDAaZW0eOVKPruRWcpkl6DgNNrKpHjInDNuMRinofyCpgzHbo8rlgh+m Zo27toHSEYqyFQNvM10JO/FHUmHvc7jlerWWb0ODFAi9yotiEx6ImeVzLiGeAoTG5R4C eivn3oWUnZr0BiVtukFYNEvhLJz6tKXmJsM2A4Q3mTLrrMKFKmmAIgomAU8M38/vvQeJ SEBVI4ayjrftOHScm8GizrtCC+8huBeJO4j04fw+HYvIIlUMHkWH0UsXiLNnyqMt/01O yQaA== X-Gm-Message-State: AOAM532QO53nUJNORW+cdEk4Xhn1lI8DdDHq5iiLhzhDDAK86dTQHhbp MaFs/SNo7GYcKqILNwYbYu1Kgndwc2PJz8pJrZM= X-Google-Smtp-Source: ABdhPJww3eQIXfkqUkfXk7et0oXtpkP9Zj5ynkVb1R886yXUB/7KMk919g2ZzLham/tTXHlfUcUR5cB/fjLK0IlvfpE= X-Received: by 2002:a02:b384:: with SMTP id p4mr26830812jan.167.1641494578260; Thu, 06 Jan 2022 10:42:58 -0800 (PST) MIME-Version: 1.0 References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> <20211231161930.256733-6-krzysztof.kozlowski@canonical.com> In-Reply-To: <20211231161930.256733-6-krzysztof.kozlowski@canonical.com> From: Alim Akhtar Date: Fri, 7 Jan 2022 00:12:22 +0530 Message-ID: Subject: Re: [PATCH 05/24] ARM: dts: exynos: override pins by label in Peach Pit To: Krzysztof Kozlowski Cc: Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, open list , Marek Szyprowski , Sylwester Nawrocki , Sam Protsenko , Chanho Park Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Krzysztof On Sat, Jan 1, 2022 at 11:15 AM Krzysztof Kozlowski wrote: > > Using node paths to extend or override a device tree node is error > prone. If there was a typo error, a new node will be created instead of > extending the existing node. This will lead to run-time errors that > could be hard to detect. > > A mistyped label on the other hand, will cause a dtc compile error > (during build time). > While it makes sense to do this, was wondering if you faced any issue with the current implementation? > Signed-off-by: Krzysztof Kozlowski > --- Feel free to add Reviewed-by: Alim Akhtar > arch/arm/boot/dts/exynos5420-peach-pit.dts | 44 +++++++++++----------- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index e76fb104db19..1ae5528e9ebf 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -868,27 +868,26 @@ pmic_dvs_1: pmic-dvs-1 { > }; > }; > > -&pinctrl_1 { > - /* Adjust WiFi drive strengths lower for EMI */ > - sd1_clk: sd1-clk { > - samsung,pin-drv = ; > - }; > +/* pinctrl_1 */ > +/* Adjust WiFi drive strengths lower for EMI */ > +&sd1_bus1 { > + samsung,pin-drv = ; > +}; > > - sd1_cmd: sd1-cmd { > - samsung,pin-drv = ; > - }; > +&sd1_bus4 { > + samsung,pin-drv = ; > +}; > > - sd1_bus1: sd1-bus-width1 { > - samsung,pin-drv = ; > - }; > +&sd1_bus8 { > + samsung,pin-drv = ; > +}; > > - sd1_bus4: sd1-bus-width4 { > - samsung,pin-drv = ; > - }; > +&sd1_clk { > + samsung,pin-drv = ; > +}; > > - sd1_bus8: sd1-bus-width8 { > - samsung,pin-drv = ; > - }; > +&sd1_cmd { > + samsung,pin-drv = ; > }; > > &pinctrl_2 { > @@ -907,12 +906,13 @@ pmic_dvs_3: pmic-dvs-3 { > }; > }; > > -&pinctrl_3 { > - /* Drive SPI lines at x2 for better integrity */ > - spi2-bus { > - samsung,pin-drv = ; > - }; > +/* pinctrl_3*/ > +/* Drive SPI lines at x2 for better integrity */ > +&spi2_bus { > + samsung,pin-drv = ; > +}; > > +&pinctrl_3 { > /* Drive SPI chip select at x2 for better integrity */ > ec_spi_cs: ec-spi-cs { > samsung,pins = "gpb1-2"; > -- > 2.32.0 > -- Regards, Alim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD997C433EF for ; Thu, 6 Jan 2022 18:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GlziOgFLRcjqGiWq8m2BOBpQpBX6OMrgELv9iy7fOOI=; b=J66jdUM0EvnGfg 8GThdQK+sYWM4EDlhV+xZRxE05atCgJyjObvVgPjPUpEbO5t5KpUC6e2VyU3X3BKiHCBi6cQ83Grz 4bnTKxcTGVyK+zmPB9EJwy+Sg1g5TMNn71BM6rtwWXCogloTMwRb+gBiwtd4FHkK7VLbMdGf1HY0h d47O1mIXoaI5yCfir66pJoeNXifuUXINfqEGSftQR3+f/UvwOjAKFpTwu7/qkxkl5VX2pHUEynOLq ndsDH1bldYX38hERHia7F/Nzn1d4fWrM7QW4ViK6S/67sIbL4WcRZT+n7bw914W5uaQqlMfOg3z7W 3LP/ybyZ2WsLu0X1ce6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5Xj5-0015lN-8h; Thu, 06 Jan 2022 18:43:03 +0000 Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5Xj1-0015k4-Fr for linux-arm-kernel@lists.infradead.org; Thu, 06 Jan 2022 18:43:00 +0000 Received: by mail-io1-xd2c.google.com with SMTP id s6so4303528ioj.0 for ; Thu, 06 Jan 2022 10:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3BKBH7bXrSa7D2NBRCF3DtqxqnTEQJ2QlSdlcjBQtLw=; b=IaIzfOAl83AKok3656+22nOkSeCWmg/58JB1QkmQly1kVVCt6224b2hTbv6Xq6u5D7 BnvuIKLeZmFRsPx17I5vU2GxscZimDwMpjlrmCCAR5lOrp1Izbb01IFuOhWhXGA8aCnR EWZFobsvA1cBQB3ddFx6ja5M1JDApPhxPvBoFDsmwqRpol0iM38HN4q++EmLmnDsANfs GyaClzSPmIQf7REvFw0QrqkSzA83iQ39+KaMiZAxSS/SPeVYY5darGRa58XRyqXw7Miu 1h3jP8mN9ZSS2QhHU7sJz1b+rUlSaXTOLBGim8Y9alPZNNWIMKqCud60SUsAHc3Lpu51 dCMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3BKBH7bXrSa7D2NBRCF3DtqxqnTEQJ2QlSdlcjBQtLw=; b=U49jAZWPj/3rpNcpPwL70T2RFkZE7ykPvSjB9MkqsrmGA+/88f3ADY1PnGEldosn7T 37HpyDvZR80yrpV7Z8K6gaiCrb+E9e6oOaZO8a3GzhKcnNZdSRBMA6vOGzoKq0alH773 DAb9NS3WBvPgkh3C/a/dppgqDohIrw7+rZ7pEtAg8tBoqVZ4OlBOYi1Tde09zQpzUYmp WQRSrIMoLq6PVPAs6s++wDEVYN5f3K5W6Ty0BJHP9e8g0h/yupihRP7JQiNx1MgJmLoC reTt99ou5NqsyVdRDeVB75rfic0P//hyYb7FizdFDe1GGYPy2R4WXwEqIO5cbvIZ7o8M hfUw== X-Gm-Message-State: AOAM533VB45Csa+qRNY/dK2KPSlgrQFIgTn74PvqyID3yN0WfOrjZYPw MbNrUCbMjSO6GtLk7JaQ84B/MQK7G5KFd3sqtak= X-Google-Smtp-Source: ABdhPJww3eQIXfkqUkfXk7et0oXtpkP9Zj5ynkVb1R886yXUB/7KMk919g2ZzLham/tTXHlfUcUR5cB/fjLK0IlvfpE= X-Received: by 2002:a02:b384:: with SMTP id p4mr26830812jan.167.1641494578260; Thu, 06 Jan 2022 10:42:58 -0800 (PST) MIME-Version: 1.0 References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> <20211231161930.256733-6-krzysztof.kozlowski@canonical.com> In-Reply-To: <20211231161930.256733-6-krzysztof.kozlowski@canonical.com> From: Alim Akhtar Date: Fri, 7 Jan 2022 00:12:22 +0530 Message-ID: Subject: Re: [PATCH 05/24] ARM: dts: exynos: override pins by label in Peach Pit To: Krzysztof Kozlowski Cc: Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, open list , Marek Szyprowski , Sylwester Nawrocki , Sam Protsenko , Chanho Park X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220106_104259_557846_94C04840 X-CRM114-Status: GOOD ( 20.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof On Sat, Jan 1, 2022 at 11:15 AM Krzysztof Kozlowski wrote: > > Using node paths to extend or override a device tree node is error > prone. If there was a typo error, a new node will be created instead of > extending the existing node. This will lead to run-time errors that > could be hard to detect. > > A mistyped label on the other hand, will cause a dtc compile error > (during build time). > While it makes sense to do this, was wondering if you faced any issue with the current implementation? > Signed-off-by: Krzysztof Kozlowski > --- Feel free to add Reviewed-by: Alim Akhtar > arch/arm/boot/dts/exynos5420-peach-pit.dts | 44 +++++++++++----------- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index e76fb104db19..1ae5528e9ebf 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -868,27 +868,26 @@ pmic_dvs_1: pmic-dvs-1 { > }; > }; > > -&pinctrl_1 { > - /* Adjust WiFi drive strengths lower for EMI */ > - sd1_clk: sd1-clk { > - samsung,pin-drv = ; > - }; > +/* pinctrl_1 */ > +/* Adjust WiFi drive strengths lower for EMI */ > +&sd1_bus1 { > + samsung,pin-drv = ; > +}; > > - sd1_cmd: sd1-cmd { > - samsung,pin-drv = ; > - }; > +&sd1_bus4 { > + samsung,pin-drv = ; > +}; > > - sd1_bus1: sd1-bus-width1 { > - samsung,pin-drv = ; > - }; > +&sd1_bus8 { > + samsung,pin-drv = ; > +}; > > - sd1_bus4: sd1-bus-width4 { > - samsung,pin-drv = ; > - }; > +&sd1_clk { > + samsung,pin-drv = ; > +}; > > - sd1_bus8: sd1-bus-width8 { > - samsung,pin-drv = ; > - }; > +&sd1_cmd { > + samsung,pin-drv = ; > }; > > &pinctrl_2 { > @@ -907,12 +906,13 @@ pmic_dvs_3: pmic-dvs-3 { > }; > }; > > -&pinctrl_3 { > - /* Drive SPI lines at x2 for better integrity */ > - spi2-bus { > - samsung,pin-drv = ; > - }; > +/* pinctrl_3*/ > +/* Drive SPI lines at x2 for better integrity */ > +&spi2_bus { > + samsung,pin-drv = ; > +}; > > +&pinctrl_3 { > /* Drive SPI chip select at x2 for better integrity */ > ec_spi_cs: ec-spi-cs { > samsung,pins = "gpb1-2"; > -- > 2.32.0 > -- Regards, Alim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel