From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F432C433F5 for ; Wed, 5 Jan 2022 16:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242074AbiAEQ6m (ORCPT ); Wed, 5 Jan 2022 11:58:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242066AbiAEQ6g (ORCPT ); Wed, 5 Jan 2022 11:58:36 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93EE7C061201 for ; Wed, 5 Jan 2022 08:58:35 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id g13so54863087ljj.10 for ; Wed, 05 Jan 2022 08:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7FCM7ExCLWgqCTqTGogExMuf/fiieL3PsozNySRBWtE=; b=UQxsz9w3fkWnSccar+KDsZ83AI6OixpNiN8xTU1b2sOqqEwdQhvx1yD4iYHi36ijhJ VGrV9Q6JhyM+5Pu3efTFQxkkCYMqjBuP5/ximPBM7M2Y7nm++Ncv2eFszDeLoRRSKBCA 8zbrU/FJuSlgZptM/5bumFucFka3QxUvCyXoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7FCM7ExCLWgqCTqTGogExMuf/fiieL3PsozNySRBWtE=; b=Bg5AlUXr9SCfwsnFyxmrWsLVGbUzcJ4lrpjHkmChNNqd9yjmRtuf7Wr/qdWsl0Zb9p G74WAxawLVluLoXqIPBW6Ll4PVTRF4LeHkRP819SYqGWrK0W2KwYM35c99lj+UiiT+IW KhyL7yx1rc5eiS1iSkmaDxkpademUN1Qzg8WvdM+js6GquqF1gqbm5+fjv2J2qE9kQCS ZP2TDae6sDEWcyWbUyEyR//CDdMCme4yaH1AjlN6gn3Bx6eH++64TBrQV6adE1yRRiTn 7uyIS/OIbAcg3nbsNUGufbD3WPPRuh5FrStNX29Mz3pVpNGmy9RlIdAKnB0JoesVIn42 ZSSw== X-Gm-Message-State: AOAM531FJX33BdE1SkiIUdp9Zlw5Hs57ahGWdfUmUFR48TE/7d25kjgy 5QRn84as5AcsFRhp/pBORa3ZyoHmvlFYKAQpLDw8dcydC5HbiJcTwBLmwIJ2kYXS/z45cKAwc9I 1s8EQVN8PuNWrvpl0yXgAjnnqq60ViYCYTujH2GIU0A== X-Google-Smtp-Source: ABdhPJxf4kDEGFJZonps1Gx7Yh4NifjctN15yGaQUwO8Nwfvk3H6tGxsXvk8mhA5Lgq9rMS8JX0v8xF2HVqlxvXe9U4= X-Received: by 2002:a2e:9f17:: with SMTP id u23mr47426430ljk.309.1641401913827; Wed, 05 Jan 2022 08:58:33 -0800 (PST) MIME-Version: 1.0 References: <20220105093552.27542-1-pali@kernel.org> In-Reply-To: <20220105093552.27542-1-pali@kernel.org> From: Roman Bacik Date: Wed, 5 Jan 2022 08:57:09 -0800 Message-ID: Subject: Re: [PATCH] PCI: iproc: Set all 24 bits of PCI class code To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Lorenzo Pieralisi , Rob Herring , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 5, 2022 at 1:36 AM Pali Roh=C3=A1r wrote: > > Register 0x43c in its low 24 bits contains PCI class code. > > Update code to set all 24 bits of PCI class code and not only upper 16 bi= ts > of PCI class code. > > Use a new macro PCI_CLASS_BRIDGE_PCI_NORMAL which represents whole 24 bit= s > of normal PCI bridge class. > > Signed-off-by: Pali Roh=C3=A1r > > --- > Roman helped me with this change and confirmed that class code is stored > really in bits [23:0] of custom register 0x43c (normally class code is > stored in bits [31:8] of pci register 0x08). > > This patch depends on patch which adds PCI_CLASS_BRIDGE_PCI_NORMAL macro: > https://lore.kernel.org/linux-pci/20211220145140.31898-1-pali@kernel.org/ > --- > drivers/pci/controller/pcie-iproc.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller= /pcie-iproc.c > index 3df4ab209253..2519201b0e51 100644 > --- a/drivers/pci/controller/pcie-iproc.c > +++ b/drivers/pci/controller/pcie-iproc.c > @@ -789,14 +789,13 @@ static int iproc_pcie_check_link(struct iproc_pcie = *pcie) > return -EFAULT; > } > > - /* force class to PCI_CLASS_BRIDGE_PCI (0x0604) */ > + /* force class to PCI_CLASS_BRIDGE_PCI_NORMAL (0x060400) */ > #define PCI_BRIDGE_CTRL_REG_OFFSET 0x43c > -#define PCI_CLASS_BRIDGE_MASK 0xffff00 > -#define PCI_CLASS_BRIDGE_SHIFT 8 > +#define PCI_BRIDGE_CTRL_REG_CLASS_MASK 0xffffff > iproc_pci_raw_config_read32(pcie, 0, PCI_BRIDGE_CTRL_REG_OFFSET, > 4, &class); > - class &=3D ~PCI_CLASS_BRIDGE_MASK; > - class |=3D (PCI_CLASS_BRIDGE_PCI << PCI_CLASS_BRIDGE_SHIFT); > + class &=3D ~PCI_BRIDGE_CTRL_REG_CLASS_MASK; > + class |=3D PCI_CLASS_BRIDGE_PCI_NORMAL; > iproc_pci_raw_config_write32(pcie, 0, PCI_BRIDGE_CTRL_REG_OFFSET, > 4, class); > > -- > 2.20.1 > Acked-by: Roman Bacik --=20 This electronic communication and the information and any files transmitted= =20 with it, or attached to it, are confidential and are intended solely for=20 the use of the individual or entity to whom it is addressed and may contain= =20 information that is confidential, legally privileged, protected by privacy= =20 laws, or otherwise restricted from disclosure to anyone else. If you are=20 not the intended recipient or the person responsible for delivering the=20 e-mail to the intended recipient, you are hereby notified that any use,=20 copying, distributing, dissemination, forwarding, printing, or copying of= =20 this e-mail is strictly prohibited. If you received this e-mail in error,= =20 please return the e-mail to the sender, delete it from your computer, and= =20 destroy any printed copy of it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C677EC433EF for ; Wed, 5 Jan 2022 16:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cDx/J5N0TVBfEQx+Lf1JTXWp+v7dQiikhQPK6LY/E74=; b=s7OJKBMaHq687s fLC8dCiIC7Upl2qqFa1faOpdPZRmewljXkuriAT8ZCHreN+gUjhr6nPrJHF4MaobqK0PrY60J8jrS fvhdxJCr1WUCvKPro+qy3fJttmYtQ4A2OuGQ01LfjvehyQl+pgxjlk/tOL+ukWcedF3dl+eGDA8e8 BpBd+6XG7iyWzOj+x38firJL5yDxGt8N1f9agkaCRae1oKtnzU3sw5+w2s4STGk7gmoA5B0mPz6Et FBwCz+4oeQuueVmC4W8Ioi1G5/H0UQEwTsrNmrxOwTXJhFh3J+8wwhRQVRgqKbivE93GFEeSAfuKf Zq3iLnksWPp0hikblTKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n59cW-00FNYO-QT; Wed, 05 Jan 2022 16:58:40 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n59cT-00FNWk-6q for linux-arm-kernel@lists.infradead.org; Wed, 05 Jan 2022 16:58:38 +0000 Received: by mail-lj1-x22a.google.com with SMTP id k27so66963929ljc.4 for ; Wed, 05 Jan 2022 08:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7FCM7ExCLWgqCTqTGogExMuf/fiieL3PsozNySRBWtE=; b=UQxsz9w3fkWnSccar+KDsZ83AI6OixpNiN8xTU1b2sOqqEwdQhvx1yD4iYHi36ijhJ VGrV9Q6JhyM+5Pu3efTFQxkkCYMqjBuP5/ximPBM7M2Y7nm++Ncv2eFszDeLoRRSKBCA 8zbrU/FJuSlgZptM/5bumFucFka3QxUvCyXoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7FCM7ExCLWgqCTqTGogExMuf/fiieL3PsozNySRBWtE=; b=7uTzqf3edknJKa9Kmri0cx6niyQMwllQ53QwmWdsbzKtW+q5qAAwoWuz2jWLfRE1pz Yuu3Sgx4hEKOPE+9iKviGIMB9f6RR8jXxzTeL1grCa7dH+V1wQPFhOy5tSc4MH2iPO+h Xy/AdUb3cytfqueFFh1F1Zvk0LsVN7T1J81Rj2GPd9h5vprBL3XagHvnpD+a78wfuogP PTPOFFaF+E5Ng7lyecSd9RcgenHV7m4xhp3rbgYiyHxYn9yFHQVzCPFGqagoKCrQAhKr wi0rdCTlCYs3Y9SQ9nrL74qsKISy3IQIiXoDELScuS+VFi/8Xv614Smja7IowN639ndE XCQg== X-Gm-Message-State: AOAM53226VkoBt9L6Ai7nKVZqvKMybHQPAgx+llvvouTFnWkM7aQVoeW IQzruF0GsyRLvpGh/rQ5ocL6IU6/7hnTAa7Bh6sRBkUEdhhR39ienRaLlqzXZ9TPkqufLnrflHE VTLdWGE6yY88D+m5Fgl2ly/s0FDAPdmsqkro3YKO4Fw== X-Google-Smtp-Source: ABdhPJxf4kDEGFJZonps1Gx7Yh4NifjctN15yGaQUwO8Nwfvk3H6tGxsXvk8mhA5Lgq9rMS8JX0v8xF2HVqlxvXe9U4= X-Received: by 2002:a2e:9f17:: with SMTP id u23mr47426430ljk.309.1641401913827; Wed, 05 Jan 2022 08:58:33 -0800 (PST) MIME-Version: 1.0 References: <20220105093552.27542-1-pali@kernel.org> In-Reply-To: <20220105093552.27542-1-pali@kernel.org> From: Roman Bacik Date: Wed, 5 Jan 2022 08:57:09 -0800 Message-ID: Subject: Re: [PATCH] PCI: iproc: Set all 24 bits of PCI class code To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Lorenzo Pieralisi , Rob Herring , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220105_085837_303400_ADB81826 X-CRM114-Status: GOOD ( 22.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKYW4gNSwgMjAyMiBhdCAxOjM2IEFNIFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5v cmc+IHdyb3RlOgo+Cj4gUmVnaXN0ZXIgMHg0M2MgaW4gaXRzIGxvdyAyNCBiaXRzIGNvbnRhaW5z IFBDSSBjbGFzcyBjb2RlLgo+Cj4gVXBkYXRlIGNvZGUgdG8gc2V0IGFsbCAyNCBiaXRzIG9mIFBD SSBjbGFzcyBjb2RlIGFuZCBub3Qgb25seSB1cHBlciAxNiBiaXRzCj4gb2YgUENJIGNsYXNzIGNv ZGUuCj4KPiBVc2UgYSBuZXcgbWFjcm8gUENJX0NMQVNTX0JSSURHRV9QQ0lfTk9STUFMIHdoaWNo IHJlcHJlc2VudHMgd2hvbGUgMjQgYml0cwo+IG9mIG5vcm1hbCBQQ0kgYnJpZGdlIGNsYXNzLgo+ Cj4gU2lnbmVkLW9mZi1ieTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPgo+IC0tLQo+ IFJvbWFuIGhlbHBlZCBtZSB3aXRoIHRoaXMgY2hhbmdlIGFuZCBjb25maXJtZWQgdGhhdCBjbGFz cyBjb2RlIGlzIHN0b3JlZAo+IHJlYWxseSBpbiBiaXRzIFsyMzowXSBvZiBjdXN0b20gcmVnaXN0 ZXIgMHg0M2MgKG5vcm1hbGx5IGNsYXNzIGNvZGUgaXMKPiBzdG9yZWQgaW4gYml0cyBbMzE6OF0g b2YgcGNpIHJlZ2lzdGVyIDB4MDgpLgo+Cj4gVGhpcyBwYXRjaCBkZXBlbmRzIG9uIHBhdGNoIHdo aWNoIGFkZHMgUENJX0NMQVNTX0JSSURHRV9QQ0lfTk9STUFMIG1hY3JvOgo+IGh0dHBzOi8vbG9y ZS5rZXJuZWwub3JnL2xpbnV4LXBjaS8yMDIxMTIyMDE0NTE0MC4zMTg5OC0xLXBhbGlAa2VybmVs Lm9yZy8KPiAtLS0KPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2llLWlwcm9jLmMgfCA5ICsr KystLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpZS1pcHJvYy5jIGIv ZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2llLWlwcm9jLmMKPiBpbmRleCAzZGY0YWIyMDkyNTMu LjI1MTkyMDFiMGU1MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUt aXByb2MuYwo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpZS1pcHJvYy5jCj4gQEAg LTc4OSwxNCArNzg5LDEzIEBAIHN0YXRpYyBpbnQgaXByb2NfcGNpZV9jaGVja19saW5rKHN0cnVj dCBpcHJvY19wY2llICpwY2llKQo+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsKPiAg ICAgICAgIH0KPgo+IC0gICAgICAgLyogZm9yY2UgY2xhc3MgdG8gUENJX0NMQVNTX0JSSURHRV9Q Q0kgKDB4MDYwNCkgKi8KPiArICAgICAgIC8qIGZvcmNlIGNsYXNzIHRvIFBDSV9DTEFTU19CUklE R0VfUENJX05PUk1BTCAoMHgwNjA0MDApICovCj4gICNkZWZpbmUgUENJX0JSSURHRV9DVFJMX1JF R19PRkZTRVQgICAgIDB4NDNjCj4gLSNkZWZpbmUgUENJX0NMQVNTX0JSSURHRV9NQVNLICAgICAg ICAgIDB4ZmZmZjAwCj4gLSNkZWZpbmUgUENJX0NMQVNTX0JSSURHRV9TSElGVCAgICAgICAgIDgK PiArI2RlZmluZSBQQ0lfQlJJREdFX0NUUkxfUkVHX0NMQVNTX01BU0sgMHhmZmZmZmYKPiAgICAg ICAgIGlwcm9jX3BjaV9yYXdfY29uZmlnX3JlYWQzMihwY2llLCAwLCBQQ0lfQlJJREdFX0NUUkxf UkVHX09GRlNFVCwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA0LCAmY2xh c3MpOwo+IC0gICAgICAgY2xhc3MgJj0gflBDSV9DTEFTU19CUklER0VfTUFTSzsKPiAtICAgICAg IGNsYXNzIHw9IChQQ0lfQ0xBU1NfQlJJREdFX1BDSSA8PCBQQ0lfQ0xBU1NfQlJJREdFX1NISUZU KTsKPiArICAgICAgIGNsYXNzICY9IH5QQ0lfQlJJREdFX0NUUkxfUkVHX0NMQVNTX01BU0s7Cj4g KyAgICAgICBjbGFzcyB8PSBQQ0lfQ0xBU1NfQlJJREdFX1BDSV9OT1JNQUw7Cj4gICAgICAgICBp cHJvY19wY2lfcmF3X2NvbmZpZ193cml0ZTMyKHBjaWUsIDAsIFBDSV9CUklER0VfQ1RSTF9SRUdf T0ZGU0VULAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA0LCBjbGFzcyk7 Cj4KPiAtLQo+IDIuMjAuMQo+CgpBY2tlZC1ieTogUm9tYW4gQmFjaWsgPHJvbWFuLmJhY2lrQGJy b2FkY29tLmNvbT4KCi0tIApUaGlzIGVsZWN0cm9uaWMgY29tbXVuaWNhdGlvbiBhbmQgdGhlIGlu Zm9ybWF0aW9uIGFuZCBhbnkgZmlsZXMgdHJhbnNtaXR0ZWQgCndpdGggaXQsIG9yIGF0dGFjaGVk IHRvIGl0LCBhcmUgY29uZmlkZW50aWFsIGFuZCBhcmUgaW50ZW5kZWQgc29sZWx5IGZvciAKdGhl IHVzZSBvZiB0aGUgaW5kaXZpZHVhbCBvciBlbnRpdHkgdG8gd2hvbSBpdCBpcyBhZGRyZXNzZWQg YW5kIG1heSBjb250YWluIAppbmZvcm1hdGlvbiB0aGF0IGlzIGNvbmZpZGVudGlhbCwgbGVnYWxs eSBwcml2aWxlZ2VkLCBwcm90ZWN0ZWQgYnkgcHJpdmFjeSAKbGF3cywgb3Igb3RoZXJ3aXNlIHJl c3RyaWN0ZWQgZnJvbSBkaXNjbG9zdXJlIHRvIGFueW9uZSBlbHNlLiBJZiB5b3UgYXJlIApub3Qg dGhlIGludGVuZGVkIHJlY2lwaWVudCBvciB0aGUgcGVyc29uIHJlc3BvbnNpYmxlIGZvciBkZWxp dmVyaW5nIHRoZSAKZS1tYWlsIHRvIHRoZSBpbnRlbmRlZCByZWNpcGllbnQsIHlvdSBhcmUgaGVy ZWJ5IG5vdGlmaWVkIHRoYXQgYW55IHVzZSwgCmNvcHlpbmcsIGRpc3RyaWJ1dGluZywgZGlzc2Vt aW5hdGlvbiwgZm9yd2FyZGluZywgcHJpbnRpbmcsIG9yIGNvcHlpbmcgb2YgCnRoaXMgZS1tYWls IGlzIHN0cmljdGx5IHByb2hpYml0ZWQuIElmIHlvdSByZWNlaXZlZCB0aGlzIGUtbWFpbCBpbiBl cnJvciwgCnBsZWFzZSByZXR1cm4gdGhlIGUtbWFpbCB0byB0aGUgc2VuZGVyLCBkZWxldGUgaXQg ZnJvbSB5b3VyIGNvbXB1dGVyLCBhbmQgCmRlc3Ryb3kgYW55IHByaW50ZWQgY29weSBvZiBpdC4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK