From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 089E5C10F14 for ; Thu, 11 Apr 2019 10:34:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEFBF2084D for ; Thu, 11 Apr 2019 10:34:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RrBSE2Us" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726753AbfDKKes (ORCPT ); Thu, 11 Apr 2019 06:34:48 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:39704 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbfDKKer (ORCPT ); Thu, 11 Apr 2019 06:34:47 -0400 Received: by mail-wm1-f68.google.com with SMTP id n25so5982227wmk.4; Thu, 11 Apr 2019 03:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ncP/XNUc6zUJMN6LMeRFfRBUv3h/NA4fn494LmOhRG8=; b=RrBSE2Usc9PBkc7LAnBazfFCMJYidCyT2Ku0n71GbZZKb23GkVn5nbFq2uwPbmzd7t M/Ai4p0mmF5+xoGCyQkOABae4LRxfhs0yKoDzVBSUb8i4hCnf4LQwEeer+ZSahHY+0RJ mUFwI/KaJ24zYnuLLWB4PHUU3MF0HEKnWCtgXNVUvyFLoMQnmAl25rBCxSRx5z6c/Qpe +jiinKtSMc5jEtzHYmdFniH1Ll45Na5yLFMyomvD9iTV7AmF9uFPeR0BO3fyroLcZcqX t4NMphRED/AS4doJLsvAkN56rtQ5CE5f5wfIv+UPz/2otXxaeCfPL88ku9Hf00UoIWuF yxhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ncP/XNUc6zUJMN6LMeRFfRBUv3h/NA4fn494LmOhRG8=; b=SeHNNUBS6SNr5JKjSvn6XTDAw9cgJAyCnRh0S3NyuB83ul5CGGfYEjF5O+rN6wtwye 9zQTbSZ4GO9G4Tg6G+bufqYBXnN5Typqdq7yQri8f1G8URTzpO69x4SBOORG11j1gQ17 VmnDKOoeOwcnz9vF8SixFhr3SGYh2RBXuBorigG5+Dk8ghQz8yptBuG4pW/zChERIxHg sQ6w2smtks+w33ehag5p3Ke3Gs09ElQgYs3m2sy3tpq5apSPeT5F1aS3v1R7kdlbTXBq Ftc6mJ1Ij/KIr+xRaAyNvtfJlixqx9m9VqELcOp7sYMzpxQzhY/BhTpafi+rnnXy6Wtd ZCJw== X-Gm-Message-State: APjAAAUh5ibMIL7fujlY43TtlGS312KsR9859OmdcaVtzYg0UkKn5pLE qAtj87D9uBRkTt4kovxjYqUZBplj5+AxPjrI2Gs= X-Google-Smtp-Source: APXvYqxxCXwjF9kqHwwwiWd9xsdmZosDQqKBbtF+8N3rXMyB3xLNbDAv48MMIJr2EQBnQEJJTjcA5IsgI+HX33M/TtA= X-Received: by 2002:a1c:cc15:: with SMTP id h21mr6003355wmb.85.1554978885091; Thu, 11 Apr 2019 03:34:45 -0700 (PDT) MIME-Version: 1.0 References: <20190411101951.30223-1-megous@megous.com> <20190411101951.30223-4-megous@megous.com> In-Reply-To: <20190411101951.30223-4-megous@megous.com> From: Julian Calaby Date: Thu, 11 Apr 2019 20:34:33 +1000 Message-ID: Subject: Re: [linux-sunxi] [PATCH v3 03/11] pinctrl: sunxi: Prepare for alternative bias voltage setting methods To: megous@megous.com Cc: linux-sunxi , Maxime Ripard , Chen-Yu Tsai , Rob Herring , Linus Walleij , David Airlie , Daniel Vetter , Mark Rutland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Naveen Gupta , dri-devel , devicetree , "Mailing List, Arm" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Ondrej On Thu, Apr 11, 2019 at 8:19 PM megous via linux-sunxi wrote: > > From: Ondrej Jirman > > H6 has a different I/O voltage bias setting method than A80. Prepare > existing code for using alternative bias voltage setting methods. > > Signed-off-by: Ondrej Jirman > diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.h b/drivers/pinctrl/sunxi/pinctrl-sunxi.h > index ee15ab067b5f..4bfc8a6d9dce 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.h > +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.h > @@ -95,6 +95,13 @@ > #define PINCTRL_SUN7I_A20 BIT(7) > #define PINCTRL_SUN8I_R40 BIT(8) > > +enum sunxi_desc_bias_voltage { > + BIAS_VOLTAGE_NONE, > + /* Bias voltage configuration is done through > + * Pn_GRP_CONFIG registers, as seen on A80 SoC. */ > + BIAS_VOLTAGE_GRP_CONFIG, > +}; > + > struct sunxi_desc_function { > unsigned long variant; > const char *name; > @@ -117,7 +124,7 @@ struct sunxi_pinctrl_desc { > const unsigned int *irq_bank_map; > bool irq_read_needs_mux; > bool disable_strict_mode; > - bool has_io_bias_cfg; > + int io_bias_cfg_variant; Shouldn't we be defining this field using the enum rather than as an int? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julian Calaby Subject: Re: [PATCH v3 03/11] pinctrl: sunxi: Prepare for alternative bias voltage setting methods Date: Thu, 11 Apr 2019 20:34:33 +1000 Message-ID: References: <20190411101951.30223-1-megous@megous.com> <20190411101951.30223-4-megous@megous.com> Reply-To: julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20190411101951.30223-4-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org Cc: linux-sunxi , Maxime Ripard , Chen-Yu Tsai , Rob Herring , Linus Walleij , David Airlie , Daniel Vetter , Mark Rutland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Naveen Gupta , dri-devel , devicetree List-Id: linux-gpio@vger.kernel.org Hi Ondrej On Thu, Apr 11, 2019 at 8:19 PM megous via linux-sunxi wrote: > > From: Ondrej Jirman > > H6 has a different I/O voltage bias setting method than A80. Prepare > existing code for using alternative bias voltage setting methods. > > Signed-off-by: Ondrej Jirman > diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.h b/drivers/pinctrl/sunxi/pinctrl-sunxi.h > index ee15ab067b5f..4bfc8a6d9dce 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.h > +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.h > @@ -95,6 +95,13 @@ > #define PINCTRL_SUN7I_A20 BIT(7) > #define PINCTRL_SUN8I_R40 BIT(8) > > +enum sunxi_desc_bias_voltage { > + BIAS_VOLTAGE_NONE, > + /* Bias voltage configuration is done through > + * Pn_GRP_CONFIG registers, as seen on A80 SoC. */ > + BIAS_VOLTAGE_GRP_CONFIG, > +}; > + > struct sunxi_desc_function { > unsigned long variant; > const char *name; > @@ -117,7 +124,7 @@ struct sunxi_pinctrl_desc { > const unsigned int *irq_bank_map; > bool irq_read_needs_mux; > bool disable_strict_mode; > - bool has_io_bias_cfg; > + int io_bias_cfg_variant; Shouldn't we be defining this field using the enum rather than as an int? Thanks, -- Julian Calaby Email: julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Profile: http://www.google.com/profiles/julian.calaby/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F6C2C10F13 for ; Thu, 11 Apr 2019 10:34:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E64C22184B for ; Thu, 11 Apr 2019 10:34:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CI5Hi9Fp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RrBSE2Us" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E64C22184B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+mgsnsMl8PE822TAa1piL+i3WrUXSdVTxmEfSVVQMLE=; b=CI5Hi9FpxtEL+e m5c8BXebOYqRRoemw3xwDn9yiz+PqrCJmHijYTPKbc70Pm0ff3ti23WnWPmXlC/zFzJ009gA2IOVz xt6NYDy6UmU/h3phiP5/qZ9YZpyhyLgNjEuPl4RwCUy4Veus/dUsz8TdSJHOo0pbbpy9KEkRyU/8O ndU7BiLR9BekSKRcO6XXThPEL+aw4J0iOyyXqkUW0hPPdX8ptokdWlxSpG0aZpcH7rq1/cjfgTOGW EXGXkjXWM5uGuvtN6nZEJqYikSzvt9GKT4qkCL/rvsl7rJSLAuN3p3nhB5ZYWrsaqiExTnlKS+PVz Gm4D2bBAHDPhuU/Ns61w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEX2i-0007dY-Ex; Thu, 11 Apr 2019 10:34:52 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEX2e-0007d3-8D for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 10:34:50 +0000 Received: by mail-wm1-x343.google.com with SMTP id a184so6061768wma.2 for ; Thu, 11 Apr 2019 03:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ncP/XNUc6zUJMN6LMeRFfRBUv3h/NA4fn494LmOhRG8=; b=RrBSE2Usc9PBkc7LAnBazfFCMJYidCyT2Ku0n71GbZZKb23GkVn5nbFq2uwPbmzd7t M/Ai4p0mmF5+xoGCyQkOABae4LRxfhs0yKoDzVBSUb8i4hCnf4LQwEeer+ZSahHY+0RJ mUFwI/KaJ24zYnuLLWB4PHUU3MF0HEKnWCtgXNVUvyFLoMQnmAl25rBCxSRx5z6c/Qpe +jiinKtSMc5jEtzHYmdFniH1Ll45Na5yLFMyomvD9iTV7AmF9uFPeR0BO3fyroLcZcqX t4NMphRED/AS4doJLsvAkN56rtQ5CE5f5wfIv+UPz/2otXxaeCfPL88ku9Hf00UoIWuF yxhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ncP/XNUc6zUJMN6LMeRFfRBUv3h/NA4fn494LmOhRG8=; b=ozCTnXFg2E4OCD4rJCsQVqypQE2Tkr9orJ9FYA0dXP67vUFFOmCwzGBGUzhdnSClT6 vxNevrkLnrTrieDB4xDeYttzbU+3StlWJnvyLOjFfYg+lN9ngJ/0zEvDAplTt9j9/SSX mfntD9NGIYhgnWNENXzdLjkSuG23nHTPKTBOWxzel0JSoSRUkY1TmUWEsuz66k6Vh8Gx Xu1V1FjwpniIs6B+0ADBj2bm37brIdWWFlZHQLFqAtXNPRkk5LAth4AT4EWeAgQMMdSt cD/0crsxlMMZb6Vr15NkUTGaUr6JK3izL/Rz7QqhFxxq2QQVsA81nfHF65lDE5d/TOUi YquA== X-Gm-Message-State: APjAAAV1Or2/bbN96AppZzMMB7mUVVrxjAH9jPdUgF1OTpgBx5EeFn+e ySvZt/L3RcufP37FyT1Ze96UDi/n5eJABbexxhA= X-Google-Smtp-Source: APXvYqxxCXwjF9kqHwwwiWd9xsdmZosDQqKBbtF+8N3rXMyB3xLNbDAv48MMIJr2EQBnQEJJTjcA5IsgI+HX33M/TtA= X-Received: by 2002:a1c:cc15:: with SMTP id h21mr6003355wmb.85.1554978885091; Thu, 11 Apr 2019 03:34:45 -0700 (PDT) MIME-Version: 1.0 References: <20190411101951.30223-1-megous@megous.com> <20190411101951.30223-4-megous@megous.com> In-Reply-To: <20190411101951.30223-4-megous@megous.com> From: Julian Calaby Date: Thu, 11 Apr 2019 20:34:33 +1000 Message-ID: Subject: Re: [linux-sunxi] [PATCH v3 03/11] pinctrl: sunxi: Prepare for alternative bias voltage setting methods To: megous@megous.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_033449_160523_F8D42421 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Maxime Ripard , Chi-Hsien Lin , dri-devel , linux-sunxi , linux-stm32@st-md-mailman.stormreply.com, brcm80211-dev-list@cypress.com, David Airlie , Chen-Yu Tsai , Jose Abreu , Kalle Valo , Linus Walleij , devicetree , Arend van Spriel , Alexandre Torgue , Hante Meuleman , linux-gpio@vger.kernel.org, Rob Herring , Wright Feng , Giuseppe Cavallaro , Naveen Gupta , Franky Lin , "Mailing List, Arm" , Maxime Coquelin , brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Vetter , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ondrej On Thu, Apr 11, 2019 at 8:19 PM megous via linux-sunxi wrote: > > From: Ondrej Jirman > > H6 has a different I/O voltage bias setting method than A80. Prepare > existing code for using alternative bias voltage setting methods. > > Signed-off-by: Ondrej Jirman > diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.h b/drivers/pinctrl/sunxi/pinctrl-sunxi.h > index ee15ab067b5f..4bfc8a6d9dce 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.h > +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.h > @@ -95,6 +95,13 @@ > #define PINCTRL_SUN7I_A20 BIT(7) > #define PINCTRL_SUN8I_R40 BIT(8) > > +enum sunxi_desc_bias_voltage { > + BIAS_VOLTAGE_NONE, > + /* Bias voltage configuration is done through > + * Pn_GRP_CONFIG registers, as seen on A80 SoC. */ > + BIAS_VOLTAGE_GRP_CONFIG, > +}; > + > struct sunxi_desc_function { > unsigned long variant; > const char *name; > @@ -117,7 +124,7 @@ struct sunxi_pinctrl_desc { > const unsigned int *irq_bank_map; > bool irq_read_needs_mux; > bool disable_strict_mode; > - bool has_io_bias_cfg; > + int io_bias_cfg_variant; Shouldn't we be defining this field using the enum rather than as an int? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel