From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julian Calaby Subject: Re: Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property Date: Thu, 30 Jun 2016 19:33:36 +1000 Message-ID: References: <1467209074-15634-1-git-send-email-hdegoede@redhat.com> <871t3gdj6p.fsf@purkki.adurom.net> <87mvm36p4d.fsf@kamboji.qca.qualcomm.com> Reply-To: julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1144cfae86499305367b9082 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <87mvm36p4d.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Kalle Valo Cc: Arend van Spriel , "Mailing List, Arm" , Hans de Goede , devicetree , "John W . Linville" , Jonas Gorski , Maxime Ripard , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Chen-Yu Tsai , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arend van Spriel List-Id: devicetree@vger.kernel.org --001a1144cfae86499305367b9082 Content-Type: text/plain; charset=UTF-8 Hi Kalle, On 30 Jun 2016 6:46 p.m., "Kalle Valo" wrote: > > Arend Van Spriel writes: > > >> Since we are dealing with a per-board config-file here, which is > >> loaded from the os filesystem we really need to specify a basename > >> here as the list of possible boards is endless, so we cannot > >> have a lookup table in the driver. > > > > As Jonas mentioned the general principle of device tree is to be > > agnostic with regards to OS and/or driver as you undoubtedly know. His > > proposal seems like a usable solution for your problem while complying > > to the device tree principle. So instead of overriding the default > > brcmfmac should modify it when dt specifies the "module" property, ie: > > > > no "module" in DT: nvram filename = brcm/brcmfmac43362-sdio.txt > > "module=ap6210" in DT: nvram filename = brcm/brcmfmac43362-ap6210.txt > > Just out of curiosity, what does "ap6210" exactly mean? I get that 43362 > is the chip id, but not ap6210. Is it just an arbitrary name? Ap6210 is a chip that contains a 43362 and probably some Bluetooth chip also. Thanks, Julian Calaby -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --001a1144cfae86499305367b9082 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Kalle,

On 30 Jun 2016 6:46 p.m., "Kalle Valo" <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
>
> Arend Van Spriel <a= rend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> writes:
>
> >> Since we are dealing with a per-board config-file here, which= is
> >> loaded from the os filesystem we really need to specify a bas= ename
> >> here as the list of possible boards is endless, so we cannot<= br> > >> have a lookup table in the driver.
> >
> > As Jonas mentioned the general principle of device tree is to be<= br> > > agnostic with regards to OS and/or driver as you undoubtedly know= . His
> > proposal seems like a usable solution for your problem while comp= lying
> > to the device tree principle. So instead of overriding the defaul= t
> > brcmfmac should modify it when dt specifies the "module"= ; property, ie:
> >
> > no "module" in DT:=C2=A0 =C2=A0 nvram filename =3D brcm= /brcmfmac43362-sdio.txt
> > "module=3Dap6210" in DT:=C2=A0 =C2=A0 =C2=A0 =C2=A0 nvr= am filename =3D brcm/brcmfmac43362-ap6210.txt
>
> Just out of curiosity, what does "ap6210" exactly mean? I ge= t that 43362
> is the chip id, but not ap6210. Is it just an arbitrary name?

Ap6210 is a chip that contains a 43362 and probably some Blu= etooth chip also.

Thanks,

Julian Calaby

--
You received this message because you are subscribed to the Google Groups &= quot;linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-s= unxi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
For more options, visit http= s://groups.google.com/d/optout.
--001a1144cfae86499305367b9082--