All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julian Calaby <julian.calaby@gmail.com>
To: Ian Molton <ian@mnementh.co.uk>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 17/30] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window()
Date: Wed, 23 Aug 2017 22:36:38 +1000	[thread overview]
Message-ID: <CAGRGNgW4a5Ld0=HZ4AfBMzKoD2PvCJR=wfuAz3pxXupfbBw7YA@mail.gmail.com> (raw)
In-Reply-To: <2ef60e61-1a55-21c9-744e-39bb5dadfa66@mnementh.co.uk>

Hi Ian,

On Wed, Aug 23, 2017 at 10:27 PM, Ian Molton <ian@mnementh.co.uk> wrote:
> On 23/08/17 11:09, Julian Calaby wrote:
>> I don't think I explained my point well.
>>
>> The description of this patch implies that this method
>> brcmf_sdiod_ramrw(), now relies on the window being set elsewhere
>> before it's called.
>
> I don't think it does.

"Resetting" can mean both changing it back after setting it to
something or changing it from some other state to a known one. I read
it as the latter.

>> I'm asking why we can't move the setting of the window inside this
>> function and remove any redundant calls to
>> brcmf_sdiod_set_backplane_window() outside of it.
>
> We do call brcmf_sdiod_set_backplane_window() in this function. We just
> dont need to call it a second time to restore the original window.

Ah, I do not have the full code in front of me, so I couldn't see
that, therefore my point is invalid.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

  reply	other threads:[~2017-08-23 12:36 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 11:25 [PATCH v5] brcmfmac cleanup Ian Molton
2017-08-22 11:25 ` [PATCH 01/30] brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb() Ian Molton
2017-08-30 18:51   ` Arend van Spriel
2017-08-31 15:17     ` Ian Molton
2017-08-22 11:25 ` [PATCH 02/30] brcmfmac: Register sizes on hardware are not dependent on compiler types Ian Molton
2017-08-22 11:25 ` [PATCH 03/30] brcmfmac: Split brcmf_sdiod_regrw_helper() up Ian Molton
2017-08-30 18:59   ` Arend van Spriel
2017-08-31 15:19     ` Ian Molton
2017-08-22 11:25 ` [PATCH 04/30] brcmfmac: Clean up brcmf_sdiod_set_sbaddr_window() Ian Molton
2017-08-22 11:25 ` [PATCH 05/30] brcmfmac: Remove dead IO code Ian Molton
2017-08-22 11:25 ` [PATCH 06/30] brcmfmac: Remove bandaid for SleepCSR Ian Molton
2017-08-22 11:25 ` [PATCH 07/30] brcmfmac: Remove brcmf_sdiod_request_data() Ian Molton
2017-08-22 11:25 ` [PATCH 08/30] brcmfmac: Fix asymmetric IO functions Ian Molton
2017-08-22 11:25 ` [PATCH 09/30] brcmfmac: Remove noisy debugging Ian Molton
2017-08-22 11:25 ` [PATCH 10/30] brcmfmac: Rename bcmerror to err Ian Molton
2017-08-22 11:25 ` [PATCH 11/30] brcmfmac: Split brcmf_sdiod_buffrw function up Ian Molton
2017-08-22 11:25 ` [PATCH 12/30] brcmfmac: Whitespace fixes Ian Molton
2017-08-30 19:05   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 13/30] brcmfmac: Clarify if using braces Ian Molton
2017-08-30 19:11   ` Arend van Spriel
2017-08-31 15:35     ` Ian Molton
2017-08-22 11:25 ` [PATCH 14/30] brcmfmac: Rename / replace old IO functions with simpler ones Ian Molton
2017-08-22 11:25 ` [PATCH 15/30] brcmfmac: Tidy register definitions a little Ian Molton
2017-08-30 19:13   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 16/30] brcmfmac: Remove brcmf_sdiod_addrprep() Ian Molton
2017-08-22 11:25 ` [PATCH 17/30] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window() Ian Molton
2017-08-22 12:50   ` Julian Calaby
2017-08-22 19:38     ` Arend van Spriel
2017-08-22 19:44       ` Arend van Spriel
2017-08-23  0:03         ` Ian Molton
2017-08-23 10:09       ` Julian Calaby
2017-08-23 12:27         ` Ian Molton
2017-08-23 12:36           ` Julian Calaby [this message]
2017-08-23 21:53             ` Ian Molton
2017-08-22 11:25 ` [PATCH 18/30] brcmfmac: Cleanup offsetof() Ian Molton
2017-08-30 19:37   ` Arend van Spriel
2017-08-31 15:37     ` Ian Molton
2017-08-22 11:25 ` [PATCH 19/30] brcmfmac: Remove unused macro Ian Molton
2017-08-30 19:40   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 20/30] brcmfmac: Remove repeated calls to brcmf_chip_get_core() Ian Molton
2017-08-30 19:42   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 21/30] brcmfmac: Remove {r,w}_sdreg32 Ian Molton
2017-09-05 21:20   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 22/30] brcmfmac: Rename buscore->core for consistency Ian Molton
2017-09-05 21:20   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 23/30] brcmfmac: stabilise the value of ->sbwad in use for some xfer routines Ian Molton
2017-09-05 21:21   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 24/30] brcmfmac: Correctly handle accesses to SDIO func0 Ian Molton
2017-09-05 21:21   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 25/30] brcmfmac: Remove func0 from function array Ian Molton
2017-09-05 21:21   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 26/30] brcmfmac: More efficient and slightly easier to read fixup for 4339 chips Ian Molton
2017-09-05 21:21   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 27/30] brcmfmac: Replace function index with function pointer Ian Molton
2017-09-05 21:21   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 28/30] brcmfmac: Clean up interrupt macros Ian Molton
2017-09-05 21:19   ` Arend van Spriel
2017-08-22 11:25 ` [PATCH 29/30] brcmfmac: Remove array of functions Ian Molton
2017-08-22 11:25 ` [PATCH 30/30] brcmfmac: Reduce the noise from repeatedly dereferencing common pointers Ian Molton
2017-09-05 21:46   ` Arend van Spriel
2017-08-22 19:41 ` [PATCH v5] brcmfmac cleanup Arend van Spriel
2017-08-23  0:01   ` Ian Molton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGRGNgW4a5Ld0=HZ4AfBMzKoD2PvCJR=wfuAz3pxXupfbBw7YA@mail.gmail.com' \
    --to=julian.calaby@gmail.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=ian@mnementh.co.uk \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.