From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Kurtz Subject: Re: [PATCH] drm/rockchip: Cleanup dangling devm pointers Date: Mon, 19 Sep 2016 12:14:41 +0800 Message-ID: References: <1474050143-29962-1-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1474050143-29962-1-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: "open list:ARM/Rockchip SoC..." , dri-devel List-Id: linux-rockchip.vger.kernel.org SGkgU2VhbiwKCk9uIFNhdCwgU2VwIDE3LCAyMDE2IGF0IDI6MjIgQU0sIFNlYW4gUGF1bCA8c2Vh bnBhdWxAY2hyb21pdW0ub3JnPiB3cm90ZToKPgo+IEluc3RlYWQgb2YgYXNzaWduaW5nIGRldmlj ZSBtYW5hZ2VkIHJlc291cmNlcyB0byBsb2NhbCB2YXJpYWJsZXMsCj4ga2VlcCB0cmFjayBvZiB0 aGVtIGluIHRoZSB2b3Agc3RydWN0LgoKV2h5IHRoaXMgcGF0Y2g/CklzIGl0IGZpeGluZyBhbiBp c3N1ZT8KT3IsIGlzIGl0IHByZXBhcmluZyBmb3Igc29tZSBmdXR1cmUgdXNlIG9mIGFoYl9yc3Qg b3V0c2lkZSBvZiB2b3BfaW5pdGlhbD8KCkkgdGhvdWdodCB0aGF0IG9uZSBvZiB0aGUgbmljZSBm ZWF0dXJlcyBvZiB1c2luZyBkZXZtIGlzIHlvdSBkbyBub3QKbmVlZCB0byBjYXJyeSBhcm91bmQg cG9pbnRlcnMgdG8gZGV2bSBhbGxvY2F0ZWQgcmVzb3VyY2VzIGluIHRoZQpkcml2ZXIgbG9jYWwg ZGV2aWNlIHN0cnVjdC4KCi1EYW4KCj4KPiBTaWduZWQtb2ZmLWJ5OiBTZWFuIFBhdWwgPHNlYW5w YXVsQGNocm9taXVtLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tj aGlwX2RybV92b3AuYyB8IDEyICsrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNl cnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAv cm9ja2NoaXBfZHJtX3ZvcC5jCj4gaW5kZXggMTMxYWUwZi4uYmVkNzgyZSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+IEBAIC0xNDIsNiArMTQy LDcgQEAgc3RydWN0IHZvcCB7Cj4KPiAgICAgICAgIC8qIHZvcCBkY2xrIHJlc2V0ICovCj4gICAg ICAgICBzdHJ1Y3QgcmVzZXRfY29udHJvbCAqZGNsa19yc3Q7Cj4gKyAgICAgICBzdHJ1Y3QgcmVz ZXRfY29udHJvbCAqYWhiX3JzdDsKPgo+ICAgICAgICAgc3RydWN0IHZvcF93aW4gd2luW107Cj4g IH07Cj4gQEAgLTEzMzMsNyArMTMzNCw2IEBAIHN0YXRpYyBpbnQgdm9wX2luaXRpYWwoc3RydWN0 IHZvcCAqdm9wKQo+ICB7Cj4gICAgICAgICBjb25zdCBzdHJ1Y3Qgdm9wX2RhdGEgKnZvcF9kYXRh ID0gdm9wLT5kYXRhOwo+ICAgICAgICAgY29uc3Qgc3RydWN0IHZvcF9yZWdfZGF0YSAqaW5pdF90 YWJsZSA9IHZvcF9kYXRhLT5pbml0X3RhYmxlOwo+IC0gICAgICAgc3RydWN0IHJlc2V0X2NvbnRy b2wgKmFoYl9yc3Q7Cj4gICAgICAgICBpbnQgaSwgcmV0Owo+Cj4gICAgICAgICB2b3AtPmhjbGsg PSBkZXZtX2Nsa19nZXQodm9wLT5kZXYsICJoY2xrX3ZvcCIpOwo+IEBAIC0xMzc0LDE1ICsxMzc0 LDE1IEBAIHN0YXRpYyBpbnQgdm9wX2luaXRpYWwoc3RydWN0IHZvcCAqdm9wKQo+ICAgICAgICAg LyoKPiAgICAgICAgICAqIGRvIGhjbGtfcmVzZXQsIHJlc2V0IGFsbCB2b3AgcmVnaXN0ZXJzLgo+ ICAgICAgICAgICovCj4gLSAgICAgICBhaGJfcnN0ID0gZGV2bV9yZXNldF9jb250cm9sX2dldCh2 b3AtPmRldiwgImFoYiIpOwo+IC0gICAgICAgaWYgKElTX0VSUihhaGJfcnN0KSkgewo+ICsgICAg ICAgdm9wLT5haGJfcnN0ID0gZGV2bV9yZXNldF9jb250cm9sX2dldCh2b3AtPmRldiwgImFoYiIp Owo+ICsgICAgICAgaWYgKElTX0VSUih2b3AtPmFoYl9yc3QpKSB7Cj4gICAgICAgICAgICAgICAg IGRldl9lcnIodm9wLT5kZXYsICJmYWlsZWQgdG8gZ2V0IGFoYiByZXNldFxuIik7Cj4gLSAgICAg ICAgICAgICAgIHJldCA9IFBUUl9FUlIoYWhiX3JzdCk7Cj4gKyAgICAgICAgICAgICAgIHJldCA9 IFBUUl9FUlIodm9wLT5haGJfcnN0KTsKPiAgICAgICAgICAgICAgICAgZ290byBlcnJfZGlzYWJs ZV9hY2xrOwo+ICAgICAgICAgfQo+IC0gICAgICAgcmVzZXRfY29udHJvbF9hc3NlcnQoYWhiX3Jz dCk7Cj4gKyAgICAgICByZXNldF9jb250cm9sX2Fzc2VydCh2b3AtPmFoYl9yc3QpOwo+ICAgICAg ICAgdXNsZWVwX3JhbmdlKDEwLCAyMCk7Cj4gLSAgICAgICByZXNldF9jb250cm9sX2RlYXNzZXJ0 KGFoYl9yc3QpOwo+ICsgICAgICAgcmVzZXRfY29udHJvbF9kZWFzc2VydCh2b3AtPmFoYl9yc3Qp Owo+Cj4gICAgICAgICBtZW1jcHkodm9wLT5yZWdzYmFrLCB2b3AtPnJlZ3MsIHZvcC0+bGVuKTsK Pgo+IC0tCj4gMi44LjAucmMzLjIyNi5nMzlkNDAyMAo+Cj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=