* [PATCH v2] drm/exynos: remove DRIVER_HAVE_IRQ feature
@ 2014-04-12 0:39 Joonyoung Shim
2014-04-22 16:33 ` Daniel Kurtz
0 siblings, 1 reply; 2+ messages in thread
From: Joonyoung Shim @ 2014-04-12 0:39 UTC (permalink / raw)
To: dri-devel; +Cc: kyungmin.park, sw0312.kim
Exynos drm driver cannot support DRIVER_HAVE_IRQ feature because it uses
driver specific one instead of routine of drm framework to
install/uninstall irq handler.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
Changelog from v1:
- Keep below code
drm_dev->irq_enabled = true;
drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index 2d27ba2..027e32d 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -323,8 +323,7 @@ static const struct file_operations exynos_drm_driver_fops = {
};
static struct drm_driver exynos_drm_driver = {
- .driver_features = DRIVER_HAVE_IRQ | DRIVER_MODESET |
- DRIVER_GEM | DRIVER_PRIME,
+ .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME,
.load = exynos_drm_load,
.unload = exynos_drm_unload,
.suspend = exynos_drm_suspend,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/exynos: remove DRIVER_HAVE_IRQ feature
2014-04-12 0:39 [PATCH v2] drm/exynos: remove DRIVER_HAVE_IRQ feature Joonyoung Shim
@ 2014-04-22 16:33 ` Daniel Kurtz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kurtz @ 2014-04-22 16:33 UTC (permalink / raw)
To: Joonyoung Shim; +Cc: Kyungmin Park, Seung-Woo Kim, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1333 bytes --]
On Sat, Apr 12, 2014 at 8:39 AM, Joonyoung Shim <jy0922.shim@samsung.com>wrote:
> Exynos drm driver cannot support DRIVER_HAVE_IRQ feature because it uses
> driver specific one instead of routine of drm framework to
> install/uninstall irq handler.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>
Reviewed-by: Daniel Kurtz <djkurtz@chormium.org>
> ---
> Changelog from v1:
> - Keep below code
> drm_dev->irq_enabled = true;
>
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 2d27ba2..027e32d 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -323,8 +323,7 @@ static const struct file_operations
> exynos_drm_driver_fops = {
> };
>
> static struct drm_driver exynos_drm_driver = {
> - .driver_features = DRIVER_HAVE_IRQ | DRIVER_MODESET |
> - DRIVER_GEM | DRIVER_PRIME,
> + .driver_features = DRIVER_MODESET | DRIVER_GEM |
> DRIVER_PRIME,
> .load = exynos_drm_load,
> .unload = exynos_drm_unload,
> .suspend = exynos_drm_suspend,
> --
> 1.8.1.2
>
>
[-- Attachment #1.2: Type: text/html, Size: 2239 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-22 16:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-12 0:39 [PATCH v2] drm/exynos: remove DRIVER_HAVE_IRQ feature Joonyoung Shim
2014-04-22 16:33 ` Daniel Kurtz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.