From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751847AbcKDXVj (ORCPT ); Fri, 4 Nov 2016 19:21:39 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:36959 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbcKDXVg (ORCPT ); Fri, 4 Nov 2016 19:21:36 -0400 MIME-Version: 1.0 In-Reply-To: References: <1472280263-18177-1-git-send-email-jitao.shi@mediatek.com> <1472280263-18177-2-git-send-email-jitao.shi@mediatek.com> From: Daniel Kurtz Date: Fri, 4 Nov 2016 17:21:14 -0600 X-Google-Sender-Auth: 6T0LQvYrpFHZ4gO74sg-ILTVf40 Message-ID: Subject: Re: [v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge To: Matthias Brugger Cc: Enric Balletbo Serra , Jitao Shi , David Airlie , Thierry Reding , Mark Rutland , stonea168@163.com, dri-devel , Andy Yan , Ajay Kumar , Vincent Palatin , cawa cheng , =?UTF-8?B?QmliYnkgSHNpZWggKOisnea/n+mBoCk=?= , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , Russell King , "devicetree@vger.kernel.org" , Sascha Hauer , Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Yingjoe Chen , =?UTF-8?B?RWRkaWUgSHVhbmcgKOm7g+aZuuWCkSk=?= , "linux-arm-kernel@lists.infradead.org" , Rahul Sharma , srv_heupstream , linux-kernel , Philipp Zabel , Kumar Gala , Sean Paul Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2016 at 6:23 AM, Matthias Brugger wrote: > > On 10/18/2016 04:37 PM, Enric Balletbo Serra wrote: > [...] >>> --- /dev/null >>> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > [...] >>> >>> + >>> +/* Firmware */ >>> +#define PS_FW_NAME "ps864x_fw.bin" >>> + >> >> From where I can download this firmware image? > > I suppose this FW bits have to be added to linux-firmware repository first, before this patch can be accepted. All PS8640 devices should already ship with working firmware. The firmware update procedure is only used in the unlikely event where one wants to update the bridge to a different firmware provided by Parade. Why must the lack of firmware really block landing this driver? If this is really so, can we just land the functional part of the driver first, and add the firmware update in a follow-up patch. > > Regards, > Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Kurtz Subject: Re: [v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Date: Fri, 4 Nov 2016 17:21:14 -0600 Message-ID: References: <1472280263-18177-1-git-send-email-jitao.shi@mediatek.com> <1472280263-18177-2-git-send-email-jitao.shi@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Matthias Brugger Cc: Enric Balletbo Serra , Jitao Shi , David Airlie , Thierry Reding , Mark Rutland , stonea168@163.com, dri-devel , Andy Yan , Ajay Kumar , Vincent Palatin , cawa cheng , =?UTF-8?B?QmliYnkgSHNpZWggKOisnea/n+mBoCk=?= , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , Russell King , "devicetree@vger.kernel.org" , Sascha Hauer , Pawel Moll , Ian Campbell List-Id: devicetree@vger.kernel.org On Tue, Oct 25, 2016 at 6:23 AM, Matthias Brugger wrote: > > On 10/18/2016 04:37 PM, Enric Balletbo Serra wrote: > [...] >>> --- /dev/null >>> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > [...] >>> >>> + >>> +/* Firmware */ >>> +#define PS_FW_NAME "ps864x_fw.bin" >>> + >> >> From where I can download this firmware image? > > I suppose this FW bits have to be added to linux-firmware repository first, before this patch can be accepted. All PS8640 devices should already ship with working firmware. The firmware update procedure is only used in the unlikely event where one wants to update the bridge to a different firmware provided by Parade. Why must the lack of firmware really block landing this driver? If this is really so, can we just land the functional part of the driver first, and add the firmware update in a follow-up patch. > > Regards, > Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 From: djkurtz@chromium.org (Daniel Kurtz) Date: Fri, 4 Nov 2016 17:21:14 -0600 Subject: [v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge In-Reply-To: References: <1472280263-18177-1-git-send-email-jitao.shi@mediatek.com> <1472280263-18177-2-git-send-email-jitao.shi@mediatek.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 25, 2016 at 6:23 AM, Matthias Brugger wrote: > > On 10/18/2016 04:37 PM, Enric Balletbo Serra wrote: > [...] >>> --- /dev/null >>> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > [...] >>> >>> + >>> +/* Firmware */ >>> +#define PS_FW_NAME "ps864x_fw.bin" >>> + >> >> From where I can download this firmware image? > > I suppose this FW bits have to be added to linux-firmware repository first, before this patch can be accepted. All PS8640 devices should already ship with working firmware. The firmware update procedure is only used in the unlikely event where one wants to update the bridge to a different firmware provided by Parade. Why must the lack of firmware really block landing this driver? If this is really so, can we just land the functional part of the driver first, and add the firmware update in a follow-up patch. > > Regards, > Matthias