From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rich Lane Subject: Re: [PATCH v5 1/3] vhost: Add callback and private data for vhost PMD Date: Tue, 22 Dec 2015 01:38:29 -0800 Message-ID: References: <1447392031-24970-3-git-send-email-mukawa@igel.co.jp> <1448355603-21275-1-git-send-email-mukawa@igel.co.jp> <1448355603-21275-2-git-send-email-mukawa@igel.co.jp> <20151217114223.GC29571@yliu-dev.sh.intel.com> <56737A5E.1030803@igel.co.jp> <20151218041536.GI29571@yliu-dev.sh.intel.com> <56738B5C.1030206@igel.co.jp> <20151222034158.GH18863@yliu-dev.sh.intel.com> <20151222054710.GK18863@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com To: Yuanhan Liu Return-path: Received: from mail-vk0-f46.google.com (mail-vk0-f46.google.com [209.85.213.46]) by dpdk.org (Postfix) with ESMTP id 5A213A6A for ; Tue, 22 Dec 2015 10:38:30 +0100 (CET) Received: by mail-vk0-f46.google.com with SMTP id a189so115007062vkh.2 for ; Tue, 22 Dec 2015 01:38:30 -0800 (PST) In-Reply-To: <20151222054710.GK18863@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Dec 21, 2015 at 9:47 PM, Yuanhan Liu wrote: > On Mon, Dec 21, 2015 at 08:47:28PM -0800, Rich Lane wrote: > > The queue state change callback is the one new API that needs to be > > added because > > normal NICs don't have this behavior. > > Again I'd ask, will vring_state_changed() be enough, when above issues > are resolved: vring_state_changed() will be invoked at new_device()/ > destroy_device(), and of course, ethtool change? It would be sufficient. It is not a great API though, because it requires the application to do the conversion from struct virtio_net to a DPDK port number, and from a virtqueue index to a DPDK queue id and direction. Also, the current implementation often makes this callback when the vring state has not actually changed (enabled -> enabled and disabled -> disabled). If you're asking about using vring_state_changed() _instead_ of the link status event and rte_eth_dev_socket_id(), then yes, it still works. I'd only consider that a stopgap until the real ethdev APIs are implemented. I'd suggest to add RTE_ETH_EVENT_QUEUE_STATE_CHANGE rather than create another callback registration API. Perhaps we could merge the basic PMD which I think is pretty solid and then continue the API discussion with patches to it.