From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rich Lane <rich.lane@bigswitch.com>
Subject: Re: [PATCH v3 2/2] vhost: Add VHOST PMD
Date: Thu, 12 Nov 2015 20:03:43 -0800
Message-ID: <CAGSMBPOSrdSgdTFX62dsq4f7ZP0FFCRvoySZH0M6NhZi9oUBzQ@mail.gmail.com>
References: <1446436737-25606-2-git-send-email-mukawa@igel.co.jp>
 <1447046221-20811-1-git-send-email-mukawa@igel.co.jp>
 <1447046221-20811-3-git-send-email-mukawa@igel.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-yk0-f179.google.com (mail-yk0-f179.google.com
 [209.85.160.179]) by dpdk.org (Postfix) with ESMTP id 4921091D7
 for <dev@dpdk.org>; Fri, 13 Nov 2015 05:03:44 +0100 (CET)
Received: by ykfs79 with SMTP id s79so128919959ykf.1
 for <dev@dpdk.org>; Thu, 12 Nov 2015 20:03:43 -0800 (PST)
In-Reply-To: <1447046221-20811-3-git-send-email-mukawa@igel.co.jp>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

>
> +       if (rte_kvargs_count(kvlist, ETH_VHOST_IFACE_ARG) == 1) {
> +               ret = rte_kvargs_process(kvlist, ETH_VHOST_IFACE_ARG,
> +                                        &open_iface, &iface_name);
> +               if (ret < 0)
> +                       goto out_free;
> +       }
>

I noticed that the strdup in eth_dev_vhost_create crashes if you don't pass
the iface option, so this should probably return an error if the option
doesn't exist.