Re: [Feature discussion] Allow overriding of network-specific options globally

Re: [Feature discussion] Allow overriding of network-specific options globally

[Rhys Perry]

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

On Fri, 14 Jan 2022 at 18:55, Denis Kenzior <denkenz(a)gmail.com> wrote:
> > I am proposing the ability to override network specific options (ones
> > documented in `iwd.network`) globally. This would be implemented by
>
> I suspect only a subset of these options would make sense to be global.  DNS
> would be one of them.

Yeah, that's fair. I kinda thought that'd be the case, but wasn't sure
what the people over here's thoughts would be

> I'm not sure that adding yet another config file is worthwhile.  We already have
> some network configuration related options in main.conf.  MulticastDNS for
> example.  So I'd start by adding global DNS preference settings there first.

Right- My programming skills aren't the best, but I'll give it a go
:). Where do you think the DNS option should go in the main config
file? Something like `DNSv4` and `DNSv6` in the `Network` section, or
should the `IPv4` and `IPv6` sections be added, each with their own
respective `DNS` entries?

Also, apologies to Denis for accidentally doing a reply instead of a
reply-all initially, I don't participate in mailing lists that often.

Rhys

Re: [Feature discussion] Allow overriding of network-specific options globally

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

Hi Rhys,

> Right- My programming skills aren't the best, but I'll give it a go
> :). Where do you think the DNS option should go in the main config
> file? Something like `DNSv4` and `DNSv6` in the `Network` section, or
> should the `IPv4` and `IPv6` sections be added, each with their own
> respective `DNS` entries?

I would just mirror the way the network profiles do this.  So exact same 
structure as in src/iwd.network.rst.

> 
> Also, apologies to Denis for accidentally doing a reply instead of a
> reply-all initially, I don't participate in mailing lists that often.
> 

No worries.

Regards,
-Denis

Re: [Feature discussion] Allow overriding of network-specific options globally

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

Hi Rhys,

On 1/14/22 04:14, Rhys Perry wrote:
> `Hi,
> 
> I use IWD as the network manager on my laptop, also utilising it's
> inbuilt DHCP client. One of the things that gets on my nerves about
> this is that there is no way to override the DNS server globally, only
> per-network. This becomes rather annoying on a device like a laptop,
> where I am regularly connecting to new networks.
> 

Sure, I can see how this would be useful.

> I am proposing the ability to override network specific options (ones
> documented in `iwd.network`) globally. This would be implemented by

I suspect only a subset of these options would make sense to be global.  DNS 
would be one of them.

> having another configuration file (something like
> `/etc/iwd/network-overrides.conf`), where any network-specific options
> can be set, but globally. Of course, it is still useful to be able to
> set per-network options, so any options in the per-network configs
> (`/var/lib/iwd/*`) should take precedence over the global options.

I'm not sure that adding yet another config file is worthwhile.  We already have 
some network configuration related options in main.conf.  MulticastDNS for 
example.  So I'd start by adding global DNS preference settings there first.

Regards,
-Denis

[Feature discussion] Allow overriding of network-specific options globally

[Rhys Perry]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

`Hi,

I use IWD as the network manager on my laptop, also utilising it's
inbuilt DHCP client. One of the things that gets on my nerves about
this is that there is no way to override the DNS server globally, only
per-network. This becomes rather annoying on a device like a laptop,
where I am regularly connecting to new networks.

I am proposing the ability to override network specific options (ones
documented in `iwd.network`) globally. This would be implemented by
having another configuration file (something like
`/etc/iwd/network-overrides.conf`), where any network-specific options
can be set, but globally. Of course, it is still useful to be able to
set per-network options, so any options in the per-network configs
(`/var/lib/iwd/*`) should take precedence over the global options.

What do you think of this proposal? Admittedly, I am not familiar with
how IWD parses configs, nor the codebase in general, and my
programming skills do have a lot to be desired, so maybe I am
overlooking something.

Rhys Perry