From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D87CDC33CA2 for ; Fri, 10 Jan 2020 12:02:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93A382072A for ; Fri, 10 Jan 2020 12:02:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kiqlOcq5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93A382072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipszJ-0001A1-UC for qemu-devel@archiver.kernel.org; Fri, 10 Jan 2020 07:02:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58388) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipsyQ-0000aY-Dq for qemu-devel@nongnu.org; Fri, 10 Jan 2020 07:01:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipsyO-00038v-Cb for qemu-devel@nongnu.org; Fri, 10 Jan 2020 07:01:06 -0500 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]:41138) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipsyO-00030t-1O for qemu-devel@nongnu.org; Fri, 10 Jan 2020 07:01:04 -0500 Received: by mail-lj1-x242.google.com with SMTP id h23so1855567ljc.8 for ; Fri, 10 Jan 2020 04:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Wdimj+iD0YcLxtg03TH3PXKxgxVNr8qIv/jOIsRftDY=; b=kiqlOcq5ddLWQ4LG5iut2cLYnq0YQZPElyfBgAvi/JPGh/atftHox5443bYrOXqqmQ 05bhB4RWnB5s4vgTj6pgx+9WlcFIVgWJCAaxL4HNYJVKZB0xGEORDE8ZbeW3/Z5rj6fA YOVAnx5VkMBooCYUYShi/flJcNXFJ6z4o/sV0gD0+gw4P6yD9/pnEiw1y/vjnM7AtCPP uzin93BpmCg60Ao+IsXop+zlxljRcsSlu1oe0xSui10r/2KQ/W+Kx7de0WxLZKnjmGBK RMnfwnbXkTXvU7H0KQYD9m6oClGVGPRRHEjgkMCLmPWojsCifGPPG3i5IEcpLUBpDUr0 5e1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Wdimj+iD0YcLxtg03TH3PXKxgxVNr8qIv/jOIsRftDY=; b=Z3TLH/r7MQZni9YbZFt7avgx9uuA9QMxypYPYNNa9OqDGKMkDdAt/b1r+cSNAFsqyi p0bwkqXljFacQv6DIF1YqsN+c+pIL+Edv/OTiDOHmMcyOxKcID4a8k+eS71NwP0Di6i4 uq+6yQYDE8IUsZp75lFwe2xiqyDj9eo/X/8TvvVkkL7jRUawM4W6B0tny+L8oth2tm0A qduhswuD5niCNcMzY33Jh28xAsQCAzhaRTCUXKcWywr98XLokz18AvG6ofC42FWJJ+M0 MAZbL7aRNpqo3r/HTx1mEK+ov2HDMQVeCyqCJGRA5L+kdHFWUq4o/tGXAOqtvvO4I/FO Sdfg== X-Gm-Message-State: APjAAAWoqMzf1uMhF8F0rOQm62vLbWzSeXQgtOUdNzahLMQJidioSdI9 cp/zfStAtuwDITiaTI4vXx8sPui1K6TLbEcBa2A= X-Google-Smtp-Source: APXvYqySgrckWiDZX8fRT1IHytucs0QyYFVnmc2dRT6eGdjiFyY6WTnrBCZRfLxnl6FbCWm9SUjjQHs2Nn7DSMO7z3E= X-Received: by 2002:a2e:a404:: with SMTP id p4mr2372265ljn.234.1578657662093; Fri, 10 Jan 2020 04:01:02 -0800 (PST) MIME-Version: 1.0 References: <20200108161618.221116-1-afscoelho@gmail.com> <20200109054233-mutt-send-email-mst@kernel.org> <20200109073529-mutt-send-email-mst@kernel.org> <20200109170640.4c3fa148@bahia.lan> <20200110095502.4635f34c@bahia.lan> In-Reply-To: <20200110095502.4635f34c@bahia.lan> From: =?UTF-8?B?QW5kcsOpIFNpbHZh?= Date: Fri, 10 Jan 2020 09:00:50 -0300 Message-ID: Subject: Re: [PATCH] virtio: Prevent double swap due to target pre 1.0 VirtIO To: Greg Kurz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::242 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > What are the symptoms without your patch ? What's the QEMU version ? If using virtio for networking, guest vtnet0 interface appears with 'status: no carrier'. Applying the patch the interface appears as 'status: active' and works normally. I tested with branches stable-4.1 and master. > Do you hit the issue with upstream QEMU ? No, I tested it with master and got the same fw as you, 'FW Version =3D git-9546892a80d5a4c7' and had no problems... Not sure if there are some parameter to quemu that may your side work, but I'm invoking qemu like this: $ sudo ./qemu/build/release/ppc64-softmmu/qemu-system-ppc64 -drive file=3Ddisc1.qcow2,if=3Dscsi,format=3Dqcow2 -enable-kvm -machine pseries,accel=3Dkvm,cap-cfpc=3Dbroken,cap-sbbc=3Dbroken,cap-ibs=3Dbroken,ca= p-hpt-max-page-size=3D16M -mem-prealloc -mem-path /dev/hugepages -vnc :74 -nographic -vga none -smp 20 -m 4G -net tap -netdev tap,id=3Dn1 -device virtio-net-pci,netdev=3Dn1 Thanks, andr=C3=A9 On Fri, Jan 10, 2020 at 5:55 AM Greg Kurz wrote: > > On Thu, 9 Jan 2020 18:18:57 -0300 > Andr=C3=A9 Silva wrote: > > > Hi Greg, > > > > Hi Andr=C3=A9, > > > Thanks for the commit info. > > But I'm testing in this scenario, that is, a ppc64le host with a ppc64 > > BE guest, and without my patch I can't get virtio to work. The patch > > What are the symptoms without your patch ? What's the QEMU version ? > > > makes virtio 0.95 (legacy) net, scsi, blk work. I don't get the > > firmware error. I also tested with a ppc64le guest and had no problems > > either. Maybe we have different firmware versions? > > > > My firmware output: > > > > SLOF ******************************************************************= **** > > QEMU Starting > > Build Date =3D Jul 3 2019 12:26:14 > > FW Version =3D git-ba1ab360eebe6338 > > I'm using the latest SLOF from the QEMU tree (pc-bios/slof.bin): > > SLOF ********************************************************************= ** > QEMU Starting > Build Date =3D Dec 17 2019 11:31:13 > FW Version =3D git-9546892a80d5a4c7 > > Do you hit the issue with upstream QEMU ? > > > Press "s" to enter Open Firmware. > > > > Populating /vdevice methods > > Populating /vdevice/vty@71000000 > > Populating /vdevice/nvram@71000001 > > Populating /vdevice/v-scsi@71000002 > > SCSI: Looking for devices > > 8200000000000000 CD-ROM : "QEMU QEMU CD-ROM 2.5+" > > Populating /pci@800000020000000 > > 00 0000 (D) : 1af4 1000 virtio [ net ] > > 00 0800 (D) : 1af4 1001 virtio [ block ] > > No NVRAM common partition, re-initializing... > > Scanning USB > > Using default console: /vdevice/vty@71000000 > > > > Welcome to Open Firmware > > > > Copyright (c) 2004, 2017 IBM Corporation All rights reserved. > > This program and the accompanying materials are made available > > under the terms of the BSD License available at > > http://www.opensource.org/licenses/bsd-license.php > > > > > > Trying to load: from: /pci@800000020000000/scsi@1 ... Successfully l= oaded > > > > >> FreeBSD/powerpc Open Firmware boot block > > Boot path: /pci@800000020000000/scsi@1 > > Boot loader: /boot/loader > > Boot volume: /pci@800000020000000/scsi@1:2 > > Consoles: Open Firmware console > > > > FreeBSD/powerpc64 Open Firmware loader, Revision 0.1 > > (Mon Nov 11 22:33:43 -02 2019 jenkins@FreeBSD_x86) > > Memory: 4194304KB > > Booted from: /pci@800000020000000/scsi@1 > > > > Loading /boot/defaults/loader.conf > > /boot/kernel/kernel data=3D0x129f658+0x4aaa88 syms=3D[0x8+0x105120+0x8+= 0x125429] > > ... > > > > Until now, I was able to test the patch and see virtio working on the > > following systems: > > > > Qemu Host Guest Guest VirtI= O > > -------- ---------------- ------------------------------- -----------= --- > > master Ubuntu ppc64le FreeBSD 13.0-current ppc64 BE legacy > > master Ubuntu ppc64le debian 4.19.0-6-powerpc64le modern > > master Ubuntu ppc64le debian 4.19.0-6-powerpc64le legacy > > master arch x86_64 FreeBSD 13.0-current ppc64 BE legacy > > > > Thanks, > > andr=C3=A9 > > > > On Thu, Jan 9, 2020 at 1:06 PM Greg Kurz wrote: > > > > > > On Thu, 9 Jan 2020 07:39:17 -0500 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu, Jan 09, 2020 at 09:25:42AM -0300, Andr=C3=A9 Silva wrote: > > > > > Hi Michael! > > > > > Thanks for reviewing the patch! > > > > > > > > > > > we always get LE values from memory subsystem, > > > > > > not target endian values: > > > > > > > > > > I see. So do you think the patch is correct in eliminating the ex= tra > > > > > swap (as virtio_config_readw for example already makes a swap)? > > > > > > > > > > Thanks, > > > > > andr=C3=A9 > > > > > > > > I don't think it is, I think we do need an extra swap > > > > in some cases. It's possible that some cross-endian > > > > setups are broken now, if so pls include testing > > > > result not just theoretical analysis. > > > > > > > > > > I confirm that we must keep the extra swap otherwise > > > read/write in cross-endian setups will have wrong > > > endian. Please read this commit for a more detailed > > > explanation: > > > > > > commit 82afa58641b0e67abbaf4da6c325ebd7c2513262 > > > Author: Benjamin Herrenschmidt > > > Date: Tue Jan 10 01:35:11 2012 +0000 > > > > > > virtio-pci: Fix endianness of virtio config > > > > > > https://git.qemu.org/?p=3Dqemu.git;a=3Dcommitdiff;h=3D82afa58641b0e67= abbaf4da6c325ebd7c2513262 > > > > > > This is especially critical on ppc64 since _all_ hosts are now LE > > > but the first piece of code in the guest that is likely to drive > > > the device is the SLOF firmware which is BE. > > > > > > This is what we get with this patch when trying to run a pseries gues= t on a > > > ppc64le host: > > > > > > Trying to load: from: /pci@800000020000000/scsi@0 ... virtioblk_tran= sfer: Access beyond end of device! > > > > > > Cheers, > > > > > > -- > > > Greg > > > > > > > > On Thu, Jan 9, 2020 at 7:50 AM Michael S. Tsirkin wrote: > > > > > > > > > > > > On Wed, Jan 08, 2020 at 01:16:18PM -0300, Andre Silva wrote: > > > > > > > Remove the bswap function calls after reading and before writ= ing > > > > > > > memory bytes in virtio_pci_config_read and virtio_pci_config_= write > > > > > > > because they are reverting back an already swapped bytes. > > > > > > > > > > > > > > Consider the table below in the context of virtio_pci_config_= read > > > > > > > function. > > > > > > > > > > > > > > Host Target virtio-config-read[wl] > > > > > > > swap? virtio-is-big-endian? = extra bswap? Should be Final result Final result ok? > > > > > > > ----- ------- ------------------------ ----------------------= - -------------- ----------- -------------- ------------------ > > > > > > > LE BE s(x) true = s(s(x)) s(x) x No > > > > > > > LE LE x false = - x x Yes > > > > > > > BE LE s(x) false = - s(x) s(x) Yes > > > > > > > BE BE x true = s(x) x s(x) No > > > > > > > > > > > > we always get LE values from memory subsystem, > > > > > > not target endian values: > > > > > > > > > > > > static const MemoryRegionOps virtio_pci_config_ops =3D { > > > > > > .read =3D virtio_pci_config_read, > > > > > > .write =3D virtio_pci_config_write, > > > > > > .impl =3D { > > > > > > .min_access_size =3D 1, > > > > > > .max_access_size =3D 4, > > > > > > }, > > > > > > .endianness =3D DEVICE_LITTLE_ENDIAN, > > > > > > }; > > > > > > > > > > > > > > > > > > This triggers another swap in address_space_ldl_internal > > > > > > (memory_ldst.inc.c). > > > > > > > > > > > > > > > > > > > In table above, when target is big endian and VirtIO is pre 1= .0, > > > > > > > function virtio_is_big_endian would return true and the extra > > > > > > > swap would be executed, reverting the previous swap made by > > > > > > > virtio_config_read[wl]. > > > > > > > > > > > > > > The 's(x)' means that a swap function was applied at > > > > > > > address x. 'LE' is little endian and 'BE' is big endian. The > > > > > > > 'Final result' column is the returned value from > > > > > > > virtio_pci_config_read, considering a target Virtio pre 1.0. > > > > > > > 'x' means that target's value was not swapped in Qemu, 's(x)'= means > > > > > > > that Qemu will use a swapped value. > > > > > > > > > > > > > > If we remove the extra swap made in virtio_pci_config_read we= will > > > > > > > have the correct result in any host/target combination, both = for > > > > > > > VirtIO pre 1.0 or later versions. > > > > > > > > > > > > > > The same reasoning applies to virtio_pci_config_write. > > > > > > > > > > > > > > Signed-off-by: Andre Silva > > > > > > > --- > > > > > > > hw/virtio/virtio-pci.c | 12 ------------ > > > > > > > 1 file changed, 12 deletions(-) > > > > > > > > > > > > > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > > > > > > > index c6b47a9c73..4ba9e847f3 100644 > > > > > > > --- a/hw/virtio/virtio-pci.c > > > > > > > +++ b/hw/virtio/virtio-pci.c > > > > > > > @@ -431,15 +431,9 @@ static uint64_t virtio_pci_config_read(v= oid *opaque, hwaddr addr, > > > > > > > break; > > > > > > > case 2: > > > > > > > val =3D virtio_config_readw(vdev, addr); > > > > > > > - if (virtio_is_big_endian(vdev)) { > > > > > > > - val =3D bswap16(val); > > > > > > > - } > > > > > > > break; > > > > > > > case 4: > > > > > > > val =3D virtio_config_readl(vdev, addr); > > > > > > > - if (virtio_is_big_endian(vdev)) { > > > > > > > - val =3D bswap32(val); > > > > > > > - } > > > > > > > break; > > > > > > > } > > > > > > > return val; > > > > > > > @@ -465,15 +459,9 @@ static void virtio_pci_config_write(void= *opaque, hwaddr addr, > > > > > > > virtio_config_writeb(vdev, addr, val); > > > > > > > break; > > > > > > > case 2: > > > > > > > - if (virtio_is_big_endian(vdev)) { > > > > > > > - val =3D bswap16(val); > > > > > > > - } > > > > > > > virtio_config_writew(vdev, addr, val); > > > > > > > break; > > > > > > > case 4: > > > > > > > - if (virtio_is_big_endian(vdev)) { > > > > > > > - val =3D bswap32(val); > > > > > > > - } > > > > > > > virtio_config_writel(vdev, addr, val); > > > > > > > break; > > > > > > > } > > > > > > > -- > > > > > > > 2.24.1 > > > > > > > > > > > > > > > > > >