From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161617AbaDPOjf (ORCPT ); Wed, 16 Apr 2014 10:39:35 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:33330 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161446AbaDPOjc (ORCPT ); Wed, 16 Apr 2014 10:39:32 -0400 MIME-Version: 1.0 In-Reply-To: <534E9517.2040409@samsung.com> References: <1397527192-21988-1-git-send-email-cw00.choi@samsung.com> <1397527192-21988-7-git-send-email-cw00.choi@samsung.com> <534E9517.2040409@samsung.com> Date: Wed, 16 Apr 2014 23:39:32 +0900 Message-ID: Subject: Re: [PATCHv2 6/8] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 From: Chanwoo Choi To: Tomasz Figa Cc: Chanwoo Choi , linux-kernel , Russell King - ARM Linux , ben-linux@fluff.org, Kukjin Kim , thomas.abraham@linaro.org, Kyungmin Park , sw0312.kim@samsung.com, hyunhee.kim@samsung.com, yj44.cho@samsung.com, chanho61.park@samsung.com, Arnd Bergmann , Olof Johansson , marc.zyngier@arm.com, linux-samsung-soc , linux-arm-kernel , devicetree Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomasz, On Wed, Apr 16, 2014 at 11:35 PM, Tomasz Figa wrote: > Hi Chanwoo, > > > On 15.04.2014 03:59, Chanwoo Choi wrote: >> >> This patch decide proper lowpower mode of either a15 or a9 according to >> own ID >> from Main ID register. >> >> Signed-off-by: Chanwoo Choi >> Acked-by: Kyungmin Park >> --- >> arch/arm/mach-exynos/hotplug.c | 16 +++++++++++----- >> 1 file changed, 11 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/hotplug.c >> b/arch/arm/mach-exynos/hotplug.c >> index 5eead53..99e54e0 100644 >> --- a/arch/arm/mach-exynos/hotplug.c >> +++ b/arch/arm/mach-exynos/hotplug.c >> @@ -135,16 +135,22 @@ void __ref exynos_cpu_die(unsigned int cpu) >> int primary_part = 0; >> >> /* >> - * we're ready for shutdown now, so do it. >> - * Exynos4 is A9 based while Exynos5 is A15; check the CPU part >> + * we're ready for shutdown now, so do it. Exynos4 is A9 based >> + * while Exynos5 is A15/Exynos3 is A7; check the CPU part >> * number by reading the Main ID register and then perform the >> * appropriate sequence for entering low power. > > > If changing this comment anyway, I'd suggest removing particular SoC series > from it and also correct writing style. My suggestion is: OK, I'll fix it. Best regards, Chanwoo Choi > > /* > * Prepare the CPU for shutting down. The required sequence of > * operations depends on core type. CPUID part number can be used to > * determine the right way. > */ > > Best regards, > Tomasz > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: cwchoi00@gmail.com (Chanwoo Choi) Date: Wed, 16 Apr 2014 23:39:32 +0900 Subject: [PATCHv2 6/8] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 In-Reply-To: <534E9517.2040409@samsung.com> References: <1397527192-21988-1-git-send-email-cw00.choi@samsung.com> <1397527192-21988-7-git-send-email-cw00.choi@samsung.com> <534E9517.2040409@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tomasz, On Wed, Apr 16, 2014 at 11:35 PM, Tomasz Figa wrote: > Hi Chanwoo, > > > On 15.04.2014 03:59, Chanwoo Choi wrote: >> >> This patch decide proper lowpower mode of either a15 or a9 according to >> own ID >> from Main ID register. >> >> Signed-off-by: Chanwoo Choi >> Acked-by: Kyungmin Park >> --- >> arch/arm/mach-exynos/hotplug.c | 16 +++++++++++----- >> 1 file changed, 11 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/hotplug.c >> b/arch/arm/mach-exynos/hotplug.c >> index 5eead53..99e54e0 100644 >> --- a/arch/arm/mach-exynos/hotplug.c >> +++ b/arch/arm/mach-exynos/hotplug.c >> @@ -135,16 +135,22 @@ void __ref exynos_cpu_die(unsigned int cpu) >> int primary_part = 0; >> >> /* >> - * we're ready for shutdown now, so do it. >> - * Exynos4 is A9 based while Exynos5 is A15; check the CPU part >> + * we're ready for shutdown now, so do it. Exynos4 is A9 based >> + * while Exynos5 is A15/Exynos3 is A7; check the CPU part >> * number by reading the Main ID register and then perform the >> * appropriate sequence for entering low power. > > > If changing this comment anyway, I'd suggest removing particular SoC series > from it and also correct writing style. My suggestion is: OK, I'll fix it. Best regards, Chanwoo Choi > > /* > * Prepare the CPU for shutting down. The required sequence of > * operations depends on core type. CPUID part number can be used to > * determine the right way. > */ > > Best regards, > Tomasz > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html