From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A818DC433DF for ; Fri, 3 Jul 2020 20:34:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81E0820782 for ; Fri, 3 Jul 2020 20:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593808498; bh=AH0GTCbSop8eZujnaf/Z85LbZvsVu310x9dmthGY7qo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=mMyhPI3LlvUcl6wfnMTs7z6INqQLgkYptsuMZHciYzfzWZUbZ+aHBgaVUn7fpifEB nN7bFsfK9F8NOPdE5or82n2mqjHke+GELOiSfTojykjtjyPwmkzKOsAo0O4zdf1wvr NzagUrdIUf4VGSs41SKIuhNU291q5oB3GjnnTcyA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726767AbgGCUev (ORCPT ); Fri, 3 Jul 2020 16:34:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:40630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbgGCUeu (ORCPT ); Fri, 3 Jul 2020 16:34:50 -0400 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA09B208B8; Fri, 3 Jul 2020 20:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593808490; bh=AH0GTCbSop8eZujnaf/Z85LbZvsVu310x9dmthGY7qo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=BFUne6XCpVnoyuqdrs3695kjpBOdZDUJ6qdF/ujE3reI8k51V2jxyLOZHtrVSH6NE HCzS8dlXg8SxwgXOHxM889bNowfBijmo7DGGxDxEZgASlaJuI7nQ446I+kOoyfDIWk O6rM8YRYO+CSSymMjoDVm5bN03/DwHRpUzfG77Bg= Received: by mail-lj1-f172.google.com with SMTP id f5so22503272ljj.10; Fri, 03 Jul 2020 13:34:49 -0700 (PDT) X-Gm-Message-State: AOAM533G/p/QIL90dAuvzMwW4ug2D5vFtkPh4nE2ayjeS5dG6qf9u09V 9z8BndmUCeha6Uc2O72HsLDf1scGy3Czjy6GgY8= X-Google-Smtp-Source: ABdhPJzJ1IRgn3b/usnN9r+/avS3HfXMB23+RrbrqwAzGjub3iwXzVKFekPat3URzO7ASd63Wf+D4X6k3nsjOOsLpuc= X-Received: by 2002:a2e:88c6:: with SMTP id a6mr16546043ljk.27.1593808488121; Fri, 03 Jul 2020 13:34:48 -0700 (PDT) MIME-Version: 1.0 References: <20200703100810.12304-1-cw00.choi@samsung.com> <20200703100810.12304-3-cw00.choi@samsung.com> <6027cf29-ea6f-0a27-3e39-a80c24b80bb8@gmail.com> In-Reply-To: <6027cf29-ea6f-0a27-3e39-a80c24b80bb8@gmail.com> From: Chanwoo Choi Date: Sat, 4 Jul 2020 05:34:11 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features To: Dmitry Osipenko Cc: Chanwoo Choi , Linux PM list , linux-kernel , Leonard Crestez , lukasz.luba@arm.com, Enric Balletbo i Serra , Lin Huang , Thierry Reding , jonathanh@nvidia.com, Abel Vesa , MyungJoo Ham , Kyungmin Park Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Fri, Jul 3, 2020 at 7:46 PM Dmitry Osipenko wrote: > > 03.07.2020 13:08, Chanwoo Choi =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra3= 0-devfreq.c > > index e94a27804c20..620ecd250d7c 100644 > > --- a/drivers/devfreq/tegra30-devfreq.c > > +++ b/drivers/devfreq/tegra30-devfreq.c > > @@ -765,10 +765,12 @@ static int tegra_governor_event_handler(struct de= vfreq *devfreq, > > > > static struct devfreq_governor tegra_devfreq_governor =3D { > > .name =3D "tegra_actmon", > > + .flag =3D DEVFREQ_GOV_FLAG_ATTR_COMMON > > + | DEVFREQ_GOV_FLAG_ATTR_POLLING_INTERVAL, > > Hello, Chanwoo! > > There is a typo here, it should be ".attr =3D ". Ah. Sorry. After changed the name, I didn't test COMPILE_TEST. > > > + .flag =3D DEVFREQ_GOV_FLAG_FLAG_IMMUTABLE, > > + | DEVFREQ_GOV_FLAG_FLAG_IRQ_DRIVEN, > > There is a typo here too FLAG_FLAG ^ Thanks. --=20 Best Regards, Chanwoo Choi Samsung Electronics