From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FREEMAIL_REPLYTO_END_DIGIT,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80EAAC433E6 for ; Tue, 5 Jan 2021 04:15:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 404E6227C3 for ; Tue, 5 Jan 2021 04:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728240AbhAEEOz (ORCPT ); Mon, 4 Jan 2021 23:14:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbhAEEOy (ORCPT ); Mon, 4 Jan 2021 23:14:54 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9453AC061574; Mon, 4 Jan 2021 20:14:13 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id o19so69649978lfo.1; Mon, 04 Jan 2021 20:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=7CEt7ox6RQz0kN+jN2Je6Gp8EPaWa97ojAZRj8xL6is=; b=L7UKc00npJs0IL02JDUDBurCBSgNMJ7czHbDQgVayzM6dCGWR7CEIoKIvy7+aK5on3 0S5EDXpjvshfBoDjf44q+N+FBx91jkWnAA2dAdz5MQa3eaur4d11dGyvwaqvj0y7Lkby iOKBe85CZLFKx/RMjzQtS+d8/UjrMtIq1ToJ55lauroSXo0eBy6wpK9CMYHEKlqJVr3A EhFPEGkCVAkZ4hASfjxvhOKIu7pXSrTYfDxacg3xbr3VAFBLHSafSfvYFCjvANM6suJx 8eL+J6xu7XU6FMQHLnE/jqobXnnkXyeNxOHQ73VJ6yM9pVWLXxYYRYxOJPwHTXeaz+9Q s6SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=7CEt7ox6RQz0kN+jN2Je6Gp8EPaWa97ojAZRj8xL6is=; b=fNoQRJ7UehA95wbJhEc8uICPj7d8FqH6YghXUsv1rZXMpyeAwSdvRqKYUy43dGDLSb Pi38+UMHc+NPp4ynQV9E/exCOaX0r2BoTE6PW9EM4Ux7m4dWjFN1Dz1Pemra6nuwCIUw nUdxfKUT/2bT6Kxep0Kth+g46Qio/35jf5QKggNdWq8lj1per5t4/893Qy9u5Tdynj6C 8wWqWCuKwAW888b3N7JCnZqx9olFzOGHh2KuXa2vXscVIz8ktELsqy4tCFNO0O+yqumw 2iKbSijyl1+/PKNvZZ8FkQi1ktxYyE4SLc3jpvvMMnYe1lWdFWin8+Tm46KB/nPqSeJH 9bSw== X-Gm-Message-State: AOAM533AcitmmnJfp5EO3ROLCuOst3bSjs8sDkv/cXYStExlsgIeboZe C+O+ksgvm/91oGEkS0F5DLU21bBttOXZmSM6+m8= X-Google-Smtp-Source: ABdhPJz51qUgiiepOCOol+C1B9t+K4pzzTb6+kK694uGFC+1BDUaJDKdOlg7C3DMIRWrphTAbkwCZRa1MhY1aPNnUro= X-Received: by 2002:a2e:b4a7:: with SMTP id q7mr29801680ljm.391.1609820052120; Mon, 04 Jan 2021 20:14:12 -0800 (PST) MIME-Version: 1.0 References: <20210103035540.23886-1-tiny.windzz@gmail.com> In-Reply-To: <20210103035540.23886-1-tiny.windzz@gmail.com> Reply-To: cwchoi00@gmail.com From: Chanwoo Choi Date: Tue, 5 Jan 2021 13:13:35 +0900 Message-ID: Subject: Re: [PATCH 28/31] PM / devfreq: imx8m-ddrc: convert to use devm_pm_opp_* API To: Yangtao Li Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Krzysztof Kozlowski , Shawn Guo , s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , yuq825@gmail.com, David Airlie , daniel@ffwll.ch, robdclark@gmail.com, sean@poorly.run, Rob Herring , tomeu.vizoso@collabora.com, steven.price@arm.com, alyssa.rosenzweig@collabora.com, stanimir.varbanov@linaro.org, agross@kernel.org, Bjorn Andersson , mchehab@kernel.org, Lukasz Luba , adrian.hunter@intel.com, Ulf Hansson , Viresh Kumar , Nishanth Menon , Stephen Boyd , Mark Brown , Greg KH , jirislaby@kernel.org, "Rafael J. Wysocki" , jcrouse@codeaurora.org, hoegsberg@google.com, eric@anholt.net, tzimmermann@suse.de, marijn.suijten@somainline.org, gustavoars@kernel.org, emil.velikov@collabora.com, jonathan@marek.ca, akhilpo@codeaurora.org, smasetty@codeaurora.org, airlied@redhat.com, masneyb@onstation.org, kalyan_t@codeaurora.org, tanmay@codeaurora.org, ddavenport@chromium.org, jsanka@codeaurora.org, rnayak@codeaurora.org, tongtiangen@huawei.com, miaoqinglang@huawei.com, khsieh@codeaurora.org, abhinavk@codeaurora.org, chandanu@codeaurora.org, Guenter Roeck , varar@codeaurora.org, Matthias Kaehlcke , harigovi@codeaurora.org, rikard.falkeborn@gmail.com, natechancellor@gmail.com, Georgi Djakov , akashast@codeaurora.org, parashar@codeaurora.org, Doug Anderson , Linux PM list , linux-kernel , linux-samsung-soc , linux-arm-kernel , linux-tegra@vger.kernel.org, dri-devel , lima@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Sun, Jan 3, 2021 at 12:58 PM Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/devfreq/imx8m-ddrc.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c > index bc82d3653bff..9383d6e5538b 100644 > --- a/drivers/devfreq/imx8m-ddrc.c > +++ b/drivers/devfreq/imx8m-ddrc.c > @@ -370,11 +370,6 @@ static int imx8m_ddrc_check_opps(struct device *dev) > return 0; > } > > -static void imx8m_ddrc_exit(struct device *dev) > -{ > - dev_pm_opp_of_remove_table(dev); > -} > - > static int imx8m_ddrc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -419,7 +414,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) > return ret; > } > > - ret = dev_pm_opp_of_add_table(dev); > + ret = devm_pm_opp_of_add_table(dev); > if (ret < 0) { > dev_err(dev, "failed to get OPP table\n"); > return ret; > @@ -427,12 +422,11 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) > > ret = imx8m_ddrc_check_opps(dev); > if (ret < 0) > - goto err; > + return ret; > > priv->profile.polling_ms = 1000; > priv->profile.target = imx8m_ddrc_target; > priv->profile.get_dev_status = imx8m_ddrc_get_dev_status; > - priv->profile.exit = imx8m_ddrc_exit; > priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq; > priv->profile.initial_freq = clk_get_rate(priv->dram_core); > > @@ -441,13 +435,8 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) > if (IS_ERR(priv->devfreq)) { > ret = PTR_ERR(priv->devfreq); > dev_err(dev, "failed to add devfreq device: %d\n", ret); > - goto err; > } > > - return 0; > - > -err: > - dev_pm_opp_of_remove_table(dev); > return ret; devm_devfreq_add_device() doesn't return any integer value. Even if devm_devfreq_add_device() returns the right devfreq instance, the 'ret' value is not the return value of devm_devfreq_add_device(). On this patch, 'ret' value of 'return ret' is from imx8m_ddrc_check_opps(). Surely, it is well working with this modification. But, it is not code for exception handling. So, we need to remain the following codes: return 0; err: return ret; > } > > -- > 2.25.1 > -- Best Regards, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FREEMAIL_REPLYTO_END_DIGIT,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D66E7C433E0 for ; Tue, 5 Jan 2021 04:14:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9401E22583 for ; Tue, 5 Jan 2021 04:14:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9401E22583 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D05DB89F43; Tue, 5 Jan 2021 04:14:14 +0000 (UTC) Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFEAA89F3C; Tue, 5 Jan 2021 04:14:13 +0000 (UTC) Received: by mail-lf1-x133.google.com with SMTP id h205so69578599lfd.5; Mon, 04 Jan 2021 20:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=7CEt7ox6RQz0kN+jN2Je6Gp8EPaWa97ojAZRj8xL6is=; b=L7UKc00npJs0IL02JDUDBurCBSgNMJ7czHbDQgVayzM6dCGWR7CEIoKIvy7+aK5on3 0S5EDXpjvshfBoDjf44q+N+FBx91jkWnAA2dAdz5MQa3eaur4d11dGyvwaqvj0y7Lkby iOKBe85CZLFKx/RMjzQtS+d8/UjrMtIq1ToJ55lauroSXo0eBy6wpK9CMYHEKlqJVr3A EhFPEGkCVAkZ4hASfjxvhOKIu7pXSrTYfDxacg3xbr3VAFBLHSafSfvYFCjvANM6suJx 8eL+J6xu7XU6FMQHLnE/jqobXnnkXyeNxOHQ73VJ6yM9pVWLXxYYRYxOJPwHTXeaz+9Q s6SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=7CEt7ox6RQz0kN+jN2Je6Gp8EPaWa97ojAZRj8xL6is=; b=hTyRWKJuCmgH/7JdmExbt78iq3nRA7WXWgkfsvrgEMLWuBqLcfpUrWtVNH00owZlzL dsaxxuYSkycqib8I+nOYTXgMKadUcmhDT/Eg0qBrfFaLk86NXG6jvGfKoeWaf1gDY+73 1VqJFQM0rMzIcEqM/qxuurGauCw/kBc9gnge77J3mgo54rEPa3B5t6BDnvfnDVvScjIo aCdvTaoQg0BvQdERjTLvvpRXDHy1+a83W8Lx35dyoBhHfBmvdyz46TmgwurKyqDH1MPs 2b6cqzKqWvjgRVmwIdMxog0vGugLD76g2szkIn/6C+OlwgoG46X8ROZ+9zp7FoQkTfqU tbNw== X-Gm-Message-State: AOAM531olVzmEvhkXIXeW/6fdaeRb7nXXmRS5wn3xIERHG2esDSKoqW9 OOxX0bRDozpkT2E+R6MFjy/yvYdsDgHAkoGX5zo= X-Google-Smtp-Source: ABdhPJz51qUgiiepOCOol+C1B9t+K4pzzTb6+kK694uGFC+1BDUaJDKdOlg7C3DMIRWrphTAbkwCZRa1MhY1aPNnUro= X-Received: by 2002:a2e:b4a7:: with SMTP id q7mr29801680ljm.391.1609820052120; Mon, 04 Jan 2021 20:14:12 -0800 (PST) MIME-Version: 1.0 References: <20210103035540.23886-1-tiny.windzz@gmail.com> In-Reply-To: <20210103035540.23886-1-tiny.windzz@gmail.com> From: Chanwoo Choi Date: Tue, 5 Jan 2021 13:13:35 +0900 Message-ID: Subject: Re: [PATCH 28/31] PM / devfreq: imx8m-ddrc: convert to use devm_pm_opp_* API To: Yangtao Li X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: cwchoi00@gmail.com Cc: Nishanth Menon , Ulf Hansson , gustavoars@kernel.org, jirislaby@kernel.org, David Airlie , linux-mmc@vger.kernel.org, stanimir.varbanov@linaro.org, tanmay@codeaurora.org, Bjorn Andersson , natechancellor@gmail.com, Thierry Reding , tongtiangen@huawei.com, Guenter Roeck , marijn.suijten@somainline.org, Dmitry Osipenko , steven.price@arm.com, Matthias Kaehlcke , chandanu@codeaurora.org, emil.velikov@collabora.com, linux-samsung-soc , jonathan@marek.ca, harigovi@codeaurora.org, adrian.hunter@intel.com, Viresh Kumar , Linux PM list , Kyungmin Park , Krzysztof Kozlowski , Jonathan Hunter , Chanwoo Choi , MyungJoo Ham , alyssa.rosenzweig@collabora.com, linux-serial@vger.kernel.org, airlied@redhat.com, smasetty@codeaurora.org, dl-linux-imx , freedreno@lists.freedesktop.org, kernel@pengutronix.de, tzimmermann@suse.de, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, linux-spi@vger.kernel.org, linux-media@vger.kernel.org, abhinavk@codeaurora.org, akhilpo@codeaurora.org, khsieh@codeaurora.org, lima@lists.freedesktop.org, Mark Brown , rikard.falkeborn@gmail.com, kalyan_t@codeaurora.org, linux-tegra@vger.kernel.org, varar@codeaurora.org, mchehab@kernel.org, sean@poorly.run, linux-arm-kernel , Doug Anderson , akashast@codeaurora.org, rnayak@codeaurora.org, parashar@codeaurora.org, tomeu.vizoso@collabora.com, Stephen Boyd , Greg KH , dri-devel , "Rafael J. Wysocki" , agross@kernel.org, linux-kernel , miaoqinglang@huawei.com, hoegsberg@google.com, yuq825@gmail.com, ddavenport@chromium.org, masneyb@onstation.org, Shawn Guo , Georgi Djakov , Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Jan 3, 2021 at 12:58 PM Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/devfreq/imx8m-ddrc.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c > index bc82d3653bff..9383d6e5538b 100644 > --- a/drivers/devfreq/imx8m-ddrc.c > +++ b/drivers/devfreq/imx8m-ddrc.c > @@ -370,11 +370,6 @@ static int imx8m_ddrc_check_opps(struct device *dev) > return 0; > } > > -static void imx8m_ddrc_exit(struct device *dev) > -{ > - dev_pm_opp_of_remove_table(dev); > -} > - > static int imx8m_ddrc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -419,7 +414,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) > return ret; > } > > - ret = dev_pm_opp_of_add_table(dev); > + ret = devm_pm_opp_of_add_table(dev); > if (ret < 0) { > dev_err(dev, "failed to get OPP table\n"); > return ret; > @@ -427,12 +422,11 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) > > ret = imx8m_ddrc_check_opps(dev); > if (ret < 0) > - goto err; > + return ret; > > priv->profile.polling_ms = 1000; > priv->profile.target = imx8m_ddrc_target; > priv->profile.get_dev_status = imx8m_ddrc_get_dev_status; > - priv->profile.exit = imx8m_ddrc_exit; > priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq; > priv->profile.initial_freq = clk_get_rate(priv->dram_core); > > @@ -441,13 +435,8 @@ static int imx8m_ddrc_probe(struct platform_device *pdev) > if (IS_ERR(priv->devfreq)) { > ret = PTR_ERR(priv->devfreq); > dev_err(dev, "failed to add devfreq device: %d\n", ret); > - goto err; > } > > - return 0; > - > -err: > - dev_pm_opp_of_remove_table(dev); > return ret; devm_devfreq_add_device() doesn't return any integer value. Even if devm_devfreq_add_device() returns the right devfreq instance, the 'ret' value is not the return value of devm_devfreq_add_device(). On this patch, 'ret' value of 'return ret' is from imx8m_ddrc_check_opps(). Surely, it is well working with this modification. But, it is not code for exception handling. So, we need to remain the following codes: return 0; err: return ret; > } > > -- > 2.25.1 > -- Best Regards, Chanwoo Choi _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel