From: Chanwoo Choi <cwchoi00@gmail.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Mark Brown <broonie@kernel.org>,
linaro-kernel@lists.linaro.org,
linux-kernel <linux-kernel@vger.kernel.org>,
neilb@suse.com
Subject: Re: [PATCH] extcon: Add documentation for EXTCON_CHG_USB_SLOW/FAST
Date: Tue, 3 Jan 2017 21:48:09 +0900 [thread overview]
Message-ID: <CAGTfZH3x_Ts4Ef5t6oVoOojpqQcZeWguPWDdnJ-xnpwiz8Uu=w@mail.gmail.com> (raw)
In-Reply-To: <f18aa3ab2fb1182c96ecfe46551cd9c0b5787baf.1483422329.git.baolin.wang@linaro.org>
Hi Baolin,
2017-01-03 14:50 GMT+09:00 Baolin Wang <baolin.wang@linaro.org>:
> Currently there are no documentation for EXTCON_CHG_USB_SLOW/FAST
> charger connector. These names don't mean much and no guide to tell
> users how to use it, thus try to add documentation to make them clear.
>
> Suggested-by: NeilBrown <neilb@suse.com>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> include/linux/extcon.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index 0020123..ceec1f0 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -53,6 +53,10 @@
> * the USB connector, which means EXTCON_CHG_USB_SDP should always
> * appear together with EXTCON_USB. The same as ACA charger connector,
> * EXTCON_CHG_USB_ACA would normally appear with EXTCON_USB_HOST.
> + *
> + * A cable of type EXTCON_CHG_USB_SLOW can provide at least 500mA of
> + * current at 5V. A cable of type EXTCON_CHG_USB_FAST can provide at
> + * least 1A of current at 5V.
I agree the at least current value(mA) for EXTCON_CHG_USB_SLOW/FAST.
But, I'm worried that fix the 5V.
I have a plan to support the 'current' and 'voltage' property for
charger connector as following:
- EXTCON_PROP_CHG_CURRNET
- EXTCON_PROP_CHG_VOLTAGE
So, I don't like to fix the voltage for EXTCON_CHG_USB_SLOW/FAST.
How about this?
> */
> #define EXTCON_CHG_USB_SDP 5 /* Standard Downstream Port */
> #define EXTCON_CHG_USB_DCP 6 /* Dedicated Charging Port */
> --
> 1.7.9.5
>
> _______________________________________________
> linaro-kernel mailing list
> linaro-kernel@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/linaro-kernel
--
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2017-01-03 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170103055156epcas2p4dc48ae31a3d0911ec7aee1a2872e46af@epcas2p4.samsung.com>
2017-01-03 5:50 ` [PATCH] extcon: Add documentation for EXTCON_CHG_USB_SLOW/FAST Baolin Wang
2017-01-03 12:48 ` Chanwoo Choi [this message]
2017-01-03 23:01 ` NeilBrown
2017-01-06 8:50 ` Chanwoo Choi
2017-01-06 8:55 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGTfZH3x_Ts4Ef5t6oVoOojpqQcZeWguPWDdnJ-xnpwiz8Uu=w@mail.gmail.com' \
--to=cwchoi00@gmail.com \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.