From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754664Ab3GPJOI (ORCPT ); Tue, 16 Jul 2013 05:14:08 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:44165 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754151Ab3GPJOF (ORCPT ); Tue, 16 Jul 2013 05:14:05 -0400 MIME-Version: 1.0 In-Reply-To: <20130716005611.e4ccab02.akpm@linux-foundation.org> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130712075602.GA4002@gmail.com> <20130715150342.35f7620ffe0835e3e2bc37d0@linux-foundation.org> <51E472D4.5060307@zytor.com> <20130716004727.b60b2c96.akpm@linux-foundation.org> <20130716005611.e4ccab02.akpm@linux-foundation.org> From: Florian Fainelli Date: Tue, 16 Jul 2013 10:13:24 +0100 X-Google-Sender-Auth: ISTEgamjBoP9PsVVzSBDM1RHwOQ Message-ID: Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format To: Andrew Morton Cc: "H. Peter Anvin" , Ingo Molnar , Kyungsik Lee , Michal Marek , "linux-kernel@vger.kernel.org" , linux-kbuild@vger.kernel.org, x86@kernel.org, celinux-dev@lists.celinuxforum.org, "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, Andy Lee , Ingo Molnar , Thomas Gleixner , Russell King , Borislav Petkov , Yann Collet , Chanho Min Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2013/7/16 Andrew Morton : > On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton wrote: > >> On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" wrote: >> >> > On 07/15/2013 03:03 PM, Andrew Morton wrote: >> > > >> > > I don't know how to do this. Any suggestions? >> > > >> > > It has to be done at `make config' time. We'd need to probe for the >> > > presence of lz4c and then.... what? >> > > >> > > Is there any precedent for this? >> > > >> > > I don't think we can just ignore the absence of lz4c - the user has >> > > selected a config which his system cannot build. The problem lies >> > > within randconfig itself. >> > > >> > >> > We keep running over the need to be able to have kconfig run tests on >> > the build system (for toolchain support or for optional tools needed); >> > running them in the Makefiles (i.e. at Kbuild time) is simply too late. >> > >> >> Would it make sense to extend Kconfig's `depends'? >> >> depends on $(shell-command) >> >> I don't know how practical that would be to implement... > > Or, easier and faster, run some front-end script which generates > once-off Kconfig symbols. > > if [ -x /bin/lz4c ] > then > echo CONFIG_HAVE_LZ4C > fi > > then munge the output of that script into the Kconfig run and do > > depends on HAVE_LZ4C That does sound nice to avoid the build error, but will eventually make it harder to diagnose why the kernel has not been compressed with the specific compression tool, some kind of warning should also be emitted maybe? -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com ([209.85.220.43]:44165 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754151Ab3GPJOF (ORCPT ); Tue, 16 Jul 2013 05:14:05 -0400 MIME-Version: 1.0 In-Reply-To: <20130716005611.e4ccab02.akpm@linux-foundation.org> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130712075602.GA4002@gmail.com> <20130715150342.35f7620ffe0835e3e2bc37d0@linux-foundation.org> <51E472D4.5060307@zytor.com> <20130716004727.b60b2c96.akpm@linux-foundation.org> <20130716005611.e4ccab02.akpm@linux-foundation.org> From: Florian Fainelli Date: Tue, 16 Jul 2013 10:13:24 +0100 Message-ID: Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Content-Type: text/plain; charset=UTF-8 Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: "H. Peter Anvin" , Ingo Molnar , Kyungsik Lee , Michal Marek , "linux-kernel@vger.kernel.org" , linux-kbuild@vger.kernel.org, x86@kernel.org, celinux-dev@lists.celinuxforum.org, "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, Andy Lee , Ingo Molnar , Thomas Gleixner , Russell King , Borislav Petkov , Yann Collet , Chanho Min 2013/7/16 Andrew Morton : > On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton wrote: > >> On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" wrote: >> >> > On 07/15/2013 03:03 PM, Andrew Morton wrote: >> > > >> > > I don't know how to do this. Any suggestions? >> > > >> > > It has to be done at `make config' time. We'd need to probe for the >> > > presence of lz4c and then.... what? >> > > >> > > Is there any precedent for this? >> > > >> > > I don't think we can just ignore the absence of lz4c - the user has >> > > selected a config which his system cannot build. The problem lies >> > > within randconfig itself. >> > > >> > >> > We keep running over the need to be able to have kconfig run tests on >> > the build system (for toolchain support or for optional tools needed); >> > running them in the Makefiles (i.e. at Kbuild time) is simply too late. >> > >> >> Would it make sense to extend Kconfig's `depends'? >> >> depends on $(shell-command) >> >> I don't know how practical that would be to implement... > > Or, easier and faster, run some front-end script which generates > once-off Kconfig symbols. > > if [ -x /bin/lz4c ] > then > echo CONFIG_HAVE_LZ4C > fi > > then munge the output of that script into the Kconfig run and do > > depends on HAVE_LZ4C That does sound nice to avoid the build error, but will eventually make it harder to diagnose why the kernel has not been compressed with the specific compression tool, some kind of warning should also be emitted maybe? -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: florian@openwrt.org (Florian Fainelli) Date: Tue, 16 Jul 2013 10:13:24 +0100 Subject: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format In-Reply-To: <20130716005611.e4ccab02.akpm@linux-foundation.org> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130712075602.GA4002@gmail.com> <20130715150342.35f7620ffe0835e3e2bc37d0@linux-foundation.org> <51E472D4.5060307@zytor.com> <20130716004727.b60b2c96.akpm@linux-foundation.org> <20130716005611.e4ccab02.akpm@linux-foundation.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2013/7/16 Andrew Morton : > On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton wrote: > >> On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" wrote: >> >> > On 07/15/2013 03:03 PM, Andrew Morton wrote: >> > > >> > > I don't know how to do this. Any suggestions? >> > > >> > > It has to be done at `make config' time. We'd need to probe for the >> > > presence of lz4c and then.... what? >> > > >> > > Is there any precedent for this? >> > > >> > > I don't think we can just ignore the absence of lz4c - the user has >> > > selected a config which his system cannot build. The problem lies >> > > within randconfig itself. >> > > >> > >> > We keep running over the need to be able to have kconfig run tests on >> > the build system (for toolchain support or for optional tools needed); >> > running them in the Makefiles (i.e. at Kbuild time) is simply too late. >> > >> >> Would it make sense to extend Kconfig's `depends'? >> >> depends on $(shell-command) >> >> I don't know how practical that would be to implement... > > Or, easier and faster, run some front-end script which generates > once-off Kconfig symbols. > > if [ -x /bin/lz4c ] > then > echo CONFIG_HAVE_LZ4C > fi > > then munge the output of that script into the Kconfig run and do > > depends on HAVE_LZ4C That does sound nice to avoid the build error, but will eventually make it harder to diagnose why the kernel has not been compressed with the specific compression tool, some kind of warning should also be emitted maybe? -- Florian