From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D652C433F5 for ; Sun, 8 May 2022 22:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233006AbiEHWfe (ORCPT ); Sun, 8 May 2022 18:35:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbiEHWfd (ORCPT ); Sun, 8 May 2022 18:35:33 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D50B6BC02 for ; Sun, 8 May 2022 15:31:41 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-2f7d621d1caso126843307b3.11 for ; Sun, 08 May 2022 15:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=rEGh1Yn4FvygAdmRpmsvPiaQVL+Z8fdxBGLuCY76iqk=; b=Sb4erGkH2Qi/HswRJQWL+mmKPxrQcNqxVOgUI71qLYIZmhew7MsfrVbE15gs0eO+NN nbJcYPC4/aKGEgoB8k7Oe61vddwWxdU28NNc8Ho2Pd6bnMVuRpWdwJJsRXujv84UQbc7 yByqtSUvr3SCKOSxNPuWcCM59I6xoZSNDjJzo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rEGh1Yn4FvygAdmRpmsvPiaQVL+Z8fdxBGLuCY76iqk=; b=Y6Ae1BqY5I8J1DBuFsDHfgkFcQnPfcX9op39rWPaVQwT/iQnpoCiSYM2ZlIN5xEjga CfTpHmRqz6Z1MXOVQ8lBUNIKzZnvgQQgQC6TelnONkyhOkQj3TGqGviXfZ0ixHSkV4i8 3p5LuywFt4vnKHJ9kvmvRNaHhyOEhBbaZNsXKkTFe6B4ur5pOpCXrMB+tBqiuSagfQYZ 0eXu7DCT3R6uuPQyguJCEySIeBRBvfg8mjoHK4vpO5oQLKcIYpd/0GM9WeuQHvC5gXMN 0WsczWZZAB0qXFpjRSWiOTeh/5KhCHtGsREx7B6stdwl2Yj1aKKRTzRTv9X3nnI3rsPh InkA== X-Gm-Message-State: AOAM5306kvaHfdrMbPsDKPg6XBd72peQc58y72lyUhjW5MYv92oiATW1 k9ZbMcAVo3pOqQXuzY9uuGWGNfGcVOLy6ZrGk7k= X-Google-Smtp-Source: ABdhPJyoQnjih7fu0GNDY7mf6zAqgwNmMpRvceO9ALr8gkJnkRXlCCodGIbEJIK71UNvAscr9Tw/zjnQx1HGW7qR7OA= X-Received: by 2002:a81:3dc6:0:b0:2f8:f29:b429 with SMTP id k189-20020a813dc6000000b002f80f29b429mr11558527ywa.393.1652049101037; Sun, 08 May 2022 15:31:41 -0700 (PDT) MIME-Version: 1.0 References: <20220508175712.647246-1-jic23@kernel.org> <20220508175712.647246-61-jic23@kernel.org> In-Reply-To: <20220508175712.647246-61-jic23@kernel.org> From: Michael Welling Date: Sun, 8 May 2022 15:31:30 -0700 Message-ID: Subject: Re: [PATCH v2 60/92] iio: dac: mcp4922: Fix alignment for DMA safety To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Alexandru Lazar , Akinobu Mita , Alexandru Tachici , Antoniu Miclaus , Charles-Antoine Couret , Cosmin Tanislav , David Lechner , Ivan Mikhaylov , Jacopo Mondi , Jean-Baptiste Maneyrol , Lars-Peter Clausen , Marcelo Schmitt , =?UTF-8?Q?M=C3=A5rten_Lindahl?= , Matt Ranostay , Matt Ranostay , Michael Hennerich , Mugilraj Dhavachelvan , Navin Sankar Velliangiri , =?UTF-8?B?TnVubyBTw6E=?= , Paul Cercueil , Phil Reid , Puranjay Mohan , Ricardo Ribalda , Robert Jones , Rui Miguel Silva , Sean Nyekjaer , Tomas Melin , Tomislav Denis , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Jonathan Cameron Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, May 8, 2022 at 10:56 AM Jonathan Cameron wrote: > > From: Jonathan Cameron > > ____cacheline_aligned is an insufficient guarantee for non-coherent DMA > on platforms with 128 byte cachelines above L1. Switch to the updated > IIO_DMA_MINALIGN definition. > > Fixes: 1b791fadf3a1 ("iio: dac: mcp4902/mcp4912/mcp4922 dac driver") > Signed-off-by: Jonathan Cameron > Cc: Michael Welling > Acked-by: Nuno S=C3=A1 > --- > drivers/iio/dac/mcp4922.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/mcp4922.c b/drivers/iio/dac/mcp4922.c > index cb9e60e71b91..6c0e31032c57 100644 > --- a/drivers/iio/dac/mcp4922.c > +++ b/drivers/iio/dac/mcp4922.c > @@ -29,7 +29,7 @@ struct mcp4922_state { > unsigned int value[MCP4922_NUM_CHANNELS]; > unsigned int vref_mv; > struct regulator *vref_reg; > - u8 mosi[2] ____cacheline_aligned; > + u8 mosi[2] __aligned(IIO_DMA_MINALIGN); Acked-by: Michael Welling > }; > > #define MCP4922_CHAN(chan, bits) { \ > -- > 2.36.0 >