Re: [PATCH 1/2] drm/bridge/tc358775: Return before displaying inappropriate error message

From: Vinay Simha B N <simhavcs@gmail.com>
To: Jiri Vanek <jirivanek1@gmail.com>
Cc: Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
	Robert Foss <robert.foss@linaro.org>,
	"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	open list <linux-kernel@vger.kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/2] drm/bridge/tc358775: Return before displaying inappropriate error message
Date: Fri, 17 Jun 2022 10:02:44 +0530	[thread overview]
Message-ID: <CAGWqDJ5A2-nk-=SaOF0aZSCKR9yJZ+4QRUBQ55NxsYF2dqGiHg@mail.gmail.com> (raw)
In-Reply-To: <20220615222221.1501-2-jirivanek1@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

Reviewed-by: Vinay Simha BN <simhavcs@gmail.com>

On Thu, Jun 16, 2022 at 3:55 AM Jiri Vanek <jirivanek1@gmail.com> wrote:

> Function for reading from i2c device register displays error message even
> if reading ends correctly. Add return to avoid falling through into
> the fail label.
>
> Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
> ---
>  drivers/gpu/drm/bridge/tc358775.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/tc358775.c
> b/drivers/gpu/drm/bridge/tc358775.c
> index 62a7ef352daa..cd2721ab02a9 100644
> --- a/drivers/gpu/drm/bridge/tc358775.c
> +++ b/drivers/gpu/drm/bridge/tc358775.c
> @@ -339,6 +339,7 @@ static void d2l_read(struct i2c_client *i2c, u16 addr,
> u32 *val)
>                 goto fail;
>
>         pr_debug("d2l: I2C : addr:%04x value:%08x\n", addr, *val);
> +       return;
>
>  fail:
>         dev_err(&i2c->dev, "Error %d reading from subaddress 0x%x\n",
> --
> 2.30.2
>
>

-- 
regards,
vinaysimha

[-- Attachment #2: Type: text/html, Size: 1553 bytes --]