Re: [PATCH v2] drm/bridge/tc358775: Fix for dual-link LVDS

From: Vinay Simha B N <simhavcs@gmail.com>
To: Jiri Vanek <jirivanek1@gmail.com>
Cc: Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
	Robert Foss <robert.foss@linaro.org>,
	"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	open list <linux-kernel@vger.kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2] drm/bridge/tc358775: Fix for dual-link LVDS
Date: Fri, 7 Jan 2022 00:52:08 +0530	[thread overview]
Message-ID: <CAGWqDJ6T6EGNjoc2qfNHLMdcuwcnJArF7a7sToRXJ90Zs57E_A@mail.gmail.com> (raw)
In-Reply-To: <20220106190027.1498-1-jirivanek1@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

Reviewed-by: Vinay Simha BN <simhavcs@gmail.com>

Jiri Vanek,
Could you please share the part number or datasheet of the dual-link LVDS
display/panel used.

On Fri, Jan 7, 2022 at 12:30 AM Jiri Vanek <jirivanek1@gmail.com> wrote:

> Fixed wrong register shift for single/dual link LVDS output.
>
> Tested-by: Jiri Vanek <jirivanek1@gmail.com>
> Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
>
> ---
> v1:
> * Initial version
>
> v2:
> * Tested-by tag added
>
> ---
>  drivers/gpu/drm/bridge/tc358775.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358775.c
> b/drivers/gpu/drm/bridge/tc358775.c
> index 2272adcc5b4a..1d6ec1baeff2 100644
> --- a/drivers/gpu/drm/bridge/tc358775.c
> +++ b/drivers/gpu/drm/bridge/tc358775.c
> @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
>  }
>
>  #define TC358775_LVCFG_LVDLINK__MASK                         0x00000002
> -#define TC358775_LVCFG_LVDLINK__SHIFT                        0
> +#define TC358775_LVCFG_LVDLINK__SHIFT                        1
>  static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
>  {
>         return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
> --
> 2.30.2
>
>

-- 
regards,
vinaysimha

[-- Attachment #2: Type: text/html, Size: 1966 bytes --]