From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA585C433F5 for ; Tue, 4 Jan 2022 16:56:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235579AbiADQ4Q (ORCPT ); Tue, 4 Jan 2022 11:56:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234144AbiADQ4Q (ORCPT ); Tue, 4 Jan 2022 11:56:16 -0500 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70D77C061761 for ; Tue, 4 Jan 2022 08:56:15 -0800 (PST) Received: by mail-yb1-xb33.google.com with SMTP id w13so76017602ybs.13 for ; Tue, 04 Jan 2022 08:56:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EuUzzCM3nnuYuvtfO1tfNIRyalOFRtKhum93Q0q5wBc=; b=UBTRkNLJxtIMDJ6OLdFOIEqb/ecIxV6S0BQzJY53jQvxxPcUz7XAm6UD7zAHZObT9Y N2FzhP/NXSo9UTVBOJmehckUybL9rwBWmkUHRhz4umyFSac1qQIQ8zt1ooii4wEqMcD6 OKZtXEnNBr7oU/4NefOvzFJhV2ezSJDVO5nbLUnGdBv9MpSZbxLPki/0dd8HKntyI5jT aT7vfbUmzG8rZmnxnbhYyvKdNfGQziumZBy6jjoi+dc2QHI4FSB2Rt/6JMJomApsxspC wTLOwabrDOHfXWPfC4xYSPCdbHwrcBO50HfUMZJejc+tc6nWycD/jCJ4QbdIBrkU1dYn 7Stw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EuUzzCM3nnuYuvtfO1tfNIRyalOFRtKhum93Q0q5wBc=; b=Skv3YYY06F4kyoCvftZHRWJbQcahZBp0YcZqz6jqTy0h4erlojLVSaTm4oh5KcKsPA ycs+a9RCXbCKcXW5hIf60WgOlIQ6oo/3U/M86ULFoCxEM4eRZ7k29hXkzTrEjxVkSLZ7 hLMZEicw2cp+IA22+iiunGIatiAkutJs/gxt+OkPkFW+8KUjPZGZEfAzfE3Wx2xyv49e 0anndopK2TX2JkFqDIoHCDOk1LKvoWP+wTsy5DdWY5zBSL4xbuLVvuzRa3/xXHmpI/Jd aT7g7sBwPiQk1JLUvFt4IlBje4sJjj+6kW4iqxiImwD2kqy2pxvPsjM3L9rpN9CHRTIs orBA== X-Gm-Message-State: AOAM533/3QFW3IiH34HYpVJsjT6Fw/q/paAPv66qzOpPTikpPMSc2lfv 2QYiezzwH3ViM2QLOj1/bsu7GO0vhJgs2DkF/wM= X-Google-Smtp-Source: ABdhPJzMV/dD3wcr+hjr0asqo1Y9ZhOjb8gtKwkA9wUaT5tf5LYB8SZmWc41tAqREEWoe2XAx4L16ghFmRxejGnT7Ng= X-Received: by 2002:a25:880d:: with SMTP id c13mr65300907ybl.720.1641315374501; Tue, 04 Jan 2022 08:56:14 -0800 (PST) MIME-Version: 1.0 References: <20211110220050.2854-1-jirivanek1@gmail.com> In-Reply-To: From: Vinay Simha B N Date: Tue, 4 Jan 2022 22:26:03 +0530 Message-ID: Subject: Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS To: Robert Foss Cc: Jiri Vanek , Zheng Bin , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , "open list:DRM PANEL DRIVERS" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert, What is R-b tag? On Tue, Jan 4, 2022 at 7:21 PM Robert Foss wrote: > > Jiri: Are you able to test this patch? > > Vinay: Could you supply a R-b tag, if you feel that it is warranted? > > On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N wrote: > > > > Robert, > > I do not have the hardware to test this feature. Sorry for the late response. > > > > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss wrote: > >> > >> + Zhen & Vinay > >> > >> This patch looks good in itself, but I would like to see a tested by > >> tag. At the very least testing for regression in single-link LVDS but > >> ideally some third party verification of this patch. > >> > >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek wrote: > >> > > >> > Fixed wrong register shift for single/dual link LVDS output. > >> > > >> > Signed-off-by: Jiri Vanek > >> > --- > >> > drivers/gpu/drm/bridge/tc358775.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c > >> > index 2272adcc5b4a..1d6ec1baeff2 100644 > >> > --- a/drivers/gpu/drm/bridge/tc358775.c > >> > +++ b/drivers/gpu/drm/bridge/tc358775.c > >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) > >> > } > >> > > >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 > >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0 > >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1 > >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) > >> > { > >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & > >> > -- > >> > 2.30.2 > >> > > > > > > > > > -- > > regards, > > vinaysimha -- regards, vinaysimha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B565C433F5 for ; Wed, 5 Jan 2022 08:25:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A19F10E73C; Wed, 5 Jan 2022 08:24:59 +0000 (UTC) Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by gabe.freedesktop.org (Postfix) with ESMTPS id 823D610E466 for ; Tue, 4 Jan 2022 16:56:15 +0000 (UTC) Received: by mail-yb1-xb36.google.com with SMTP id e202so67089934ybf.4 for ; Tue, 04 Jan 2022 08:56:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EuUzzCM3nnuYuvtfO1tfNIRyalOFRtKhum93Q0q5wBc=; b=UBTRkNLJxtIMDJ6OLdFOIEqb/ecIxV6S0BQzJY53jQvxxPcUz7XAm6UD7zAHZObT9Y N2FzhP/NXSo9UTVBOJmehckUybL9rwBWmkUHRhz4umyFSac1qQIQ8zt1ooii4wEqMcD6 OKZtXEnNBr7oU/4NefOvzFJhV2ezSJDVO5nbLUnGdBv9MpSZbxLPki/0dd8HKntyI5jT aT7vfbUmzG8rZmnxnbhYyvKdNfGQziumZBy6jjoi+dc2QHI4FSB2Rt/6JMJomApsxspC wTLOwabrDOHfXWPfC4xYSPCdbHwrcBO50HfUMZJejc+tc6nWycD/jCJ4QbdIBrkU1dYn 7Stw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EuUzzCM3nnuYuvtfO1tfNIRyalOFRtKhum93Q0q5wBc=; b=TUt7ESSTSUmuHxqE3Qm8mRTh+ok7blbowUbQgWLv1+vFmAxpDCzP4SEH7l8U9svHvn WCUdwzCe6reQis3hJbbMIC5SjtfUpB753cnIEm5aFjf2ructQJQe3Xp1a7RB1UMdn9Zd wmMC/Ve5Y2N03ebNt6e+U40WBxCWn+J9XGUkGv3g0z87CSiO0futpmK091GpD8ynLUrQ h7jbZHSPb7utDnBA8mBdgmsDWNVIV4APbly4CcNCm9TI7jXnxhSd5loyZFRITRwfd15x 1NhNpTHGS+X3tQI9uy9/GUKT9gOWXR/EZQWrecekv/XhC8Qd8vR0gEh6tPSLAS7nOKQA tuGg== X-Gm-Message-State: AOAM532QzWW9JFxWG4YxtUc44D64hpmjws9IUS1VoK3KWMY1/072I2u/ 4QwQ0nXMIb7PFKVpw5G/8Ca2LLMgWoJwclcwY4xTbV1ilfz9jA== X-Google-Smtp-Source: ABdhPJzMV/dD3wcr+hjr0asqo1Y9ZhOjb8gtKwkA9wUaT5tf5LYB8SZmWc41tAqREEWoe2XAx4L16ghFmRxejGnT7Ng= X-Received: by 2002:a25:880d:: with SMTP id c13mr65300907ybl.720.1641315374501; Tue, 04 Jan 2022 08:56:14 -0800 (PST) MIME-Version: 1.0 References: <20211110220050.2854-1-jirivanek1@gmail.com> In-Reply-To: From: Vinay Simha B N Date: Tue, 4 Jan 2022 22:26:03 +0530 Message-ID: Subject: Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS To: Robert Foss Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Wed, 05 Jan 2022 08:24:54 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Vanek , Jonas Karlman , David Airlie , "open list:DRM PANEL DRIVERS" , Neil Armstrong , open list , Jernej Skrabec , Zheng Bin , Andrzej Hajda , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Robert, What is R-b tag? On Tue, Jan 4, 2022 at 7:21 PM Robert Foss wrote: > > Jiri: Are you able to test this patch? > > Vinay: Could you supply a R-b tag, if you feel that it is warranted? > > On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N wrote: > > > > Robert, > > I do not have the hardware to test this feature. Sorry for the late response. > > > > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss wrote: > >> > >> + Zhen & Vinay > >> > >> This patch looks good in itself, but I would like to see a tested by > >> tag. At the very least testing for regression in single-link LVDS but > >> ideally some third party verification of this patch. > >> > >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek wrote: > >> > > >> > Fixed wrong register shift for single/dual link LVDS output. > >> > > >> > Signed-off-by: Jiri Vanek > >> > --- > >> > drivers/gpu/drm/bridge/tc358775.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c > >> > index 2272adcc5b4a..1d6ec1baeff2 100644 > >> > --- a/drivers/gpu/drm/bridge/tc358775.c > >> > +++ b/drivers/gpu/drm/bridge/tc358775.c > >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) > >> > } > >> > > >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 > >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0 > >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1 > >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) > >> > { > >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & > >> > -- > >> > 2.30.2 > >> > > > > > > > > > -- > > regards, > > vinaysimha -- regards, vinaysimha