From: Kees Cook <keescook@chromium.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Leon Romanovsky <leonro@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
Doug Ledford <dledford@redhat.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-rdma <linux-rdma@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] overflow.h: Add arithmetic shift helper
Date: Tue, 31 Jul 2018 21:22:23 -0700 [thread overview]
Message-ID: <CAGXu5j++7uQC3XWH7EDhOMDCfcTm+cJ4_9dwN-HsffNRRHyi6g@mail.gmail.com> (raw)
In-Reply-To: <20180801021508.GB31192@ziepe.ca>
On Tue, Jul 31, 2018 at 7:15 PM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
> On Tue, Jul 31, 2018 at 05:00:37PM -0700, Kees Cook wrote:
>> From: Jason Gunthorpe <jgg@mellanox.com>
>>
>> Add shift_overflow() helper to assist driver authors in ensuring that
>> shift operations don't cause overflows or other odd conditions.
>>
>> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
>> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
>> [kees: tweaked comments and commit log, dropped unneeded assignment]
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>> include/linux/overflow.h | 31 +++++++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> diff --git a/include/linux/overflow.h b/include/linux/overflow.h
>> index 8712ff70995f..69fc366ce865 100644
>> --- a/include/linux/overflow.h
>> +++ b/include/linux/overflow.h
>> @@ -202,6 +202,37 @@
>>
>> #endif /* COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW */
>>
>> +/** check_shift_overflow() - Calculate a left-shifted value and check overflow
>> + *
>> + * @a: Value to be shifted
>> + * @b: How many bits left to shift
>
> The above @b should be @s
Ooops, copy-paste-o. :)
>
>> +#define check_shift_overflow(a, s, d) ({ \
>
> Should I run this series through the rdma tree?
I'd like to get Rasmus's Ack, but otherwise, yes, that'd be fine.
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2018-08-01 4:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 0:00 [PATCH v2 0/3] overflow.h: Add arithmetic shift helper Kees Cook
2018-08-01 0:00 ` [PATCH v2 1/3] " Kees Cook
2018-08-01 1:59 ` Randy Dunlap
2018-08-01 2:15 ` Jason Gunthorpe
2018-08-01 4:22 ` Kees Cook [this message]
2018-08-01 7:57 ` Dan Carpenter
2018-08-01 8:07 ` Dan Carpenter
2018-08-01 15:38 ` Kees Cook
2018-08-01 15:48 ` Jason Gunthorpe
2018-08-01 0:00 ` [PATCH v2 2/3] test_overflow: Add shift overflow tests Kees Cook
2018-08-01 2:13 ` Jason Gunthorpe
2018-08-01 5:51 ` Kees Cook
2018-08-01 0:00 ` [PATCH v2 3/3] RDMA/mlx5: Fix shift overflow in mlx5_ib_create_wq Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5j++7uQC3XWH7EDhOMDCfcTm+cJ4_9dwN-HsffNRRHyi6g@mail.gmail.com \
--to=keescook@chromium.org \
--cc=Bart.VanAssche@wdc.com \
--cc=dan.carpenter@oracle.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.