From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758595AbcJRU5n (ORCPT ); Tue, 18 Oct 2016 16:57:43 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37492 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756436AbcJRU5h (ORCPT ); Tue, 18 Oct 2016 16:57:37 -0400 MIME-Version: 1.0 In-Reply-To: <20161017233752.68d20a89dbc9b0ff8841c9b3@gmail.com> References: <201610160608.eB1Owrn3%fengguang.wu@intel.com> <20161017233752.68d20a89dbc9b0ff8841c9b3@gmail.com> From: Kees Cook Date: Tue, 18 Oct 2016 13:57:35 -0700 X-Google-Sender-Auth: 29omI-V82pGtosrS9n_s0-d2Ayg Message-ID: Subject: Re: drivers/pci/hotplug/ibmphp_ebda.c:409:1: warning: the frame size of 1108 bytes is larger than 1024 bytes To: Emese Revfy Cc: kbuild test robot , kbuild-all@01.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2016 at 2:37 PM, Emese Revfy wrote: > On Sun, 16 Oct 2016 06:52:16 +0800 > kbuild test robot wrote: > >> drivers/pci/hotplug/ibmphp_ebda.c: In function 'ibmphp_access_ebda': >> >> drivers/pci/hotplug/ibmphp_ebda.c:409:1: warning: the frame size of 1108 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Hi, > > Thanks for the report. The problem is that these are large functions > (there are a lot of basic blocks) and the entropy plugin instruments all basic blocks. > I think the solution is to skip these functions which contain more than n basic blocks. > Sorry, I haven't time to fix this bug. PaX Team will fix it in PaX. This is controlled by CONFIG_FRAME_WARN. I don't think this is a particular problem or should be avoided, but perhaps we can set the default to 2048 (as done on 64BIT) if we're building with the entropy plugin. -Kees -- Kees Cook Nexus Security