From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067AbeBMFyp (ORCPT ); Tue, 13 Feb 2018 00:54:45 -0500 Received: from mail-vk0-f49.google.com ([209.85.213.49]:46386 "EHLO mail-vk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbeBMFym (ORCPT ); Tue, 13 Feb 2018 00:54:42 -0500 X-Google-Smtp-Source: AH8x227Mir8+oDQOnPOhm1LnZPgMsyoZU5XaETVC+cG/9hzzFY6YLDnMBbfES6pOTyR4cdGKL7kzkzZQQ0IvPQ4Z43M= MIME-Version: 1.0 In-Reply-To: <87r2ppvaeq.fsf@concordia.ellerman.id.au> References: <20180212133731.GE3443@dhcp22.suse.cz> <87r2ppvaeq.fsf@concordia.ellerman.id.au> From: Kees Cook Date: Mon, 12 Feb 2018 21:54:39 -0800 X-Google-Sender-Auth: hVhKl-9OyhHysUQAgllsBgwA5EQ Message-ID: Subject: Re: samples/seccomp/ broken when cross compiling s390, ppc allyesconfig To: Michael Ellerman Cc: Michal Hocko , Will Drewry , linux-s390 , PowerPC , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 12, 2018 at 7:25 PM, Michael Ellerman wrote: > Michal Hocko writes: >> Hi, >> my build test machinery chokes on samples/seccomp when cross compiling >> s390 and ppc64 allyesconfig. This has been the case for quite some >> time already but I never found time to look at the problem and report >> it. It seems this is not new issue and similar thing happend for >> MIPS e9107f88c985 ("samples/seccomp/Makefile: do not build tests if >> cross-compiling for MIPS"). >> >> The build logs are attached. >> >> What is the best way around this? Should we simply skip compilation on >> cross compile or is actually anybody relying on that? Or should I simply >> disable it for s390 and ppc? > > The whole thing seems very confused. It's not building for the target, > it's building for the host, ie. the Makefile sets hostprogs-m and > HOSTCFLAGS etc. > > So it can't possibly work with cross compiling as it's currently > written. > > Either the Makefile needs some serious work to properly support cross > compiling or it should just be disabled when cross compiling. Hrm, yeah, the goal was to entirely disable cross compiling, but I guess we didn't hit it with a hard enough hammer. :) -Kees -- Kees Cook Pixel Security