From: Kees Cook <keescook@chromium.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jessica Yu <jeyu@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call()
Date: Wed, 18 Oct 2017 07:21:05 -0700 [thread overview]
Message-ID: <CAGXu5j+UBNubuEkMDqRMW04PwtmEyD5T_hVHK4T0SXMSzjY5ew@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3m4DAHhFpURzspFiZRyseqxgjq5HZN3Gzv=BCpsL3OnA@mail.gmail.com>
On Wed, Oct 18, 2017 at 3:12 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wed, Oct 18, 2017 at 4:04 AM, Kees Cook <keescook@chromium.org> wrote:
>> (re-sending to Jessica's @korg address...)
>>
>> The module_param_call() macro was explicitly casting the .set and .get
>> function prototypes away with (void *). This can lead to hard-to-find
>> type mismatches. Additionally, it creates problems for static checkers
>> and Control Flow Itegrity compiler features, which depend on clustering
>> function call sites based on prototype signature.
>>
>> This removes the casts and fixes all the incorrect prototypes tree-wide.
>
> I've applied the patch to my randconfig test setup, will let you know if I find
> any regressions today.
>
> I did notice that patch 2 has a conflict against the ipmi driver, I had to
> manuall port that one part. Splitting up patch 2 would help there, but
> complicates other things.
Yeah, it was a small enough treewide change on code that normally
doesn't change much, so I figured it could stand as a regular patch.
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-10-18 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 2:04 [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call() Kees Cook
2017-10-18 2:04 ` [PATCH 1/3] module: Prepare to convert all module_param_call() prototypes Kees Cook
2017-10-18 2:04 ` [PATCH 2/3] treewide: Fix function prototypes for module_param_call() Kees Cook
2017-10-18 2:04 ` [PATCH 3/3] module: Do not paper over type mismatches in module_param_call() Kees Cook
2017-10-18 10:12 ` [RESEND][PATCH 0/3] " Arnd Bergmann
2017-10-18 14:21 ` Kees Cook [this message]
2017-10-30 21:20 ` Kees Cook
2017-10-31 14:46 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5j+UBNubuEkMDqRMW04PwtmEyD5T_hVHK4T0SXMSzjY5ew@mail.gmail.com \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.