All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Matthew Wilcox <mawilcox@microsoft.com>
Subject: Re: [PATCH] sparse doesn't support struct randomization
Date: Tue, 16 Jan 2018 19:55:09 -0800	[thread overview]
Message-ID: <CAGXu5j+kisRF67nhiVnZ80Abi3+4OTt9jOwrZyVVxACoFCLGng@mail.gmail.com> (raw)
In-Reply-To: <20180117024539.27354-1-willy@infradead.org>

On Tue, Jan 16, 2018 at 6:45 PM, Matthew Wilcox <willy@infradead.org> wrote:
> From: Matthew Wilcox <mawilcox@microsoft.com>
>
> Without this patch, I drown in a sea of unknown attribute warnings
>
> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>

Thanks!

Acked-by: Kees Cook <keescook@chromium.org>

Andrew, are you able to take this? I have no other gcc-plugin changes
pending for the coming merge window...

-Kees

> ---
>  include/linux/compiler-gcc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index 2272ded07496..631354acfa72 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -219,7 +219,7 @@
>  /* Mark a function definition as prohibited from being cloned. */
>  #define __noclone      __attribute__((__noclone__, __optimize__("no-tracer")))
>
> -#ifdef RANDSTRUCT_PLUGIN
> +#if defined(RANDSTRUCT_PLUGIN) && !defined(__CHECKER__)
>  #define __randomize_layout __attribute__((randomize_layout))
>  #define __no_randomize_layout __attribute__((no_randomize_layout))
>  #endif
> --
> 2.15.1
>



-- 
Kees Cook
Pixel Security

      reply	other threads:[~2018-01-17  3:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17  2:45 [PATCH] sparse doesn't support struct randomization Matthew Wilcox
2018-01-17  3:55 ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGXu5j+kisRF67nhiVnZ80Abi3+4OTt9jOwrZyVVxACoFCLGng@mail.gmail.com \
    --to=keescook@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mawilcox@microsoft.com \
    --cc=mingo@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.