From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751859AbeAQDzM (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 16 Jan 2018 22:55:12 -0500
Received: from mail-vk0-f65.google.com ([209.85.213.65]:37726 "EHLO
        mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750811AbeAQDzL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 Jan 2018 22:55:11 -0500
X-Google-Smtp-Source: ACJfBovu5srufuMGg6nbPxoRDi3+gls1gGELUPXZmeNAEkbFc2goHRTY8GZd/GjtQhgWc8aSkGm0gSG92VsPda0k2P8=
MIME-Version: 1.0
In-Reply-To: <20180117024539.27354-1-willy@infradead.org>
References: <20180117024539.27354-1-willy@infradead.org>
From: Kees Cook <keescook@chromium.org>
Date: Tue, 16 Jan 2018 19:55:09 -0800
X-Google-Sender-Auth: bFl7urh-_4LlFNj--IZggMCOm1s
Message-ID: <CAGXu5j+kisRF67nhiVnZ80Abi3+4OTt9jOwrZyVVxACoFCLGng@mail.gmail.com>
Subject: Re: [PATCH] sparse doesn't support struct randomization
To: Matthew Wilcox <willy@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Matthew Wilcox <mawilcox@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Tue, Jan 16, 2018 at 6:45 PM, Matthew Wilcox <willy@infradead.org> wrote:
> From: Matthew Wilcox <mawilcox@microsoft.com>
>
> Without this patch, I drown in a sea of unknown attribute warnings
>
> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>

Thanks!

Acked-by: Kees Cook <keescook@chromium.org>

Andrew, are you able to take this? I have no other gcc-plugin changes
pending for the coming merge window...

-Kees

> ---
>  include/linux/compiler-gcc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index 2272ded07496..631354acfa72 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -219,7 +219,7 @@
>  /* Mark a function definition as prohibited from being cloned. */
>  #define __noclone      __attribute__((__noclone__, __optimize__("no-tracer")))
>
> -#ifdef RANDSTRUCT_PLUGIN
> +#if defined(RANDSTRUCT_PLUGIN) && !defined(__CHECKER__)
>  #define __randomize_layout __attribute__((randomize_layout))
>  #define __no_randomize_layout __attribute__((no_randomize_layout))
>  #endif
> --
> 2.15.1
>



-- 
Kees Cook
Pixel Security