From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Stefan Agner <stefan@agner.ch>, Jessica Yu <jeyu@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <mmarek@suse.com>, Arnd Bergmann <arnd@arndb.de>,
Doug Anderson <dianders@chromium.org>,
Grant Grundler <grundler@chromium.org>,
Greg Hackmann <ghackmann@google.com>,
Michael Davidson <md@google.com>,
Alexander Potapenko <glider@google.com>,
Bernhard.Rosenkranzer@linaro.org
Subject: Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE
Date: Mon, 28 Aug 2017 10:41:01 -0700 [thread overview]
Message-ID: <CAGXu5jJMbS5ModDVhgs2kzus71B7pwkDd+GtvDZ=zjHDTmGNiQ@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdnN2+r4eFE=uRTBBTuiuALkKd3z5Z3GJt28K94P4rbjvA@mail.gmail.com>
On Mon, Aug 28, 2017 at 10:38 AM, Nick Desaulniers
<ndesaulniers@google.com> wrote:
> I think Kees' proposal is a better solution; rather than require all
> usage of device table to remember to add const, have the macro add it
> for all users. Otherwise if you require caller's to add it, they may
> forget.
And with the coccinelle script, it should be easy to invert the logic
and remove const from the callers...
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-08-28 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 1:27 [PATCH] module: Remove const attribute from alias for MODULE_DEVICE_TABLE Matthias Kaehlcke
2017-07-29 21:48 ` Jessica Yu
2017-08-27 23:52 ` Stefan Agner
2017-08-28 17:20 ` Kees Cook
2017-08-28 17:38 ` Nick Desaulniers
2017-08-28 17:41 ` Kees Cook [this message]
2017-08-29 2:24 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jJMbS5ModDVhgs2kzus71B7pwkDd+GtvDZ=zjHDTmGNiQ@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=Bernhard.Rosenkranzer@linaro.org \
--cc=arnd@arndb.de \
--cc=dianders@chromium.org \
--cc=ghackmann@google.com \
--cc=glider@google.com \
--cc=grundler@chromium.org \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mka@chromium.org \
--cc=mmarek@suse.com \
--cc=ndesaulniers@google.com \
--cc=rusty@rustcorp.com.au \
--cc=stefan@agner.ch \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.