From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227jFlM1GpZJy7OOt841Y8PueQHIzSNO+wi04+n84BTrXE/1VAKZt3wloYI1fxDrPnot8S73 ARC-Seal: i=1; a=rsa-sha256; t=1518479595; cv=none; d=google.com; s=arc-20160816; b=bDnZIcML1HacQ717+QFU7rVPB+fPhoQ4pC0TPgurTZSjoNcwk5Qhe0KTpNh5u1Y6z3 gim0eOpEfT/ZFCM4mqPq2xozv0exSftSg+CCgTJWwMbuMr6SgJNvgGY7d1GQBvaVNRjG JqiVkXYLkawauhLnBCvmJLijJQQXPdx7LON18PnXKi3Q11wJ6ca0Se9zMlRavC1E7Kgw ehl5yk0h/s+v+PZYWHCkgBF9Iz5GY4/MPlnoXCdWuLVBbXOPjV5jkmqFR5Ab1g8Pa44/ GDWRpQr5p3KpkTUkAHLAT0IANiW9Zhl2gCmVNDddiWNr38+fOpPqhvGLvfT9G26HR/rE y2ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to:sender :mime-version:dkim-signature:dkim-signature:delivered-to:list-id :list-subscribe:list-unsubscribe:list-help:list-post:precedence :mailing-list:arc-authentication-results; bh=NnWDcVvDDLKm5RQvyoJmTR2xPbQqECb87E1euKYodxU=; b=YxhwNccijW8SuLrd+Kbi59sqIvbzLYzYJqLR1AKZyThyhlRC/QvZBmGckgnbn52oOI UTRMiWqRiF/jxP1sMio0gJU1mYKlxuCUz1EA1QBOxsSKPzzSdiF/SFLjNHXURjtowR1z CkFDj4bEOvUMm9/rXrPoNkQpXCukbgwr7dmEUETKKzoD/CRMt3qW/miqyX/do+FnlOnq eMK+ha0vmbfDzQfTZQOfguP8MF7Qhi4w32/HFGPNtNQHuIvF2vwehxl53u4I0BT0/Msz pQPYyNF79KtECvr4fSgPn4uu70y0S6Dq4FIzCygVS4ezonnVQxe7JnczX824MHLBOZ1T 9oig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=aiboCv1R; dkim=pass header.i=@chromium.org header.s=google header.b=RlfBjq0/; spf=pass (google.com: domain of kernel-hardening-return-11738-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11738-gregkh=linuxfoundation.org@lists.openwall.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=aiboCv1R; dkim=pass header.i=@chromium.org header.s=google header.b=RlfBjq0/; spf=pass (google.com: domain of kernel-hardening-return-11738-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11738-gregkh=linuxfoundation.org@lists.openwall.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm List-Post: List-Help: List-Unsubscribe: List-Subscribe: MIME-Version: 1.0 Sender: keescook@google.com In-Reply-To: <20180212165301.17933-2-igor.stoppa@huawei.com> References: <20180212165301.17933-1-igor.stoppa@huawei.com> <20180212165301.17933-2-igor.stoppa@huawei.com> From: Kees Cook Date: Mon, 12 Feb 2018 15:52:53 -0800 X-Google-Sender-Auth: EEhZnS07whD--2F2gJLkq0chKzw Message-ID: Subject: Re: [PATCH 1/6] genalloc: track beginning of allocations To: Igor Stoppa Cc: Matthew Wilcox , Randy Dunlap , Jonathan Corbet , Michal Hocko , Laura Abbott , Jerome Glisse , Christoph Hellwig , Christoph Lameter , linux-security-module , Linux-MM , LKML , Kernel Hardening Content-Type: text/plain; charset="UTF-8" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1592214925267848300?= X-GMAIL-MSGID: =?utf-8?q?1592241260429819824?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > @@ -738,14 +1031,16 @@ EXPORT_SYMBOL(devm_gen_pool_create); > > #ifdef CONFIG_OF > /** > - * of_gen_pool_get - find a pool by phandle property > + * of_gen_pool_get() - find a pool by phandle property > * @np: device node > * @propname: property name containing phandle(s) > * @index: index into the phandle array > * > - * Returns the pool that contains the chunk starting at the physical > - * address of the device tree node pointed at by the phandle property, > - * or NULL if not found. > + * Return: > + * * pool address - it contains the chunk starting at the physical > + * address of the device tree node pointed at by > + * the phandle property > + * * NULL - otherwise > */ > struct gen_pool *of_gen_pool_get(struct device_node *np, > const char *propname, int index) I wonder if this might be more readable by splitting the kernel-doc changes from the bitmap changes? I.e. fix all the kernel-doc in one patch, and in the following, make the bitmap changes. Maybe it's such a small part that it doesn't matter, though? -Kees -- Kees Cook Pixel Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: keescook@chromium.org (Kees Cook) Date: Mon, 12 Feb 2018 15:52:53 -0800 Subject: [PATCH 1/6] genalloc: track beginning of allocations In-Reply-To: <20180212165301.17933-2-igor.stoppa@huawei.com> References: <20180212165301.17933-1-igor.stoppa@huawei.com> <20180212165301.17933-2-igor.stoppa@huawei.com> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > @@ -738,14 +1031,16 @@ EXPORT_SYMBOL(devm_gen_pool_create); > > #ifdef CONFIG_OF > /** > - * of_gen_pool_get - find a pool by phandle property > + * of_gen_pool_get() - find a pool by phandle property > * @np: device node > * @propname: property name containing phandle(s) > * @index: index into the phandle array > * > - * Returns the pool that contains the chunk starting at the physical > - * address of the device tree node pointed at by the phandle property, > - * or NULL if not found. > + * Return: > + * * pool address - it contains the chunk starting at the physical > + * address of the device tree node pointed at by > + * the phandle property > + * * NULL - otherwise > */ > struct gen_pool *of_gen_pool_get(struct device_node *np, > const char *propname, int index) I wonder if this might be more readable by splitting the kernel-doc changes from the bitmap changes? I.e. fix all the kernel-doc in one patch, and in the following, make the bitmap changes. Maybe it's such a small part that it doesn't matter, though? -Kees -- Kees Cook Pixel Security -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f200.google.com (mail-ua0-f200.google.com [209.85.217.200]) by kanga.kvack.org (Postfix) with ESMTP id EA6FB6B0003 for ; Mon, 12 Feb 2018 18:52:55 -0500 (EST) Received: by mail-ua0-f200.google.com with SMTP id p1so11555558uab.15 for ; Mon, 12 Feb 2018 15:52:55 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id l21sor3777237vkd.254.2018.02.12.15.52.55 for (Google Transport Security); Mon, 12 Feb 2018 15:52:55 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180212165301.17933-2-igor.stoppa@huawei.com> References: <20180212165301.17933-1-igor.stoppa@huawei.com> <20180212165301.17933-2-igor.stoppa@huawei.com> From: Kees Cook Date: Mon, 12 Feb 2018 15:52:53 -0800 Message-ID: Subject: Re: [PATCH 1/6] genalloc: track beginning of allocations Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Igor Stoppa Cc: Matthew Wilcox , Randy Dunlap , Jonathan Corbet , Michal Hocko , Laura Abbott , Jerome Glisse , Christoph Hellwig , Christoph Lameter , linux-security-module , Linux-MM , LKML , Kernel Hardening On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > @@ -738,14 +1031,16 @@ EXPORT_SYMBOL(devm_gen_pool_create); > > #ifdef CONFIG_OF > /** > - * of_gen_pool_get - find a pool by phandle property > + * of_gen_pool_get() - find a pool by phandle property > * @np: device node > * @propname: property name containing phandle(s) > * @index: index into the phandle array > * > - * Returns the pool that contains the chunk starting at the physical > - * address of the device tree node pointed at by the phandle property, > - * or NULL if not found. > + * Return: > + * * pool address - it contains the chunk starting at the physical > + * address of the device tree node pointed at by > + * the phandle property > + * * NULL - otherwise > */ > struct gen_pool *of_gen_pool_get(struct device_node *np, > const char *propname, int index) I wonder if this might be more readable by splitting the kernel-doc changes from the bitmap changes? I.e. fix all the kernel-doc in one patch, and in the following, make the bitmap changes. Maybe it's such a small part that it doesn't matter, though? -Kees -- Kees Cook Pixel Security -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org