From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933266AbdJ3Vhk (ORCPT ); Mon, 30 Oct 2017 17:37:40 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:45612 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933209AbdJ3Vhi (ORCPT ); Mon, 30 Oct 2017 17:37:38 -0400 X-Google-Smtp-Source: ABhQp+TvMYB4n+ycUjDyynI85oQc//QYFf63GJaowwK1o7YnBGOmuJTMNcqmBMGSRd/aHEyePnBEAyb3yVGmRNkemcg= MIME-Version: 1.0 In-Reply-To: <20171030114809.GF7223@localhost> References: <20171024144938.GA41224@beast> <55a6647a-8565-09e8-9f45-d9048c7dd916@linaro.org> <20171030113202.GB7223@localhost> <558a6d02-515e-9998-18cc-b9b77d2b1d63@nexus-software.ie> <20171030113819.GD7223@localhost> <523e9618-e72e-72fa-3d98-062e687ca226@linaro.org> <20171030114809.GF7223@localhost> From: Kees Cook Date: Mon, 30 Oct 2017 14:37:37 -0700 X-Google-Sender-Auth: A8VhaMYMAgtFTH1nosfXqF-kb38 Message-ID: Subject: Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup() To: Johan Hovold Cc: "Bryan O'Donoghue" , "Bryan O'Donoghue" , Greg Kroah-Hartman , LKML , Alex Elder , greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: > On Mon, Oct 30, 2017 at 11:44:22AM +0000, Bryan O'Donoghue wrote: >> >> >> On 30/10/17 11:38, Johan Hovold wrote: >> > On Mon, Oct 30, 2017 at 11:35:50AM +0000, Bryan O'Donoghue wrote: >> >> On 30/10/17 11:32, Johan Hovold wrote: >> >>> The right thing to do here is to respin your patch from last year which >> >>> converts the loopback driver to use the timeout handling in greybus >> >>> core. >> >> >> >> Actually I wasn't clear if you wanted to to that yourself aswell as the >> >> rest if it. >> >> >> >> But sure I can do that conversion, it's on my list. >> > >> > IIRC it was basically done. Just some odd locking that could now also be >> > removed. >> > >> > Thanks, >> > Johan >> > >> >> I think once Kees' change is applied to operation.c and we convert the >> async stuff to operation.c's callbacks there ought to be no use of >> timers, linked lists of operations. > > That's correct. > >> I'll probably need at least a day to look at that, so it'll be the >> weekend before I can really allocate time. > > Cool. I'm quite sure I just rebased your loopback conversion patch on my > core timeout handling and used that to test the core implementation, so > it should be straight forward. Hi, I seem to have lost the thread of conversation a bit. What exactly remains that I should be doing here for timer conversions? (It sounded like it was already partially handled already?) -Kees -- Kees Cook Pixel Security