From: Kees Cook <keescook@chromium.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
Borislav Petkov <bp@suse.de>, Fenghua Yu <fenghua.yu@intel.com>,
Yinghai Lu <yinghai@kernel.org>,
Seiji Aguchi <seiji.aguchi@hds.com>,
PaX Team <pageexec@freemail.hu>
Subject: Re: [PATCH] x86: make sure IDT is page aligned
Date: Fri, 12 Jul 2013 15:43:10 -0700 [thread overview]
Message-ID: <CAGXu5jJ_eo3AP67jS8M1mPak-SxS4FzBoosJTzj5cb=CLC43KQ@mail.gmail.com> (raw)
In-Reply-To: <51E082F6.4030305@zytor.com>
That was the busted patch. See the v2 I sent. Only 64-bit needs
alignment. And after looking more at it, the idt in head_64.S could be
entirely dropped in favor of using the one in arch/x86/kernel/traps.c
(after moving it out of the #ifdef.
-Kees
On Fri, Jul 12, 2013 at 3:28 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 07/12/2013 11:30 AM, Kees Cook wrote:
>>
>> - .word 0 # 32-bit align idt_desc.address
>> + .word PAGE_SIZE # page align idt_desc.address
>>
>
> ... and this is totally confused. This didn't change alignment one
> iota, it only put the value 4096 into the padding.
>
> -hpa
>
--
Kees Cook
Chrome OS Security
prev parent reply other threads:[~2013-07-12 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 18:30 [PATCH] x86: make sure IDT is page aligned Kees Cook
2013-07-12 22:27 ` H. Peter Anvin
2013-07-12 22:28 ` H. Peter Anvin
2013-07-12 22:43 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jJ_eo3AP67jS8M1mPak-SxS4FzBoosJTzj5cb=CLC43KQ@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=bp@suse.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pageexec@freemail.hu \
--cc=seiji.aguchi@hds.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.