Re: [PATCH v3 0/8] pstore: ramoops: support multiple pmsg instances

From: Kees Cook <keescook@chromium.org>
To: "岩松信洋 / IWAMATSU，NOBUHIRO" <nobuhiro.iwamatsu.kw@hitachi.com>
Cc: Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"cti.systems-productivity-manager.ts@hitachi.com" 
	<cti.systems-productivity-manager.ts@hitachi.com>
Subject: Re: [PATCH v3 0/8] pstore: ramoops: support multiple pmsg instances
Date: Tue, 3 Jan 2017 22:20:13 -0800	[thread overview]
Message-ID: <CAGXu5jJpNQZLHU_g+j8WtA5oJncnKF05sy8t0oONxCWcSd7xTA@mail.gmail.com> (raw)
In-Reply-To: <F89ECF87BC754A49BB74E794F6A0EC2F01041248@GSjpTKYDCembx31.service.hitachi.net>

On Mon, Dec 26, 2016 at 4:48 PM, 岩松信洋 / IWAMATSU，NOBUHIRO
<nobuhiro.iwamatsu.kw@hitachi.com> wrote:
> Ping?_
>
>> -----Original Message-----
>> From: linux-kernel-owner@vger.kernel.org
>> [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of 岩松信洋 /
>> IWAMATSU，NOBUHIRO
>> Sent: Monday, December 05, 2016 10:47 AM
>> To: Kees Cook
>> Cc: Anton Vorontsov; Colin Cross; Tony Luck; LKML;
>> cti.systems-productivity-manager.ts@hitachi.com
>> Subject: RE: [PATCH v3 0/8] pstore: ramoops: support multiple pmsg instances
>>
>> Hi, Kees.
>>
>> > -----Original Message-----
>> > From: keescook@google.com [mailto:keescook@google.com] On Behalf Of
>> > Kees Cook
>> > Sent: Saturday, November 12, 2016 7:24 AM
>> > To: 岩松信洋 / IWAMATSU，NOBUHIRO
>> > Cc: Anton Vorontsov; Colin Cross; Tony Luck; LKML;
>> > cti.systems-productivity-manager.ts@hitachi.com
>> > Subject: Re: [PATCH v3 0/8] pstore: ramoops: support multiple pmsg
>> > instances
>> >
>> > On Tue, Oct 18, 2016 at 12:13 AM, Nobuhiro Iwamatsu
>> > <nobuhiro.iwamatsu.kw@hitachi.com> wrote:
>> > > The following series implements multiple pmsg. This feature allows
>> > > userspace program to control individual content aging or priority.
>> > >
>> > > If a pstore backend module(e.g. ramoops) requires the multiple pmsg
>> > > instances when registering itself to pstore, multiple /dev/pmsg[ID]
>> > > are created. Writes to each /dev/pmsg[ID] are isolated each other.
>> > > After reboot, the contents are available in
>> > /sys/fs/pstore/pmsg-[backend]-[ID].
>> > >
>> > > In addition, we add multiple pmsg support for ramoops. We can
>> > > specify multiple pmsg area size by its module parameter as follows.
>> > >
>> > >  pmsg_size=0x1000,0x2000,...
>> > >
>> > > I did check the operation of this feature on CycloneV (socfpga)
>> > > Helio
>> > board.
>> > >
>> > > v3:
>> > >   Rebase to v4.8.
>> > >   Split patch.
>> > >   merged device_create().
>> > >   Remove Blank lines.
>> > >   Update documentiation of DT binding.
>> > >   Update parsing function of ramoops_pmsg_size, add NULL termination.
>> > >   Update module parameters for pmsg_size list.
>> >
>> > Thanks for this v3! Sorry for the delay, I should be able to review
>> > this shortly.
>>
>> Thank you.
>> I will wait for your review.

Now that the big changes have landed in Linus's tree, are you able to
rebase your series on those?

-Kees

-- 
Kees Cook
Nexus Security