From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752200AbcDOTOZ (ORCPT ); Fri, 15 Apr 2016 15:14:25 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36211 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbcDOTOY (ORCPT ); Fri, 15 Apr 2016 15:14:24 -0400 MIME-Version: 1.0 In-Reply-To: <20160415081223.GF30715@gmail.com> References: <1460672954-32567-1-git-send-email-keescook@chromium.org> <1460672954-32567-6-git-send-email-keescook@chromium.org> <20160415081223.GF30715@gmail.com> Date: Fri, 15 Apr 2016 12:14:22 -0700 X-Google-Sender-Auth: 5qRivt5r9pPizVnnOOiLdCsz9NY Message-ID: Subject: Re: [PATCH v5 05/21] x86, boot: Calculate decompression size during boot not build From: Kees Cook To: Ingo Molnar Cc: Yinghai Lu , Baoquan He , Ard Biesheuvel , Matt Redfearn , "x86@kernel.org" , "H. Peter Anvin" , Ingo Molnar , Borislav Petkov , Vivek Goyal , Andy Lutomirski , lasse.collin@tukaani.org, Andrew Morton , Dave Young , "kernel-hardening@lists.openwall.com" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 15, 2016 at 1:12 AM, Ingo Molnar wrote: > > * Kees Cook wrote: > >> From: Yinghai Lu >> >> Currently z_extract_offset is calculated in boot/compressed/mkpiggy.c. > > What is the high level meaning of z_extract_offset? I cannot tell without reading > the code - and the point of changelogs is for them to be readable without having > to read the code. I'll clarify it in the changelog. (FWIW, it's the offset into the extraction buffer where it's safe to put the data-to-be-extracted). > The rest of the changelog is pretty good. Thanks! -Kees -- Kees Cook Chrome OS & Brillo Security From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com MIME-Version: 1.0 Sender: keescook@google.com In-Reply-To: <20160415081223.GF30715@gmail.com> References: <1460672954-32567-1-git-send-email-keescook@chromium.org> <1460672954-32567-6-git-send-email-keescook@chromium.org> <20160415081223.GF30715@gmail.com> Date: Fri, 15 Apr 2016 12:14:22 -0700 Message-ID: From: Kees Cook Content-Type: text/plain; charset=UTF-8 Subject: [kernel-hardening] Re: [PATCH v5 05/21] x86, boot: Calculate decompression size during boot not build To: Ingo Molnar Cc: Yinghai Lu , Baoquan He , Ard Biesheuvel , Matt Redfearn , "x86@kernel.org" , "H. Peter Anvin" , Ingo Molnar , Borislav Petkov , Vivek Goyal , Andy Lutomirski , lasse.collin@tukaani.org, Andrew Morton , Dave Young , "kernel-hardening@lists.openwall.com" , LKML List-ID: On Fri, Apr 15, 2016 at 1:12 AM, Ingo Molnar wrote: > > * Kees Cook wrote: > >> From: Yinghai Lu >> >> Currently z_extract_offset is calculated in boot/compressed/mkpiggy.c. > > What is the high level meaning of z_extract_offset? I cannot tell without reading > the code - and the point of changelogs is for them to be readable without having > to read the code. I'll clarify it in the changelog. (FWIW, it's the offset into the extraction buffer where it's safe to put the data-to-be-extracted). > The rest of the changelog is pretty good. Thanks! -Kees -- Kees Cook Chrome OS & Brillo Security