From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754115AbdF0Xro (ORCPT ); Tue, 27 Jun 2017 19:47:44 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:36916 "EHLO mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754033AbdF0Xrj (ORCPT ); Tue, 27 Jun 2017 19:47:39 -0400 MIME-Version: 1.0 In-Reply-To: <1493928654-18768-1-git-send-email-Julia.Lawall@lip6.fr> References: <1493928654-18768-1-git-send-email-Julia.Lawall@lip6.fr> From: Kees Cook Date: Tue, 27 Jun 2017 16:47:37 -0700 X-Google-Sender-Auth: BuIOnVS-iw01K3vL_mlX-G-DfOc Message-ID: Subject: Re: [PATCH 0/9] Drop unnecessary static To: Julia Lawall Cc: Linux PM list , kernel-janitors@vger.kernel.org, Linux mtd , LKML , drbd-dev@lists.linbit.com, linux-omap@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-input , linux-iio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 4, 2017 at 1:10 PM, Julia Lawall wrote: > These patches fix cases where there is a static on a local variable, but > the variable is either first initialized or never used, on every possible > execution path through the function. The static has no benefit, and > dropping it reduces the code size. > > --- > > drivers/block/drbd/drbd_nl.c | 2 +- > drivers/clocksource/timer-fttmr010.c | 2 +- > drivers/iio/accel/hid-sensor-accel-3d.c | 2 +- > drivers/mfd/max8925-i2c.c | 2 +- > drivers/mfd/twl4030-irq.c | 2 +- > drivers/mtd/chips/cfi_cmdset_0020.c | 2 +- > drivers/mtd/maps/physmap_of_gemini.c | 2 +- > drivers/power/supply/axp20x_usb_power.c | 2 +- > drivers/regulator/palmas-regulator.c | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) It looks like most of these were taken. I pinged the other three. Thanks! -Kees -- Kees Cook Pixel Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Date: Tue, 27 Jun 2017 23:47:37 +0000 Subject: Re: [PATCH 0/9] Drop unnecessary static Message-Id: List-Id: References: <1493928654-18768-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1493928654-18768-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Linux PM list , kernel-janitors@vger.kernel.org, Linux mtd , LKML , drbd-dev@lists.linbit.com, linux-omap@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-input , linux-iio@vger.kernel.org On Thu, May 4, 2017 at 1:10 PM, Julia Lawall wrote: > These patches fix cases where there is a static on a local variable, but > the variable is either first initialized or never used, on every possible > execution path through the function. The static has no benefit, and > dropping it reduces the code size. > > --- > > drivers/block/drbd/drbd_nl.c | 2 +- > drivers/clocksource/timer-fttmr010.c | 2 +- > drivers/iio/accel/hid-sensor-accel-3d.c | 2 +- > drivers/mfd/max8925-i2c.c | 2 +- > drivers/mfd/twl4030-irq.c | 2 +- > drivers/mtd/chips/cfi_cmdset_0020.c | 2 +- > drivers/mtd/maps/physmap_of_gemini.c | 2 +- > drivers/power/supply/axp20x_usb_power.c | 2 +- > drivers/regulator/palmas-regulator.c | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) It looks like most of these were taken. I pinged the other three. Thanks! -Kees -- Kees Cook Pixel Security