From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754204AbbCISGF (ORCPT ); Mon, 9 Mar 2015 14:06:05 -0400 Received: from mail-vc0-f172.google.com ([209.85.220.172]:47707 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753334AbbCISGC (ORCPT ); Mon, 9 Mar 2015 14:06:02 -0400 MIME-Version: 1.0 In-Reply-To: <20150309161912.GW8656@n2100.arm.linux.org.uk> References: <1425435025-30284-1-git-send-email-keescook@chromium.org> <20150309161912.GW8656@n2100.arm.linux.org.uk> Date: Mon, 9 Mar 2015 11:06:00 -0700 X-Google-Sender-Auth: 2Cl8mu5yMy1_cbDkqQY_Z3VpL0I Message-ID: Subject: Re: [PATCH v3 0/10] split ET_DYN ASLR from mmap ASLR From: Kees Cook To: Russell King - ARM Linux Cc: Andrew Morton , LKML , Hector Marco-Gisbert , Ismael Ripoll , Catalin Marinas , Will Deacon , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, "x86@kernel.org" , Alexander Viro , Oleg Nesterov , Andy Lutomirski , "David A. Long" , Andrey Ryabinin , Arun Chandran , Min-Hua Chen , Dan McGee , Yann Droneaud , Paul Burton , Alex Smith , Markos Chandras , Vineeth Vijayan , Jeff Bailey , Michael Holzheu , Ben Hutchings , Behan Webster , =?UTF-8?Q?Jan=2DSimon_M=C3=B6ller?= , "linux-arm-kernel@lists.infradead.org" , Linux MIPS Mailing List , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, "linux-fsdevel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 9, 2015 at 9:19 AM, Russell King - ARM Linux wrote: > On Tue, Mar 03, 2015 at 06:10:15PM -0800, Kees Cook wrote: >> To address the "offset2lib" ASLR weakness[1], this separates ET_DYN >> ASLR from mmap ASLR, as already done on s390. The architectures >> that are already randomizing mmap (arm, arm64, mips, powerpc, s390, >> and x86), have their various forms of arch_mmap_rnd() made available >> via the new CONFIG_ARCH_HAS_ELF_RANDOMIZE. For these architectures, >> arch_randomize_brk() is collapsed as well. >> >> This is an alternative to the solutions in: >> https://lkml.org/lkml/2015/2/23/442 >> >> I've been able to test x86 and arm, and the buildbot (so far) seems >> happy with building the rest. > > Hmm, do you want to wrap my acks up to your previous one into this set? > What about my tested-by? > > I'd rather not waste time testing this version if my previous test is > still valid (or if there's yet another version of this patch set which > is later than this set.) > > Unless I hear anything, I'll assume that it's broadly the same as the > previous patch set and requires no action. Yeah, it's broadly the same. I tweaked a few minor things, so I'm comfortable retaining the acks and tested-bys. Thank you for the reviews and tests! -Kees -- Kees Cook Chrome OS Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH v3 0/10] split ET_DYN ASLR from mmap ASLR Date: Mon, 9 Mar 2015 11:06:00 -0700 Message-ID: References: <1425435025-30284-1-git-send-email-keescook@chromium.org> <20150309161912.GW8656@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Andrew Morton , LKML , Hector Marco-Gisbert , Ismael Ripoll , Catalin Marinas , Will Deacon , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, "x86@kernel.org" , Alexander Viro , Oleg Nesterov , Andy Lutomirski , "David A. Long" , Andrey Ryabinin , Arun Chandran , Min-Hua Chen , Dan McGee , Yann Droneaud , To: Russell King - ARM Linux Return-path: In-Reply-To: <20150309161912.GW8656@n2100.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Mar 9, 2015 at 9:19 AM, Russell King - ARM Linux wrote: > On Tue, Mar 03, 2015 at 06:10:15PM -0800, Kees Cook wrote: >> To address the "offset2lib" ASLR weakness[1], this separates ET_DYN >> ASLR from mmap ASLR, as already done on s390. The architectures >> that are already randomizing mmap (arm, arm64, mips, powerpc, s390, >> and x86), have their various forms of arch_mmap_rnd() made available >> via the new CONFIG_ARCH_HAS_ELF_RANDOMIZE. For these architectures, >> arch_randomize_brk() is collapsed as well. >> >> This is an alternative to the solutions in: >> https://lkml.org/lkml/2015/2/23/442 >> >> I've been able to test x86 and arm, and the buildbot (so far) seems >> happy with building the rest. > > Hmm, do you want to wrap my acks up to your previous one into this set? > What about my tested-by? > > I'd rather not waste time testing this version if my previous test is > still valid (or if there's yet another version of this patch set which > is later than this set.) > > Unless I hear anything, I'll assume that it's broadly the same as the > previous patch set and requires no action. Yeah, it's broadly the same. I tweaked a few minor things, so I'm comfortable retaining the acks and tested-bys. Thank you for the reviews and tests! -Kees -- Kees Cook Chrome OS Security From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vc0-x233.google.com (mail-vc0-x233.google.com [IPv6:2607:f8b0:400c:c03::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 380251A0008 for ; Tue, 10 Mar 2015 05:06:03 +1100 (AEDT) Received: by mail-vc0-f179.google.com with SMTP id la4so15583505vcb.10 for ; Mon, 09 Mar 2015 11:06:00 -0700 (PDT) MIME-Version: 1.0 Sender: keescook@google.com In-Reply-To: <20150309161912.GW8656@n2100.arm.linux.org.uk> References: <1425435025-30284-1-git-send-email-keescook@chromium.org> <20150309161912.GW8656@n2100.arm.linux.org.uk> Date: Mon, 9 Mar 2015 11:06:00 -0700 Message-ID: Subject: Re: [PATCH v3 0/10] split ET_DYN ASLR from mmap ASLR From: Kees Cook To: Russell King - ARM Linux Content-Type: text/plain; charset=UTF-8 Cc: Linux MIPS Mailing List , Arun Chandran , Catalin Marinas , Heiko Carstens , Oleg Nesterov , Min-Hua Chen , Paul Mackerras , Ismael Ripoll , Yann Droneaud , linux-s390@vger.kernel.org, Andrey Ryabinin , Behan Webster , "x86@kernel.org" , Hector Marco-Gisbert , "David A. Long" , Ben Hutchings , Will Deacon , "linux-fsdevel@vger.kernel.org" , Alexander Viro , Dan McGee , Michael Holzheu , "linux-arm-kernel@lists.infradead.org" , Jeff Bailey , Paul Burton , LKML , Ralf Baechle , Andy Lutomirski , Vineeth Vijayan , Markos Chandras , =?UTF-8?Q?Jan=2DSimon_M=C3=B6ller?= , Martin Schwidefsky , linux390@de.ibm.com, Andrew Morton , linuxppc-dev@lists.ozlabs.org, Alex Smith List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Mar 9, 2015 at 9:19 AM, Russell King - ARM Linux wrote: > On Tue, Mar 03, 2015 at 06:10:15PM -0800, Kees Cook wrote: >> To address the "offset2lib" ASLR weakness[1], this separates ET_DYN >> ASLR from mmap ASLR, as already done on s390. The architectures >> that are already randomizing mmap (arm, arm64, mips, powerpc, s390, >> and x86), have their various forms of arch_mmap_rnd() made available >> via the new CONFIG_ARCH_HAS_ELF_RANDOMIZE. For these architectures, >> arch_randomize_brk() is collapsed as well. >> >> This is an alternative to the solutions in: >> https://lkml.org/lkml/2015/2/23/442 >> >> I've been able to test x86 and arm, and the buildbot (so far) seems >> happy with building the rest. > > Hmm, do you want to wrap my acks up to your previous one into this set? > What about my tested-by? > > I'd rather not waste time testing this version if my previous test is > still valid (or if there's yet another version of this patch set which > is later than this set.) > > Unless I hear anything, I'll assume that it's broadly the same as the > previous patch set and requires no action. Yeah, it's broadly the same. I tweaked a few minor things, so I'm comfortable retaining the acks and tested-bys. Thank you for the reviews and tests! -Kees -- Kees Cook Chrome OS Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: keescook@chromium.org (Kees Cook) Date: Mon, 9 Mar 2015 11:06:00 -0700 Subject: [PATCH v3 0/10] split ET_DYN ASLR from mmap ASLR In-Reply-To: <20150309161912.GW8656@n2100.arm.linux.org.uk> References: <1425435025-30284-1-git-send-email-keescook@chromium.org> <20150309161912.GW8656@n2100.arm.linux.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 9, 2015 at 9:19 AM, Russell King - ARM Linux wrote: > On Tue, Mar 03, 2015 at 06:10:15PM -0800, Kees Cook wrote: >> To address the "offset2lib" ASLR weakness[1], this separates ET_DYN >> ASLR from mmap ASLR, as already done on s390. The architectures >> that are already randomizing mmap (arm, arm64, mips, powerpc, s390, >> and x86), have their various forms of arch_mmap_rnd() made available >> via the new CONFIG_ARCH_HAS_ELF_RANDOMIZE. For these architectures, >> arch_randomize_brk() is collapsed as well. >> >> This is an alternative to the solutions in: >> https://lkml.org/lkml/2015/2/23/442 >> >> I've been able to test x86 and arm, and the buildbot (so far) seems >> happy with building the rest. > > Hmm, do you want to wrap my acks up to your previous one into this set? > What about my tested-by? > > I'd rather not waste time testing this version if my previous test is > still valid (or if there's yet another version of this patch set which > is later than this set.) > > Unless I hear anything, I'll assume that it's broadly the same as the > previous patch set and requires no action. Yeah, it's broadly the same. I tweaked a few minor things, so I'm comfortable retaining the acks and tested-bys. Thank you for the reviews and tests! -Kees -- Kees Cook Chrome OS Security