From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932201AbcHQVLd (ORCPT ); Wed, 17 Aug 2016 17:11:33 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36442 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932160AbcHQVLb (ORCPT ); Wed, 17 Aug 2016 17:11:31 -0400 MIME-Version: 1.0 In-Reply-To: <20160817201736.GB361@codeaurora.org> References: <1471393229-27182-1-git-send-email-keescook@chromium.org> <20160817201736.GB361@codeaurora.org> From: Kees Cook Date: Wed, 17 Aug 2016 14:11:28 -0700 X-Google-Sender-Auth: cv2BVc7XClUO3DqmYk1PSVSF7kY Message-ID: Subject: Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption To: Stephen Boyd , Syed Rameez Mustafa Cc: "Paul E . McKenney" , Laura Abbott , Steven Rostedt , Daniel Micay , Joe Perches , Arnd Bergmann , Greg Kroah-Hartman , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , "Aneesh Kumar K.V" , "Kirill A. Shutemov" , Michael Ellerman , Dan Williams , Andrew Morton , Ingo Molnar , Thomas Gleixner , Josef Bacik , Andrey Ryabinin , Tejun Heo , Nikolay Aleksandrov , Dmitry Vyukov , LKML , "kernel-hardening@lists.openwall.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2016 at 1:17 PM, Stephen Boyd wrote: > On 08/16, Kees Cook wrote: >> This adds a CONFIG to trigger BUG()s when the kernel encounters >> unexpected data structure integrity as currently detected with >> CONFIG_DEBUG_LIST. >> >> Specifically list operations have been a target for widening flaws to gain >> "write anywhere" primitives for attackers, so this also consolidates the >> debug checking to avoid code and check duplication (e.g. RCU list debug >> was missing a check that got added to regular list debug). It also stops >> manipulations when corruption is detected, since worsening the corruption >> makes no sense. (Really, everyone should build with CONFIG_DEBUG_LIST >> since the checks are so inexpensive.) >> >> This is mostly a refactoring of similar code from PaX and Grsecurity, >> along with MSM kernel changes by Stephen Boyd. > > Which commit in the MSM kernel from me? I wonder if perhaps > you're thinking of a patch from Syed Rameez Mustafa like commit > 1c014f321e6d67f47 in the msm-3.4 kernel. Ooof. I can't read. Yes, you were the committer, not the author! Whoops! https://android.googlesource.com/kernel/msm/+/7b49b86d3aa3d0c6400454a346bad1bbdf0cc78f%5E%21/#F0 I will adjust the changelog. Thanks! -Kees -- Kees Cook Nexus Security From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com MIME-Version: 1.0 Sender: keescook@google.com In-Reply-To: <20160817201736.GB361@codeaurora.org> References: <1471393229-27182-1-git-send-email-keescook@chromium.org> <20160817201736.GB361@codeaurora.org> From: Kees Cook Date: Wed, 17 Aug 2016 14:11:28 -0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: [kernel-hardening] Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption To: Stephen Boyd , Syed Rameez Mustafa Cc: "Paul E . McKenney" , Laura Abbott , Steven Rostedt , Daniel Micay , Joe Perches , Arnd Bergmann , Greg Kroah-Hartman , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , "Aneesh Kumar K.V" , "Kirill A. Shutemov" , Michael Ellerman , Dan Williams , Andrew Morton , Ingo Molnar , Thomas Gleixner , Josef Bacik , Andrey Ryabinin , Tejun Heo , Nikolay Aleksandrov , Dmitry Vyukov , LKML , "kernel-hardening@lists.openwall.com" List-ID: On Wed, Aug 17, 2016 at 1:17 PM, Stephen Boyd wrote: > On 08/16, Kees Cook wrote: >> This adds a CONFIG to trigger BUG()s when the kernel encounters >> unexpected data structure integrity as currently detected with >> CONFIG_DEBUG_LIST. >> >> Specifically list operations have been a target for widening flaws to gain >> "write anywhere" primitives for attackers, so this also consolidates the >> debug checking to avoid code and check duplication (e.g. RCU list debug >> was missing a check that got added to regular list debug). It also stops >> manipulations when corruption is detected, since worsening the corruption >> makes no sense. (Really, everyone should build with CONFIG_DEBUG_LIST >> since the checks are so inexpensive.) >> >> This is mostly a refactoring of similar code from PaX and Grsecurity, >> along with MSM kernel changes by Stephen Boyd. > > Which commit in the MSM kernel from me? I wonder if perhaps > you're thinking of a patch from Syed Rameez Mustafa like commit > 1c014f321e6d67f47 in the msm-3.4 kernel. Ooof. I can't read. Yes, you were the committer, not the author! Whoops! https://android.googlesource.com/kernel/msm/+/7b49b86d3aa3d0c6400454a346bad1bbdf0cc78f%5E%21/#F0 I will adjust the changelog. Thanks! -Kees -- Kees Cook Nexus Security