From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754299AbbCQPTZ (ORCPT ); Tue, 17 Mar 2015 11:19:25 -0400 Received: from mail-vc0-f179.google.com ([209.85.220.179]:37714 "EHLO mail-vc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753754AbbCQPTV (ORCPT ); Tue, 17 Mar 2015 11:19:21 -0400 MIME-Version: 1.0 In-Reply-To: <20150317144702.GN8399@arm.com> References: <1425503454-7531-1-git-send-email-keescook@chromium.org> <1425503454-7531-4-git-send-email-keescook@chromium.org> <20150317144702.GN8399@arm.com> Date: Tue, 17 Mar 2015 08:19:20 -0700 X-Google-Sender-Auth: T07ytXwOJ9bMMZ_Y3kgrTmxcFM0 Message-ID: Subject: Re: [PATCH v4 03/10] arm64: standardize mmap_rnd() usage From: Kees Cook To: Will Deacon Cc: "akpm@linux-foundation.org" , Ingo Molnar , Michael Ellerman , Hector Marco-Gisbert , Ismael Ripoll , Russell King , Catalin Marinas , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "linux390@de.ibm.com" , "x86@kernel.org" , Alexander Viro , Andy Lutomirski , Oleg Nesterov , "David A. Long" , Andrey Ryabinin , Arun Chandran , Yann Droneaud , Min-Hua Chen , Paul Burton , Alex Smith , Markos Chandras , Vineeth Vijayan , Jeff Bailey , Michael Holzheu , Ben Hutchings , Borislav Petkov , =?UTF-8?Q?Jan=2DSimon_M=C3=B6ller?= , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@linux-mips.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2015 at 7:47 AM, Will Deacon wrote: > On Wed, Mar 04, 2015 at 09:10:47PM +0000, Kees Cook wrote: >> In preparation for splitting out ET_DYN ASLR, this refactors the use of >> mmap_rnd() to be used similarly to arm and x86. This additionally enables >> mmap ASLR on legacy mmap layouts, which appeared to be missing on arm64, >> and was already supported on arm. Additionally removes a copy/pasted >> declaration of an unused function. >> >> Signed-off-by: Kees Cook >> --- >> arch/arm64/include/asm/elf.h | 1 - >> arch/arm64/mm/mmap.c | 18 +++++++++++------- >> 2 files changed, 11 insertions(+), 8 deletions(-) > > Looks fine to me: > > Acked-by: Will Deacon > > Do you want me to pick this up, or are you taking it along with the rest of > your series (it doesn't have any obvious dependencies to me)? Thanks! Right now akpm is carrying it, since the series ends with changes that depend on all the per-arch refactoring. -Kees -- Kees Cook Chrome OS Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH v4 03/10] arm64: standardize mmap_rnd() usage Date: Tue, 17 Mar 2015 08:19:20 -0700 Message-ID: References: <1425503454-7531-1-git-send-email-keescook@chromium.org> <1425503454-7531-4-git-send-email-keescook@chromium.org> <20150317144702.GN8399@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "akpm@linux-foundation.org" , Ingo Molnar , Michael Ellerman , Hector Marco-Gisbert , Ismael Ripoll , Russell King , Catalin Marinas , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "linux390@de.ibm.com" , "x86@kernel.org" , Alexander Viro , Andy Lutomirski , Oleg Nesterov , "David A. Long" , Andrey Ryabinin , Arun Chandran , Yann Droneaud , Min-Hua Chen Return-path: In-Reply-To: <20150317144702.GN8399@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Mar 17, 2015 at 7:47 AM, Will Deacon wrote: > On Wed, Mar 04, 2015 at 09:10:47PM +0000, Kees Cook wrote: >> In preparation for splitting out ET_DYN ASLR, this refactors the use of >> mmap_rnd() to be used similarly to arm and x86. This additionally enables >> mmap ASLR on legacy mmap layouts, which appeared to be missing on arm64, >> and was already supported on arm. Additionally removes a copy/pasted >> declaration of an unused function. >> >> Signed-off-by: Kees Cook >> --- >> arch/arm64/include/asm/elf.h | 1 - >> arch/arm64/mm/mmap.c | 18 +++++++++++------- >> 2 files changed, 11 insertions(+), 8 deletions(-) > > Looks fine to me: > > Acked-by: Will Deacon > > Do you want me to pick this up, or are you taking it along with the rest of > your series (it doesn't have any obvious dependencies to me)? Thanks! Right now akpm is carrying it, since the series ends with changes that depend on all the per-arch refactoring. -Kees -- Kees Cook Chrome OS Security From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vc0-x22f.google.com (mail-vc0-x22f.google.com [IPv6:2607:f8b0:400c:c03::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id BADBE1A012C for ; Wed, 18 Mar 2015 02:19:23 +1100 (AEDT) Received: by mail-vc0-f175.google.com with SMTP id hy4so198096vcb.6 for ; Tue, 17 Mar 2015 08:19:21 -0700 (PDT) MIME-Version: 1.0 Sender: keescook@google.com In-Reply-To: <20150317144702.GN8399@arm.com> References: <1425503454-7531-1-git-send-email-keescook@chromium.org> <1425503454-7531-4-git-send-email-keescook@chromium.org> <20150317144702.GN8399@arm.com> Date: Tue, 17 Mar 2015 08:19:20 -0700 Message-ID: Subject: Re: [PATCH v4 03/10] arm64: standardize mmap_rnd() usage From: Kees Cook To: Will Deacon Content-Type: text/plain; charset=UTF-8 Cc: "linux-mips@linux-mips.org" , Min-Hua Chen , Heiko Carstens , "linux-kernel@vger.kernel.org" , Arun Chandran , Paul Mackerras , Ismael Ripoll , Yann Droneaud , "linux-s390@vger.kernel.org" , Russell King , Andrey Ryabinin , "x86@kernel.org" , Hector Marco-Gisbert , Ingo Molnar , "David A. Long" , Catalin Marinas , Borislav Petkov , Ben Hutchings , "linux-fsdevel@vger.kernel.org" , Alexander Viro , Michael Holzheu , "linux-arm-kernel@lists.infradead.org" , Jeff Bailey , Paul Burton , Oleg Nesterov , Ralf Baechle , Andy Lutomirski , Vineeth Vijayan , Markos Chandras , =?UTF-8?Q?Jan=2DSimon_M=C3=B6ller?= , Martin Schwidefsky , "linux390@de.ibm.com" , "akpm@linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , Alex Smith List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Mar 17, 2015 at 7:47 AM, Will Deacon wrote: > On Wed, Mar 04, 2015 at 09:10:47PM +0000, Kees Cook wrote: >> In preparation for splitting out ET_DYN ASLR, this refactors the use of >> mmap_rnd() to be used similarly to arm and x86. This additionally enables >> mmap ASLR on legacy mmap layouts, which appeared to be missing on arm64, >> and was already supported on arm. Additionally removes a copy/pasted >> declaration of an unused function. >> >> Signed-off-by: Kees Cook >> --- >> arch/arm64/include/asm/elf.h | 1 - >> arch/arm64/mm/mmap.c | 18 +++++++++++------- >> 2 files changed, 11 insertions(+), 8 deletions(-) > > Looks fine to me: > > Acked-by: Will Deacon > > Do you want me to pick this up, or are you taking it along with the rest of > your series (it doesn't have any obvious dependencies to me)? Thanks! Right now akpm is carrying it, since the series ends with changes that depend on all the per-arch refactoring. -Kees -- Kees Cook Chrome OS Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: keescook@chromium.org (Kees Cook) Date: Tue, 17 Mar 2015 08:19:20 -0700 Subject: [PATCH v4 03/10] arm64: standardize mmap_rnd() usage In-Reply-To: <20150317144702.GN8399@arm.com> References: <1425503454-7531-1-git-send-email-keescook@chromium.org> <1425503454-7531-4-git-send-email-keescook@chromium.org> <20150317144702.GN8399@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 17, 2015 at 7:47 AM, Will Deacon wrote: > On Wed, Mar 04, 2015 at 09:10:47PM +0000, Kees Cook wrote: >> In preparation for splitting out ET_DYN ASLR, this refactors the use of >> mmap_rnd() to be used similarly to arm and x86. This additionally enables >> mmap ASLR on legacy mmap layouts, which appeared to be missing on arm64, >> and was already supported on arm. Additionally removes a copy/pasted >> declaration of an unused function. >> >> Signed-off-by: Kees Cook >> --- >> arch/arm64/include/asm/elf.h | 1 - >> arch/arm64/mm/mmap.c | 18 +++++++++++------- >> 2 files changed, 11 insertions(+), 8 deletions(-) > > Looks fine to me: > > Acked-by: Will Deacon > > Do you want me to pick this up, or are you taking it along with the rest of > your series (it doesn't have any obvious dependencies to me)? Thanks! Right now akpm is carrying it, since the series ends with changes that depend on all the per-arch refactoring. -Kees -- Kees Cook Chrome OS Security