From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753873AbbBYWR5 (ORCPT ); Wed, 25 Feb 2015 17:17:57 -0500 Received: from mail-oi0-f48.google.com ([209.85.218.48]:55778 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753225AbbBYWRz (ORCPT ); Wed, 25 Feb 2015 17:17:55 -0500 MIME-Version: 1.0 In-Reply-To: <1424902497-32141-1-git-send-email-lauraa@codeaurora.org> References: <1424902497-32141-1-git-send-email-lauraa@codeaurora.org> Date: Wed, 25 Feb 2015 14:17:55 -0800 X-Google-Sender-Auth: MrYSwAvcDs7KDgL5dZrAS0WT8dE Message-ID: Subject: Re: [PATCH 0/3] CONFIG_DEBUG_SET_MODULE_RONX fixups From: Kees Cook To: Laura Abbott Cc: Will Deacon , Catalin Marinas , Rusty Russell , Russell King , "linux-arm-kernel@lists.infradead.org" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 25, 2015 at 2:14 PM, Laura Abbott wrote: > Hi, > > CONFIG_DEBUG_SET_MODULE_RONX is currently non-functional on arm and arm64 > because of changes in behavior of is_module_addr. This series fixes > both arm and arm64 to work correctly and corrects a minor bug > related to section alignment in modules. > > Laura Abbott (3): > arm64: Don't use is_module_addr in setting page attributes > arm: Don't use is_module_addr in setting page attributes > kernel/module.c: Update debug alignment after symtable generation > > arch/arm/mm/pageattr.c | 5 ++++- > arch/arm64/mm/pageattr.c | 5 ++++- > kernel/module.c | 2 ++ > 3 files changed, 10 insertions(+), 2 deletions(-) Thanks for fixing this! Out of curiosity, which change broke DEBUG_SET_MODULE_RONX ? (i.e. does this need a CC: stable, and if so, through which release?) Regardless, consider them: Reviewed-by: Kees Cook Thanks! -Kees -- Kees Cook Chrome OS Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: keescook@chromium.org (Kees Cook) Date: Wed, 25 Feb 2015 14:17:55 -0800 Subject: [PATCH 0/3] CONFIG_DEBUG_SET_MODULE_RONX fixups In-Reply-To: <1424902497-32141-1-git-send-email-lauraa@codeaurora.org> References: <1424902497-32141-1-git-send-email-lauraa@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 25, 2015 at 2:14 PM, Laura Abbott wrote: > Hi, > > CONFIG_DEBUG_SET_MODULE_RONX is currently non-functional on arm and arm64 > because of changes in behavior of is_module_addr. This series fixes > both arm and arm64 to work correctly and corrects a minor bug > related to section alignment in modules. > > Laura Abbott (3): > arm64: Don't use is_module_addr in setting page attributes > arm: Don't use is_module_addr in setting page attributes > kernel/module.c: Update debug alignment after symtable generation > > arch/arm/mm/pageattr.c | 5 ++++- > arch/arm64/mm/pageattr.c | 5 ++++- > kernel/module.c | 2 ++ > 3 files changed, 10 insertions(+), 2 deletions(-) Thanks for fixing this! Out of curiosity, which change broke DEBUG_SET_MODULE_RONX ? (i.e. does this need a CC: stable, and if so, through which release?) Regardless, consider them: Reviewed-by: Kees Cook Thanks! -Kees -- Kees Cook Chrome OS Security