All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	John Dias <joaodias@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Min Chong <mchong@google.com>
Subject: Re: [PATCH] perf: protect group_leader from races that cause ctx
Date: Tue, 10 Jan 2017 15:54:03 -0800	[thread overview]
Message-ID: <CAGXu5jKNcRA8-LQJ+b1bvF2MKhj9v1z0fnwj89V-JbKPGePE0A@mail.gmail.com> (raw)
In-Reply-To: <20170110101646.GA5008@gmail.com>

On Tue, Jan 10, 2017 at 2:16 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> > [...]
>> > Reported-by: Kees Cook <keescook@chromium.org>
>>
>> I was just relaying a fix. I noted the original reporter in the first
>> patch, how they asked to be credited:
>>
>> Reported-by: Di Shen (@returnsme) of KeenLab (@keen_lab), Tencent
>
> So while it's OK to not give an email address (unlike Signed-off-by the
> Reported-by line is giving credit and has no code authorship legal effect),
> I agree with Peter that this line is pretty weird, bordering on the ugly.
>
> If the reporter doesn't want the email address exposed we can just skip the tag
> and credit the reporter in the changelog:
>
>   Di Shen reported that ...

Cleanest is probably just:

Reported-by: Di Shen

-Kees

-- 
Kees Cook
Nexus Security

  reply	other threads:[~2017-01-10 23:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05 23:14 Kees Cook
2017-01-06  9:32 ` Peter Zijlstra
2017-01-06 13:14   ` Peter Zijlstra
2017-01-06 20:39     ` Kees Cook
2017-01-07 16:29       ` John Dias
2017-01-09 23:16         ` Kees Cook
2017-01-10  8:46       ` Peter Zijlstra
2017-01-10 10:16       ` Ingo Molnar
2017-01-10 23:54         ` Kees Cook [this message]
2017-01-14 12:28     ` [tip:perf/urgent] perf/core: Fix concurrent sys_perf_event_open() vs. 'move_group' race tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGXu5jKNcRA8-LQJ+b1bvF2MKhj9v1z0fnwj89V-JbKPGePE0A@mail.gmail.com \
    --to=keescook@chromium.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=joaodias@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchong@google.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --subject='Re: [PATCH] perf: protect group_leader from races that cause ctx' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.