From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752918AbdF1EgI (ORCPT <rfc822;w@1wt.eu>);
        Wed, 28 Jun 2017 00:36:08 -0400
Received: from mail-io0-f174.google.com ([209.85.223.174]:35653 "EHLO
        mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751548AbdF1EgB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Jun 2017 00:36:01 -0400
MIME-Version: 1.0
In-Reply-To: <df3c647e-1724-bcbb-4467-22af0c3be6e7@osg.samsung.com>
References: <CA+G9fYtpFW+SHcaWCgt5ZAvPx3PO3x3nM+oRBUiOiQPbHVmw=w@mail.gmail.com>
 <20170627151359.GA11756@kroah.com> <20170627151600.GB11756@kroah.com> <df3c647e-1724-bcbb-4467-22af0c3be6e7@osg.samsung.com>
From: Kees Cook <keescook@chromium.org>
Date: Tue, 27 Jun 2017 21:35:59 -0700
X-Google-Sender-Auth: ecnSWTS9KpP_rYqQxT7eF5kKQMo
Message-ID: <CAGXu5jKhpCsCZ-4xUyYnBzmAQCi4=CnJKW5daqhZZMZRs-kkwg@mail.gmail.com>
Subject: Re: selftests/capabilities: test FAIL on linux mainline and
 linux-next and PASS on linux-4.4.70+
To: Shuah Khan <shuahkh@osg.samsung.com>,
        Andy Lutomirski <luto@kernel.org>
Cc: Greg KH <greg@kroah.com>, Naresh Kamboju <naresh.kamboju@linaro.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Shuah Khan <shuah@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 27, 2017 at 4:16 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 06/27/2017 09:16 AM, Greg KH wrote:
>> On Tue, Jun 27, 2017 at 05:13:59PM +0200, Greg KH wrote:
>>> On Tue, Jun 27, 2017 at 02:10:32PM +0530, Naresh Kamboju wrote:
>>>> selftest capabilities test failed on linux mainline and linux-next and
>>>> PASS on linux-4.4.70+
>>>
>>> Odd.  Any chance you can use 'git bisect' to track down the offending
>>> commit?
>>>
>>> Does this also fail on x86 or any other platform you have available?
>>> Let me go try this on my laptop...
>>
>> Ok, Linus's current tree (4.12.0-rc7+) also fails on this.  I'm guessing
>> it's failing, it's hard to understand the output.  If only we had TAP
>> output for this test :)
>
> As far as the output, it isn't bad. Not TAP13 will help make it better.
> The problem seems to with the individual messages error/info. messages
> themselves. This test has the quality of a developer unit test and the
> messages could be improved for non-developer use.
>
> I ran the test on 4.11.8-rc1+ and 4.9.35-rc1 see the same failure.
> It would be difficult to bisect this since it spans multiple releases.
> I am hoping Andy can give us some insight.

I bisected this to:

commit 380cf5ba6b0a0b307f4afb62b186ca801defb203
Author: Andy Lutomirski <luto@amacapital.net>
Date:   Thu Jun 23 16:41:05 2016 -0500

    fs: Treat foreign mounts as nosuid

I assume the test needs updating, but I bet Andy knows for sure. I can
look into this more closely in the morning.

-Kees

-- 
Kees Cook
Pixel Security